views_handler_filter_date cannot filter for NULL

I think really it should be checking explicitly for a need for 2 values like it does in views_handler_filter_date::validate_valid_time():

    if ($operators[$operator]['values'] == 1) {
      $convert = strtotime($value['value']);
      if (!empty($form['value']) && ($convert == -1 || $convert === FALSE)) {
        form_error($form['value'], t('Invalid date format.'));
      }
    }
    elseif ($operators[$operator]['values'] == 2) {
      $min = strtotime($value['min']);
      if ($min == -1 || $min === FALSE) {
        form_error($form['min'], t('Invalid date format.'));
      }
      $max = strtotime($value['max']);
      if ($max == -1 || $max === FALSE) {
        form_error($form['max'], t('Invalid date format.'));
      }
    }

Attached is a patch that fixes it.

Good catch on spotting views_handler_filter_date::validate_valid_time(). (I tried to fix this bug myself and wasn't sure how to construct the 'if block' exactly.) That means it doesn't really need any comments, IMHO.

(As for the related issue: its description says the same as what this patch fixes -except in D6 language-, but the patch under discussion seems to do a lot more than that. I think this patch should just be committed first, because it fixes the immediate bug.)

We've recently switched our testing from the old qa.drupal.org to DrupalCI. Because of a bug in the new system, #2623840: Views (D7) patches not being tested, older patches must be re-uploaded. On re-uploading the patch, please set the status to "Needs Review" so that the test bot will add it to its queue.

If all tests pass, change the Status back to "Reviewed & tested by the community". We'll most likely commit the patch immediately without having to go through another round of peer review.

We apologize for the trouble, and appreciate your patience.

Have re-uploaded the patch.

Thanks, patch #5 works for me.

I have tried to group all the patches/issues about this problem into one issue: https://www.drupal.org/node/2704699

Patch #5 also worked for me. I have included it in my distro build. Thanks!

Patch #5 also worked for me.

#5 works for me as well.

#5 works for me as well.

Is this also a problem in D8? If so, we'd need to create another issue.

Yes, I just confirmed this to be a problem in the latest 8.4.x branch. Fixing this is just as easy, but I really don't know yet how to open issues and submit patches properly. Maybe somebody can guide me or do it with this patch for d8:

diff --git a/core/modules/views/src/Plugin/views/filter/Date.php b/core/modules/views/src/Plugin/views/filter/Date.php
index dbb573f..f349419 100644
--- a/core/modules/views/src/Plugin/views/filter/Date.php
+++ b/core/modules/views/src/Plugin/views/filter/Date.php
@@ -152,7 +152,7 @@ public function acceptExposedInput($input) {
         return FALSE;
       }
     }
-    else {
+    elseif ($operators[$operator]['values'] == 2) {
       if ($this->value['min'] == '' || $this->value['max'] == '') {
         return FALSE;
       }

Aurangseb: Thanks for looking into this! First, create an issue in the "Drupal core" (short name: "drupal") project. We need to use Drupal core for this because Views is in core in Drupal 8.

Then, these two guides should help you:

• How to create a good issue
• Making a Drupal patch with Git

Please cross-reference the D7 and D8 issues by linking back and forth. Once done, we can move forward with each.

Created the D8 bug report and added a relation to this issue.

Thanks!

This works for me to. Could we get this into next release?

The 3 year old patch in #5 to views_handler_filter_date.inc does not apply to the latest 7.x-3.x-dev and needs a reroll.

Checking patch handlers/views_handler_filter_date.inc...
error: while searching for:
        return FALSE;
      }
    }
    else {
      if ($this->value['min'] == '' || $this->value['max'] == '') {
        return FALSE;
      }

error: patch failed: handlers/views_handler_filter_date.inc:146
error: handlers/views_handler_filter_date.inc: patch does not apply

My mistake everyone, this patch does apply to the latest 7.x-3.x HEAD.
thanks,

Committed. Thanks.