Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Goal
- Convert all usages of
system_settings_form()
intosystem_config_form()
. - Make all of these configuration objects adhere to the guidelines for How to convert variables into configuration.
Issues
Comment | File | Size | Author |
---|---|---|---|
#16 | 1696224-Remove-system_settings_form-16.patch | 4.9 KB | aroq |
Comments
Comment #1
sunFixing the utterly ugly styling.
Comment #1.0
larowlanAdded forum issue
Comment #2
gddThis is awesome! Thank you! Another tool I was planning on using was this spreadsheet that cosmicdreams made for me of every variable used in core
https://docs.google.com/spreadsheet/ccc?key=0ArZqEiDWc3yddGN6RVlzSER0NjF...
I wanted this list because there are quite a few variables that are not assigned to forms anywhere. While many of these will end up being 'state' variables, it is still good to track them all.
Comment #3
larowlanAdded forum sub-issue.
Comment #3.0
larowlanwrong col :)
Comment #3.1
nick_schuch CreditAttribution: nick_schuch commentedUpdate menu task link.
Comment #4
alexpottAdded book sub-issue.
Comment #4.0
alexpottAdd book conversion
Comment #5
alexpottAdd contact module's contact_form_user_admin_settings_alter().
Comment #5.0
alexpottAdd contact's form alter of user_admin_settings()
Comment #5.1
aspilicious CreditAttribution: aspilicious commentedtrigger update
Comment #5.2
n3or CreditAttribution: n3or commentedUpdated issue summary.
Comment #6
sun@n3or created #1705748: Convert simpletest settings to configuration system
Comment #6.0
sunUpdated issue summary.
Comment #6.1
tobiasbAdded issue link for systems date and time settings form
Comment #7
n3or CreditAttribution: n3or commentedAdded #1710512: Convert update settings to configuration system.
Comment #7.0
n3or CreditAttribution: n3or commentedUpdated issue summary.
Comment #8
n3or CreditAttribution: n3or commentedAdded #1712250: Convert theme settings to configuration system.
Comment #8.0
n3or CreditAttribution: n3or commentedUpdated issue summary. Added reference to system_theme_settings-issue.
Comment #9
sun@shuairan added #1712258: Simplify image toolkit form logic, removing unneeded checks.
Comment #10
sun#1708542: Convert systems date and time admin form to configuration system
Comment #10.0
sunUpdated issue summary.
Comment #11
n3or CreditAttribution: n3or commentedAdded #1714462: Convert language negotiation settings to configuration system.
Comment #11.0
n3or CreditAttribution: n3or commentedUpdated issue summary.
Comment #11.1
andypostAdded issue about locale module
Comment #12
Gaelan CreditAttribution: Gaelan commentedReplaced #1708542: Convert systems date and time admin form to configuration system added in #10 (duplicate) with #1571632: Convert regional settings to configuration system.
Comment #14
catchWe can remove system_settings_form() now.
Comment #15
aroq CreditAttribution: aroq commentedComment #16
aroq CreditAttribution: aroq commentedsystem_settings_form() removed, also changed theme_system_settings_form to theme_system_config_form.
Comment #17
catchComment #18
alexpottCommitted 8296db7 and pushed to 8.x. Thanks and hasta la vista magical dumping ground!
I've updated https://drupal.org/node/1910694 to reflect the change.
Comment #19
alexpottAdding tag back...
Comment #20
alexpottFixing title :)
Comment #21.0
(not verified) CreditAttribution: commentedReplaced #1708542, which was closed as a duplicate, with #1571632