Convert contact module variables to configuration system

Hm. I thought we'd merge this into the patch in #1496534: Convert account settings to configuration system ?

+++ b/core/modules/contact/config/contact.settings.yml
@@ -0,0 +1,5 @@
+user_contact_default_enabled: '1'

How about default_enabled ?

If you have a reason for naming it this way that's fine. Otherwise RTBC.

As moshe says, resist the nit-picking.

The "user" part seems appropriate, but I don't understand why we're duplicating "contact" in the key?

@cosmicdreams: moshe's comment wasn't meant universal, but specific to the user pictures issue, which is a major monster patch that has been RTBC a couple of times already.

Also, what's the deal with default_category? Any particular reason why that is not converted here?

If there's a strong reason for omitting it, then I think we should remove the key from the config file in this patch. Otherwise, let's just convert it here, too?

default_category is in the yml file, so the conversions should probably happen or the setting should also be omitted from that file.

This looks great! Only one last remark:

+++ b/core/modules/contact/contact.module
@@ -250,10 +250,23 @@ function contact_form_user_admin_settings_alter(&$form, &$form_state) {
-  $form['contact']['contact_default_status'] = array(
+  $form['contact']['user_default_enabled'] = array(
...
+    ->set('user_default_enabled', $form_state['values']['user_default_enabled'])

Let's leave the original $form array key alone, here. Since the settings form is not using #tree, the submitted form value is not namespaced for contact module, which in turn makes the original form key cleaner.

Sorry, nope, no such premature optimizations, please.

Looks good to me...

Almost done! :)

+++ b/core/modules/contact/contact.module
@@ -254,6 +254,19 @@ function contact_form_user_admin_settings_alter(&$form, &$form_state) {
+ * Form builder submit handler; Handle submission for user contact default.

This phpDoc should be:

Form submission handler for user_admin_settings().

@see contact_form_user_admin_settings_alter()

Thanks! :)

Committed to 8.x. Thanks. Keep 'em coming.

--- /dev/null
+++ b/core/modules/contact/config/contact.settings.yml

+++ b/core/modules/contact/config/contact.settings.yml
@@ -0,0 +1,4 @@

@@ -0,0 +1,4 @@
+flood:
+    limit: '5'
+    interval: '3600'
+user_default_enabled: '1'

This part

Added the missing file...

(git apply --index ftw.)