Closed (duplicate)
Project:
Drupal core
Version:
8.9.x-dev
Component:
user interface text
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
19 Aug 2007 at 17:18 UTC
Updated:
7 Oct 2020 at 05:26 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
kkaefer commented"Reset password" means "Passwort zurücksetzen". However, your point is valid, but it is simply not possible to translate the same string to two differing values. The english original needs to be changed.
Comment #2
salvisThe "Reset password" string appears only in the title of the user/reset/NNN/hex-string page, so IMHO it would be OK to tweak the German translation to "Passwort ändern" for 5.x-1.x-dev (and still change the English string for 6.x-dev, of course).
Comment #3
kkaefer commentedI am sorry, you are right. This string is indeed only used in one single place: for the title of the page. There is a similar string ("Request new password"). I changed the string in CVS (download a -dev version of the translation).
Comment #4
salvisThanks.
It's still a good idea to change the English string in 6.x though, because "change" is better than "reset" even in English, and other translations are likely to fall into the same trap with "reset."
Comment #5
catchThis changes the page title from "Reset password" to "Change password".
Comment #6
salvisReroll the patch to the current HEAD.
Comment #7
dries commentedI haven't checked the code but we should make sure that button/link-titles match page-titles.
Comment #8
salvisIt's the user/reset/NNN/hex-string page. There's no button/link to that page — you only get there if you use a one-time login link from an email message.
Comment #9
panchosubscribe
Comment #10
jody lynnString freeze deadline has passed. Moving to 7.x.
Comment #11
lilou commentedRe-roll.
Comment #12
keith.smith commentedComment #13
Anonymous (not verified) commentedThe last submitted patch failed testing.
Comment #14
Tor Arne Thune commentedMoving to 8.x, as string freeze for 7.x has passed since longtime.
Comment #15
yoroy commentedComment #16
drupal_was_my_past commentedRe-roll patch from #13 for 8.x.
Comment #17
devin carlson commentedThe patch in #16 does change the page title correctly but I think the password reset/change form could use some work which could be integrated into the same patch.
I also noticed that the email a user gets with the link to log in uses the following text:
This link can only be used once to log in and will lead you to a page where you can set your password.
Which might make them expect the page to be titled "Set password" as you can neither "change" nor "reset" a password that doesn't yet exist.
Comment #18
salvis(sorry, browser hiccup)
Comment #19
salvis@Devin Carlson: Congratulations on derailing a four-year-old issue that tries to fix an obvious bug. Please provide a text mock-up and patch for what you think the page should look like.
"Click on" describes perfectly what the user must do. Users who don't have a standard input device will know immediately what they need to do when they're asked to click somewhere. There's no need to confuse everyone (including those with standard input devices) by using some non-standard generalized terms that no one will understand.
Let's not split hairs. We can expect a tiny dose of common sense from the user and I'm sure you can come up with a body text wording that will work for first-time logins as well as for password resets, so that we don't need to provide and maintain two different pages.
You could check $user->access to find out whether the user has logged in before and adjust the page title accordingly, but if the user ever needs support then it's a clear advantage if the "Change password" page always has the same title.
Comment #20
devin carlson commentedIf you are assuming that the user has some common sense then why do you need to say "click on the button" at all? Since that's the only thing on the page, I'd assume that they would do it no matter what the page text says.
Thanks for the hint on $user->access, I'm still pretty new to Drupal development outside of theming.
I've attached a draft of how I think the page could read. If you think the existing page is better (more understandable, less user friendly, etc) I'd appreciate your feedback.
I'll see if anyone thinks that there should be some wording changes and then try to draft a patch.
Comment #21
tmsimont commentedIt really seems to me that the "Request new Password" and the "First time login link" should go to 2 different pages. Yes the functionality is the same, but the reason the user is viewing the page is totally different.
These two experiences are not the same:
A) User registers to the website and needs to login for the first time, and needs a password
B) User has already registered, set a password and forgot the password. Now the user needs a new password.
The current page text is fitting for use B, but not at all for A
The word "Reset" implies that the password was already set. It has not been set. This is a poor use of English for this page.
Similarly, the command "change your password" implies that it is changing from a value that already exists. This is also false.
This makes the registration process unnecessarily confusing.
Honestly I think it's really weird that the "Reset password" page is presented during the new user registration process at all.
Let's say you are a user and you use your log in link -- what's the incentive to set a password now? What if you fail to do this? I've seen this failure result in confusion way too many times.
Why not give the new user a similar link that goes to a new "Set your password and login" page that presents a form where the user can create a new password in order to log in?
Comment #22
tmsimont commentedmaybe I'm being overzealous but I'm gonna tag this as DrupalWTF because this is something that has been bothering me for years. I'm tired of explaining this to every client that ever takes over a drupal site from me.
Comment #31
pameeela commentedThis was addressed in #2297185: 'Reset password' should be 'Set password' when no password given yet. - the page is called 'Set password' for the first time login.
New user:

Existing user:
