A newly registered user who clicks on the login link is greeted by the user/reset/NNN/hex-string page. The English page title is "Reset password," which is not great but acceptable. However, the German translation reads "Neues Passwort anfordern," i.e. "Request new password," which is clearly wrong in this context. It should be "Passwort ändern," i.e. "Change password."

The English "Reset" is acceptable in this context, but "Change" would probably be better and result in better translations...

Comments

kkaefer’s picture

Title: Bad "Neues Passwort anfordern" title » String freeze: Bad "reset password" title
Project: German translation » Drupal core
Version: 5.x-1.x-dev » 6.x-dev
Component: PO files » user system

"Reset password" means "Passwort zurücksetzen". However, your point is valid, but it is simply not possible to translate the same string to two differing values. The english original needs to be changed.

salvis’s picture

The "Reset password" string appears only in the title of the user/reset/NNN/hex-string page, so IMHO it would be OK to tweak the German translation to "Passwort ändern" for 5.x-1.x-dev (and still change the English string for 6.x-dev, of course).

kkaefer’s picture

Project: Drupal core » German translation
Version: 6.x-dev » 5.x-1.x-dev
Component: user system » PO files
Status: Active » Fixed

I am sorry, you are right. This string is indeed only used in one single place: for the title of the page. There is a similar string ("Request new password"). I changed the string in CVS (download a -dev version of the translation).

salvis’s picture

Project: German translation » Drupal core
Version: 5.x-1.x-dev » 6.x-dev
Component: PO files » user system
Status: Fixed » Active

Thanks.

It's still a good idea to change the English string in 6.x though, because "change" is better than "reset" even in English, and other translations are likely to fall into the same trap with "reset."

catch’s picture

Status: Active » Needs review
StatusFileSize
new646 bytes

This changes the page title from "Reset password" to "Change password".

salvis’s picture

StatusFileSize
new694 bytes

Reroll the patch to the current HEAD.

dries’s picture

I haven't checked the code but we should make sure that button/link-titles match page-titles.

salvis’s picture

It's the user/reset/NNN/hex-string page. There's no button/link to that page — you only get there if you use a one-time login link from an email message.

pancho’s picture

subscribe

jody lynn’s picture

Version: 6.x-dev » 7.x-dev

String freeze deadline has passed. Moving to 7.x.

lilou’s picture

StatusFileSize
new645 bytes

Re-roll.

keith.smith’s picture

Component: user system » user interface text
Anonymous’s picture

Status: Needs review » Needs work

The last submitted patch failed testing.

Tor Arne Thune’s picture

Version: 7.x-dev » 8.x-dev

Moving to 8.x, as string freeze for 7.x has passed since longtime.

yoroy’s picture

Title: String freeze: Bad "reset password" title » Bad "reset password" title
drupal_was_my_past’s picture

Status: Needs work » Needs review
StatusFileSize
new484 bytes

Re-roll patch from #13 for 8.x.

devin carlson’s picture

Title: Bad "reset password" title » Improve reset password form title and page text
Status: Needs review » Needs work
StatusFileSize
new13.82 KB

The patch in #16 does change the page title correctly but I think the password reset/change form could use some work which could be integrated into the same patch.

Only local images are allowed.

  • The third sentence is redundant. The first sentence says "this is a one-time login" which is then followed by, in the third sentence, "this login can be used only once".
  • The second sentence says "click on" which poorly describes what a user must do; the user may not be using a device which has a mouse such as a phone/tablet/touchscreen device or someone using only a keyboard (often people who have a visual impairment).
  • The second sentence says "this button" but doesn't reference a button and isn't actually a button itself. This is an accessibility concern as a user would have to read until the end of the form to realize that the text was probably referring to the "Log in" button and the text "this button" wasn't just a broken link.
  • As Dries mentioned about the button title, the button text doesn't make much sense in the content of the page. If a user is trying to log in for the first time and the page is titled something like "Set password" why are they given an action that supposedly allows them to login even though the email they followed to get to the page said that they needed to set their password before logging in "After setting your password, you will be able to log in"?

I also noticed that the email a user gets with the link to log in uses the following text:


This link can only be used once to log in and will lead you to a page where you can set your password.

Which might make them expect the page to be titled "Set password" as you can neither "change" nor "reset" a password that doesn't yet exist.

salvis’s picture

(sorry, browser hiccup)

salvis’s picture

@Devin Carlson: Congratulations on derailing a four-year-old issue that tries to fix an obvious bug. Please provide a text mock-up and patch for what you think the page should look like.

The second sentence says "click on" which poorly describes what a user must do; the user may not be using a device which has a mouse such as a phone/tablet/touchscreen device or someone using only a keyboard (often people who have a visual impairment).

"Click on" describes perfectly what the user must do. Users who don't have a standard input device will know immediately what they need to do when they're asked to click somewhere. There's no need to confuse everyone (including those with standard input devices) by using some non-standard generalized terms that no one will understand.

Which might make them expect the page to be titled "Set password" as you can neither "change" nor "reset" a password that doesn't yet exist.

Let's not split hairs. We can expect a tiny dose of common sense from the user and I'm sure you can come up with a body text wording that will work for first-time logins as well as for password resets, so that we don't need to provide and maintain two different pages.

You could check $user->access to find out whether the user has logged in before and adjust the page title accordingly, but if the user ever needs support then it's a clear advantage if the "Change password" page always has the same title.

devin carlson’s picture

Status: Needs work » Needs review
StatusFileSize
new33.94 KB

If you are assuming that the user has some common sense then why do you need to say "click on the button" at all? Since that's the only thing on the page, I'd assume that they would do it no matter what the page text says.

Thanks for the hint on $user->access, I'm still pretty new to Drupal development outside of theming.

I've attached a draft of how I think the page could read. If you think the existing page is better (more understandable, less user friendly, etc) I'd appreciate your feedback.

I'll see if anyone thinks that there should be some wording changes and then try to draft a patch.

tmsimont’s picture

Status: Needs review » Active

I'm sure you can come up with a body text wording that will work for first-time logins as well as for password resets, so that we don't need to provide and maintain two different pages.

It really seems to me that the "Request new Password" and the "First time login link" should go to 2 different pages. Yes the functionality is the same, but the reason the user is viewing the page is totally different.

These two experiences are not the same:
A) User registers to the website and needs to login for the first time, and needs a password
B) User has already registered, set a password and forgot the password. Now the user needs a new password.

The current page text is fitting for use B, but not at all for A

Reset password

This is a one-time login for XXX and will expire on XXXX.
Click on this button to log in to the site and change your password.
This login can be used only once.

The word "Reset" implies that the password was already set. It has not been set. This is a poor use of English for this page.
Similarly, the command "change your password" implies that it is changing from a value that already exists. This is also false.

This makes the registration process unnecessarily confusing.

Honestly I think it's really weird that the "Reset password" page is presented during the new user registration process at all.

Let's say you are a user and you use your log in link -- what's the incentive to set a password now? What if you fail to do this? I've seen this failure result in confusion way too many times.

Why not give the new user a similar link that goes to a new "Set your password and login" page that presents a form where the user can create a new password in order to log in?

tmsimont’s picture

Issue tags: +DrupalWTF

maybe I'm being overzealous but I'm gonna tag this as DrupalWTF because this is something that has been bothering me for years. I'm tired of explaining this to every client that ever takes over a drupal site from me.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

pameeela’s picture

This was addressed in #2297185: 'Reset password' should be 'Set password' when no password given yet. - the page is called 'Set password' for the first time login.

New user:

Existing user: