'Reset password' should be 'Set password' when no password given yet.

I'm not certain, but I think this is still the case in 8.x. If it is, then it will have to be changed there first.

Changed title from Reset Password to Set Password for one time login.

Hello!

Thank you for working on this issue!

We should all try and use the same sprint tag. According to https://groups.drupal.org/node/447258 it should be SprintWeekend2015 with no #.

Also, if you want the testbot to execute the tests, you should check the status to Needs Review.

Great catch mhazy, I've tested the patch and it's working no problem. Great usability fix guys!

I'm doing a beta evaluation of this issue.

Setting the issue category to Task because it's "rewriting user interface strings for brevity and clarity."

Setting the issue priority to Normal because "affects one piece of functionality are normal priority". It's not a cosmetic change because it adds clarity to the wording and two translateable strings.

It's a prioritized change, because it falls under usability and user experience improvements. It can also be backported to D7.

The issue summary needs to be updated to mention that "Reset Password" is not currently a translateable string and should be.

+1, works for me perfectly.

+++ b/core/modules/user/src/Form/UserPasswordResetForm.php
@@ -72,13 +72,14 @@ public function getFormID() {
+      $form['#title'] = t('Reset Password');
...
+      $form['#title'] = t('Set Password');

$this->t() should be used here.

The title with/without password should be tested.

Updated patch, plus one test for 'Reset Password' string. Setting to Needs Review to trigger testbot but it still needs another test for the other string, probably in UserRegistrationTest.php.

One more time: updated patch, plus one test for 'Reset Password' string. Still needs a test for the 'Set Password' string.

Added test for 'Set Password' after registration. I'm sure there is a better way to do this than copying the getResetURL function, though, so this part still needs work.

@mhazy, good to know about user_pass_reset_url.

1. +++ b/core/modules/user/src/Tests/UserRegistrationTest.php
   @@ -277,5 +280,4 @@ function testRegistrationWithUserFields() {
   -
   

   Need to leave in that blank line before the very end of a class, per https://www.drupal.org/node/608152

Perfact @alimac, Just added that line as well in updated patch. and Good work @mhazy

@RavindraSingh: there are extra spaces on that blank line that need to be deleted:

When you post a patch, it is a good idea to also post an interdiff, to show the difference from one patch to the next: https://www.drupal.org/documentation/git/interdiff

I am not sure why this patch failed testing, the failing tests appear to be cache related..

Cleaning the whitespaces

Perfect!, It works for me.

I Applied this patch locally, and I did a visual review of it.

It is what I did. I created an account, and then It sent me an email, asking me set my password. Before the patch, It was showing reset Password in the title, and after apply this patch, It shows Set password in the title.

There is not test only patch, so we cannot confirm the patch at #25 includes a working test.

Perfect!, It works for me.

I Applied this patch locally, and I did a visual review of it.

It is what I did. I created an account, and then It sent me an email, asking me set my password. Before the patch, It was showing reset Password in the title, and after apply this patch, It shows Set password in the title.

There is not test only patch, so we cannot confirm the patch at #25 includes a working test.

Some screenshots from my review:

Before:

After:

Going to reopen this to manually test the multilingual functionality to ensure both "Reset password" and "Set Password" are translatable strings now.

"Reset Password" and "Set Password", are technically wrong, It should be "Reset password" and "Set password" as is recommended in here https://www.drupal.org/node/84146

This is a test only patch. I am doing this because I learned it from Dupalcon Bogotá. It is a good practice, because if it fails before apply the patch commented at #25 this means that the test works.

that was a tests only patch. which failed nicely. this is needs review.

Patch with the word password in lowercase for the title. Wrong patch, ignore.

Patch with the word password in lowercase for the title.

I'm not sure if that old issue (referenced in #31) clarifies the casing,
but
the reset your password page title is "Reset your password"

in head right now.

also looked using
ag '\$form\[.#title.\] = '
for example in head. and lower case seems used else where in core.

has tests. so removing the needs tests tag.

Patch with the word password in lowercase for the title.

I read the patch and discussed this. (if green) rtbc.

Committed df0bde0 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary and it's great to see a test for the logic.

I'm not sure that this can be backported since it changes UI text - won't translations have to be changed?

Reading https://www.drupal.org/node/1527558 - this is not eligible for backport.

Removing the tag per #43.