Postponed (maintainer needs more info)
Project:
Drupal core
Version:
main
Component:
language system
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
13 Jun 2012 at 11:15 UTC
Updated:
21 Aug 2025 at 16:09 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #1
gábor hojtsyAdd missing tags.
Comment #2
floretan commentedAssigning to myself. I'll work on this tomorrow at the code sprint.
Comment #3
floretan commentedHere's a patch and a screenshot of the result.
Note that the node count only includes nodes of types that can have a language.
Injecting node translation data should probably be done in a separate issue.
Comment #4
gábor hojtsyAs per live discussion:
- item => post
- make links work to actually limit to language
Comment #5
gábor hojtsyComment #6
floretan commentedUpdated patch:
- "Item" replaced with "post"
- "language" parameter added to the link to the content overview page. Making that form accept $_GET parameters opens a whole bunch of issues due to it's twisted use of session variables though, so this should be done in a separate issue.
Comment #7
floretan commentedDidn't mean to include the part regarding node.admin.inc. Thanks to attiks for pointing this out.
Comment #9
artusamakHaving a look at the test failures. Adding an additional check if no content types are translatable.
Comment #10
floretan commentedThanks Artusamak. Here's an updated patch that only inserts the additional column if at least one content type can be translated.
Comment #11
artusamakWorking great for me!
Comment #12
artusamakComment #13
gábor hojtsyStill needs tests.
Comment #14
gábor hojtsyComment #15
artusamakOn it!
Comment #16
artusamakHere is a test to check that the language overview table is displaying the posts count per language when available.
Comment #17
webflo commentedLooks good. Only a few minors.
Its only one user.
We dont do 'for ...'. Use @see language_admin_overview_form().
node_type_get_types() is easier.
Comment #18
webflo commentedRemoved 'Needs tests' tag.
Comment #19
webflo commentedAdded sprint.
Comment #20
jepster_I've applyed the patch from #16 but I cannot find the test "Node language statistics" at admin/config/development/testing.
Comment #21
artusamakListed issues fixed.
@jepSter the group for the test was wrong, it's normally fixed.
Comment #22
jepster_After I get a fresh copy of drupal 8 files, patch drupal 8 with your file from #21 and choose your test "Node language statistics" at admin/config/development/testing/ and start the testing, I get 32 passes, 7 fails, 0 exceptions, and 10 debug messages.
the following is failing:
Comment #23
gábor hojtsyNode type language setup code changed since the patch was rolled, that is the reason.
Comment #24
gábor hojtsy#21: nodes_language_table-1632222-21.patch queued for re-testing.
Comment #26
artusamakHere is an update of the test and the form alter.
Since the content type language changed, i'm listing the posts for every language (even special ones).
I removed the link if there is no post and removed the t() calls from the messages to be compliant with http://drupal.org/simpletest-tutorial-drupal7#t
Comment #27
gábor hojtsyThis is a nice to have and have been called out for possible performance problems. Moving off of the sprint in the intrest of focusing people on the important stuff.
Comment #28
jair commentedNeeds reroll
Comment #29
nitesh sethia commentedRerolling the patch #26
Comment #30.0
(not verified) commentedAdd one more note and image
Comment #31
alansaviolobo commentedrerolled the patch.
Comment #33
xen commentedThe langcode field have moved from the node table to the node_revision table.
Also moved the test file to PSR-4 location, and fixed the test to pass.
Comment #34
xen commentedUnassigning.
Comment #35
xen commentedThe test is inadequate in my opinion. It basically just tests that the text changes when adding a new node, not that the code actually counts the number of nodes in each language.
Extending the test by adding another language and checking that each language count is correct should do it.
Comment #37
jhedstromPatch no longer applies.
Comment #38
ashishdalviComment #39
ashishdalviRerolled Patch.
Comment #41
rajeshwari10 commentedApplying Patch.
Comment #43
drupradPatch rerolled for 8.2.x
Comment #46
pashupathi nath gajawada commentedPlease find the updated patch #46 with code indentation and with appropriate comments.
Thanks,
Comment #50
manuel garcia commentedComment #51
yogeshmpawarUpdated patch against 8.3.x
Comment #66
smustgrave commentedThank you for sharing your idea for improving Drupal.
We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!