Optimize for cardinality > 1

Indeed, I can confirm the bug. Products are correctly added, but after saving, the product reference is not added it seems.

Ok. I'm just silly : I've put 1 product only in the widget, and not illimited.

So it's no critical bug : just edit the widget type and put 'illimited'.

Still a bug, as it is not possible to configure the widget as not being unlimited : if so, the button is still there even if the specified number is reached.

Yeah, IEF needs to handle this better. It is currently only optimized for unlimited values.

I was thinking of not showing the add button anymore when cardinality is reached, and always showing a message notifying the user about the maximum allowed number of entities.

See also this issue: #1598296: Add a simplified widget for fields that accept only one entity of a specific type where I'm attempting to optimize for cardinality 1 (showing the inline form in a fieldset, no table, no buttons).

Okay, so #1598296: Add a simplified widget for fields that accept only one entity of a specific type was committed, which means we now handle optimally both cardinality: 1 and cardinality: unlimited.

We now need to handle the other cases, by showing the maximum number of values in the widget #description, and hiding the "add" button once that number is reached.

Here's a patch that compares cardinality to number of entities referenced. It updates the $element description and prevents adding more entities if cardinality has been reached.

Setting as needs review

Quick eyeball review. All nitpicky fiddly stuff :)

+++ b/inline_entity_form.module
@@ -387,6 +388,22 @@ function inline_entity_form_field_widget_form(&$form, &$form_state, $field, $ins
+  $entity_count = sizeof($form_state['inline_entity_form'][$ief_id]['entities']);

sizeof is an alias of count according to PHP docs -- it's probably better code style to stick to one.

+++ b/inline_entity_form.module
@@ -387,6 +388,22 @@ function inline_entity_form_field_widget_form(&$form, &$form_state, $field, $ins
+  $cardinality == -1 ? $cardinality_count = 'Unlimited' : $cardinality_count = $cardinality;

FieldAPI has a special constant for the unlimited cardinality; don't use -1.

Also, shouldn't 'Unlimited' be translated?

+++ b/inline_entity_form.module
@@ -387,6 +388,22 @@ function inline_entity_form_field_widget_form(&$form, &$form_state, $field, $ins
+  if($cardinality > 0 && $entity_count >= $cardinality){

Needs a space after the if

+++ b/inline_entity_form.module
@@ -387,6 +388,22 @@ function inline_entity_form_field_widget_form(&$form, &$form_state, $field, $ins
+      return $element;

Indentation is wrong.

Also, comments need a full stop.

This also about how IEF lets me attempt to add further items, but then loses them if I've gone over the cardinality -- hence that's data loss and hence a bug :)

I've applied the patch and I can confirm it's no longer letting me go past the cardinality in the UI.

Thanks for the review @joachim. Here's and updated patch.

#12 patch works really nice. I've tested in commerce environment, and outside (reference from node to node).

@andyg5000 thanks for the patch!

Tweaked the wording, made the message not show up if the field is unlimited, fixed a bug, committed. Huge thanks, Andy!

http://drupalcode.org/project/inline_entity_form.git/commitdiff/9483464?...