Linkchecker does not skip unsupported blocks (only custom blocks from block.module are supported) [#1603782]

When I edit a custom block I get the following error..

PDOException: SQLSTATE[HY000]: General error: 1366 Incorrect integer value: 'weekend_briefing_driver' for column 'bid' at row 1: INSERT INTO {linkchecker_block_custom} (bid, lid) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1); Array ( [:db_insert_placeholder_0] => weekend_briefing_driver [:db_insert_placeholder_1] => 21991 ) in _linkchecker_add_block_custom_links() (line 957 of modules/contrib/linkchecker/linkchecker.module).

Comments

Comment #1

hass commented 29 May 2012 at 18:45

Priority:	Major	» Normal
Status:	Active	» Postponed (maintainer needs more info)

This must a logic flaw in line 910. Can you make a dump of $block_custom and $bid, please?

Line 908:

var_dump($block_custom);
var_dump($bid);

  // Custom blocks really suxxx as it's very inconsistent core logic.
  // Try to hack around this bad logic as good as possible to prevent issues.
  if ($block_custom->module != 'block' && !is_numeric($block_custom->delta) && !is_numeric($bid) && $block_custom->delta != $bid) {
    return;
  }

Comment #2

kingfisher64 commented 31 May 2012 at 14:54

I'm not sure if it's the same issue, didn't want to start a new one in case it was. When I edit a class within a block and save the following pops up and then disappears upon refresh

Notice: Undefined property: stdClass::$body in _linkchecker_add_block_custom_links() (line 889 of C:\wamp\www\kingfisher\sites\all\modules\linkchecker\linkchecker.module).

Notice: Undefined property: stdClass::$body in _linkchecker_add_block_custom_links() (line 893 of C:\wamp\www\kingfisher\sites\all\modules\linkchecker\linkchecker.module

Comment #3

kingfisher64 commented 31 May 2012 at 14:55

Status:

Postponed (maintainer needs more info)

» Active

I'm not sure if it's the same issue, didn't want to start a new issue in case it is. When I edit the class of a block (eg changing it to something else) upon save I get the following errors.

Notice: Undefined property: stdClass::$body in _linkchecker_add_block_custom_links() (line 889 of C:\wamp\www\kingfisher\sites\all\modules\linkchecker\linkchecker.module).

Notice: Undefined property: stdClass::$body in _linkchecker_add_block_custom_links() (line 893 of C:\wamp\www\kingfisher\sites\all\modules\linkchecker\linkchecker.module

Comment #4

hass commented 31 May 2012 at 20:28

Status:

Active

» Postponed (maintainer needs more info)

Not the same and already fixed.

Comment #5

hass commented 22 June 2012 at 20:06

Title:	Linkchecker inserting string instead of integer for custom blocks	» Linkchecker does not skip unsupported blocks (only blocks from block.module are supported)
Status:	Postponed (maintainer needs more info)	» Fixed
Issue tags:		+blocks