Calling search_form is not very flexible.

- Now we can have the settings on, but this going to break the website if the search module is not enable.
- the form is not cached (like with block)

I think is better to create a specific regions for the search box and use a hook_form_alter to eventually adapt the default search form.

Comments

kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen commented
Priority: Normal » Major

Yeah... seems rather odd to be inflexible like that. Disabling Search module causes a fatal PHP error.

frankbaele’s picture

frankbaele CreditAttribution: frankbaele commented
Assigned: Unassigned » frankbaele

You are right this needs to be fixed, its too inflexible

frankbaele’s picture

frankbaele CreditAttribution: frankbaele commented
Assigned: frankbaele » Unassigned
andregriffin’s picture

andregriffin CreditAttribution: andregriffin commented
Project: Twitter's Bootstrap » Bootstrap Framework
andregriffin’s picture

andregriffin CreditAttribution: andregriffin commented
Project: Bootstrap Framework » Twitter's Bootstrap
natted’s picture

natted CreditAttribution: natted commented
Project: Twitter's Bootstrap » Bootstrap
frankbaele’s picture

frankbaele CreditAttribution: frankbaele commented
Status: Active » Fixed

This issue has been fixed for the error part, but i agree that the search field shouldn't be hard-coded like that and will not be in the 3.x branch

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.