I have uploadprogress enabled on Lightspeed, and it works with Drupal, yet the status report page says "Your server is not capable of displaying file upload progress. File upload progress requires an Apache server running PHP with mod_php."

Can we remove if (!$apache) from file_requirements() since it is highly likely uploadprogress still works with forks of Apache? Or would this specifically require detection of Lightspeed?

CommentFileSizeAuthor
#28 1440584-nr-bot.txt187 bytesneeds-review-queue-bot
#24 file_module_reports_server_not_capable_of-14405840-24.patch3.53 KBimclean
#21 file_module_reports_server_not_capable_of-14405840-21.patch3.53 KBimclean
#20 file_module_reports_server_not_capable_of-14405840-20.patch3.53 KBimclean
#1 1440584-File-module-reports-server-is-not-capable-of.patch5.48 KBmstrelan

Comments

mstrelan’s picture

mstrelan commented
Status: Active » Needs review
StatusFileSize
new 1440584-File-module-reports-server-is-not-capable-of.patch5.48 KB

Doesn't it make more sense to detect the presence of uploadprogress first, before checking why uploadprogress might not be present? This patch will resolve the issue for Litespeed and any other web server that reports uploadprogress is installed, and still suggests using Apache if uploadprogress is not installed.

michaelgc’s picture

michaelgc commented

#1: 1440584-File-module-reports-server-is-not-capable-of.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1440584-File-module-reports-server-is-not-capable-of.patch, failed testing.

nitinpatel’s picture

nitinpatel commented
Status: Needs work » Needs review

#1: 1440584-File-module-reports-server-is-not-capable-of.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1440584-File-module-reports-server-is-not-capable-of.patch, failed testing.

Anonymous’s picture

Anonymous (not verified) commented
Issue summary: View changes

any news?

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

caehiew’s picture

caehiew commented
Issue tags: +Uploadprogress Drupal 8.5.x on Litespeed server

We are running Litespeed webserver and it shows the error that "Your server is not capable of displaying file upload progress. File upload progress requires an Apache server running PHP with mod_php or Nginx with PHP-FPM".

This seems to be like an incompatibility with on how Drupal checks the module enabled or not... though Litespeed webserver do support the uploadprogress bar.

So it looks like the extension/function is only known to work with an Apache server running PHP with mod_php or Nginx with PHP-FPM and shows warning on other SAPI implementations.

Hope to have a fix on this, although annoying but Drupal still working fine.

Thank you and regards.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
3eidoz’s picture

3eidoz commented

I running Litespeed web server and it shows the error that "Not enabled: Your server is not capable of displaying file upload progress. File upload progress requires an Apache server running PHP with mod_php or Nginx with PHP-FPM.".

Hope to have a fix on this, although annoying but Drupal(9.3.6) still working.

Thanks.

imclean’s picture

imclean commented
Related issues: +#3277851: Inaccurate detection of PHP server API used to determine upload progress support 
+++ b/core/modules/file/file.install
@@ -53,39 +53,41 @@ function file_requirements($phase) {
+      $fastcgi = strpos($_SERVER['SERVER_SOFTWARE'], 'mod_fastcgi') !== FALSE || strpos($_SERVER["SERVER_SOFTWARE"], 'mod_fcgi') !== FALSE;

This matches both mod_fcgi and mod_fcgid. It might be more accurate to use https://www.php.net/php_sapi_name .

imclean’s picture

imclean commented
Status: Needs work » Needs review
StatusFileSize
new file_module_reports_server_not_capable_of-14405840-20.patch3.53 KB

New patch for 9.3.x taking into account #19.

imclean’s picture

imclean commented
StatusFileSize
new file_module_reports_server_not_capable_of-14405840-21.patch3.53 KB

strpos check should probably use ==.

Status: Needs review » Needs work

The last submitted patch, 21: file_module_reports_server_not_capable_of-14405840-21.patch, failed testing. View results

mstrelan’s picture

mstrelan commented

strpos check should probably use ==.

Better yet we should make use of str_starts_with() or str_contains() from newer PHP versions, but available in Drupal thanks to Symfony polyfills.

imclean’s picture

imclean commented
Status: Needs work » Needs review
StatusFileSize
new file_module_reports_server_not_capable_of-14405840-24.patch3.53 KB

Makes sense. It's a bit neater.

imclean’s picture

imclean commented

The issue number in the patch filename isn't quite right.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 1440584-nr-bot.txt187 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs work » Postponed (maintainer needs more info)
Issue tags: - +Bug Smash Initiative

This came up as a daily BSI target

Wonder after a few years if still an issue?

mstrelan’s picture

mstrelan commented

As the original reporter of this issue 13 years ago I would imagine it probably is still a problem. But I haven't used Litespeed in probably 10 years and I'm guessing not many others are using it either.

I'd vote to close it as outdated, but let's give it a couple months at postponed in case any of the folks who commented in the last few years want to continue this.

smustgrave’s picture

smustgrave commented

Sounds like a plan, we don't close issues till after at least 3 months.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented

I'd say this is outdated since we just check if the extension is enabled now.

mstrelan’s picture

mstrelan commented

@kim.pepper it looks like we first check for the extension, but even if it's enabled we then go on and check if we're using apache or nginx. If it's neither we say it's disabled. https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/file/...

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented

Yeah, not sure of the history of this one. I think we could do away with the check for apache and nginx and just display the default "extension missing" message.

acbramley’s picture

acbramley commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Came up in BSI again, it sounds like this can be closed.