Problem:

Only local images are allowed.

Currently the asterisk that is added to the label of required form elements is colored red. This is not the best core default: it attracts too much attention and red sends the wrong message (red = error).

Solution:

remove the CSS bit that adds the red color.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task since it's not a bug, but change in a way content is displayed
Issue priority Normal
Unfrozen changes Unfrozen since it changes only CSS

Passes beta evaluation process, committable to 8.0.x

CommentFileSizeAuthor
#40 Screenshot 2024-05-30 at 8.55.58 AM.png46.25 KBgauravvvv
#40 Screenshot 2024-05-30 at 8.55.02 AM.png45.02 KBgauravvvv
#36 1214008-36-claro_affected.png49.71 KBbaluertl
#36 1214008-36-olivero_unaffected.png46.13 KBbaluertl
#23 required-asterisks.png73.12 KByoroy
#14 register.png51.89 KBmanauwarsheikh
#13 required-asterisk-color-1214008-12.patch2.43 KBstborchert
#7 Zrzut ekranu 2013-12-19 o 20.41.57.png14.54 KBphilipz
#6 1214008-6.patch780 bytesareke
#1 red-asterisk-1214008.patch399 bytesyoroy

Issue fork drupal-1214008

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yoroy’s picture

yoroy commented
Status: Active » Needs review
StatusFileSize
new red-asterisk-1214008.patch399 bytes
Bojhan’s picture

Bojhan commented

Subscribe, I agree its too prominent especially on forms with a lot of required fields it gets a bit messy. I am not sure enough to mark it, RTBC though.

dawehner’s picture

dawehner
Primary language German
commented

I'm wondering whether something black stands out enough.

oadaeh’s picture

oadaeh commented

What about using a medium green (#0b0 or #0c0) as the marker color? It would stand out a bit from black and would be inviting, rather than alarming. I think blue would be confused with links.

valthebald’s picture

valthebald
Location Sofia
commented
Issue tags: +#d8ux

Tagging

areke’s picture

areke commented
Issue summary: View changes
StatusFileSize
new 1214008-6.patch780 bytes

The patch needed to be re-rolled (the file was moved), so I re-rolled it.

philipz’s picture

philipz commented
StatusFileSize
new Zrzut ekranu 2013-12-19 o 20.41.57.png14.54 KB

What do you think about doing it like Zurb Foundation does? 'Required' written in smaller font (same color).
This seems elegant and very clear. Takes more space but space next to labels is usually not a problem in drupal forms.

Required marker like Zurb Foundation

nancy.beutels’s picture

nancy.beutels commented

Tested patch 6 and looks good with the black asterisk. Tested on both on Firefox and Chrome.

alansaviolobo’s picture

alansaviolobo commented
Status: Needs review » Closed (fixed)

the contents of the patch are already present in the core.

yoroy’s picture

yoroy commented
Status: Closed (fixed) » Active
Issue tags: +Usability

Nope, asterisks are still red or have become red again. I still think a simple change to use the text color should be enough.

stborchert’s picture

stborchert
he/him
Primary language German
commented
Related issues: +#2274631: Form required marker "\204E" is broken in Google Chrome 35 / Internet Explorer 9

The asterisk is replaced by a SVG in #2274631: Form required marker "\204E" is broken in Google Chrome 35 / Internet Explorer 9 (commit c5fe718) so the SVG files need to be updated.

* /core/misc/icons/ee0000/required.svg
* /core/themes/bartik/images/required.svg
* /core/themes/seven/images/required.svg

yoroy’s picture

yoroy commented
Status: Active » Needs work

Lets do that!

stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new required-asterisk-color-1214008-12.patch2.43 KB

Changed the color used in /core/misc/icons/ee0000/required.svg and /core/themes/seven/images/required.svg. The SVG located in Bartik seems to be unused and uses #ffffff as color.

manauwarsheikh’s picture

manauwarsheikh commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Barcelona2015
StatusFileSize
new register.png51.89 KB

seems fine!

Current Status: All red asterisks are coming in black.attached screenshot

davidhernandez’s picture

davidhernandez
Primary language English
Location USA
commented
Issue tags: +Needs beta evaluation
valthebald’s picture

valthebald
Location Sofia
commented
Issue summary: View changes
Issue tags: -Needs beta evaluation

Added beta evaluation

yoroy’s picture

yoroy commented
Status: Reviewed & tested by the community » Needs review

But does that mean there are now black asterisks in the ee0000 folder? Because #ee0000 is hex for red…

stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Needs review » Needs work

Hm good point. How do we deal with this? Should I a) change the color within the file to #333333 and move the file to the folder "333333" or should I b) create a new folder named "3b3b3b" or c) just leave the old color code for this file?

a) and b) would require an additional change in form.css of Bartik since it uses the default icon instead the required.svg within bartik/images.
With c) we would go with the red icon for Bartik and change it for Seven only.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

yoroy’s picture

yoroy commented
Version: 8.3.x-dev » 8.4.x-dev
yoroy’s picture

yoroy commented
StatusFileSize
new required-asterisks.png73.12 KB

Another reason to just use the same color as the text color itself: on dark backgrounds this fails on accessibility.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

baluertl’s picture

baluertl
he/him
Primary language Hungarian
Location Budapest 🇪🇺
commented
Component: system.module » Claro theme
StatusFileSize
new 1214008-36-olivero_unaffected.png46.13 KB
new 1214008-36-claro_affected.png49.71 KB

Many things have changed since this issue's creation but the original problem still exists. Now tested on a D11-beta1 regarding the two most used themes Drupal core is shipped with out-of-the-box:

Public theme (Olivero) already did this job, and seems unaffected:
Screenshot

But the admin theme (Claro) still shows in red:
Screenshot

I would also raise a more generic problem here: the naming conventions of files in core/misc/icons/ sub-directory are a total mess: some of them describe their meaning (bad practice), and some are properly named after what they depicts (the proper way)

Gauravvvv made their first commit to this issue’s fork.

Gauravvvv opened merge request !8222

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
gauravvvv’s picture

gauravvvv commented
StatusFileSize
new Screenshot 2024-05-30 at 8.55.02 AM.png45.02 KB
new Screenshot 2024-05-30 at 8.55.58 AM.png46.25 KB

After patch

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs issue summary update

Issue summary should follow standard issue template. Currently has a broken image so screenshots need to be added.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.