I'd like to add an interface directly to the testbot which would allow testing of a specific branch or patch.

This would radically improve the debugging process, and would also allow individuals to easily deploy a testbot just for local use.

Comments

jthorson’s picture

Assigned: Unassigned » jthorson
FileSize
97.51 KB
53.58 KB

On it ... Plugin selection and Coder screenshots attached.

rfay’s picture

Neato!

jthorson’s picture

jthorson’s picture

Status: Active » Needs review
FileSize
35.89 KB
None View

Here's another update, with simpletest tests.

Includes all the same patches as the previous post. Given the form can handle core tests, the patch also removes the now-unused canned tests from the pifr_client.review.inc file as well.

jthorson’s picture

Rerolled patch against current 6.x-2.x (which already contains the patches listed above).

This version contains both coder and simpletest manual testing functionality (which is what I meant by simpletest tests above ... I haven't developed any actual tests).

rfay’s picture

Thanks! Are there any risks to existing functionality in this one?

jthorson’s picture

I don't believe this should break any existing (working) functionality, but there could be potential risks ... it's a pretty big patch, replaces the existing canned local tests, and does touch pifr_drupal.client.inc.

Essentially, the existing pifr_drupal.client.inc had what looked like a bunch of simpletest-specific code, which I wrapped in a if(plugin=simpletest) condition in order to support coder ... if the code is ever called without this plugin variable set, it would result in most of the pifr_drupal.client.inc code not being evaluated, thus breaking the simpletest test.

Without a full PIFT+PIFR test environment, I wasn't able to fully test to ensure things were still working end-to-end ... my gut feeling is that it's fine, but I could be overlooking some bit of PIFT+PIFR logic that I'm not aware of yet.

rfay’s picture

Chatting with Jeff_S in #drupal-infrastructure:

rfay: cool.  I'm actually out of the office this week, but have them sign up for accounts on http://supercell.osuosl.org (drupal site, for docs), and on http://ganeti-supercell.osuosl.org (for GWM interface), then email support with their usernames and ask to add them to the drupal group on supercell

So jthorson, boombatower, that's the ticket. Sign up those two places, and email support@osuosl.org pointing out the tickets. We'll get you in there somehow!

jthorson’s picture

Supercell access all set!

rfay’s picture

Yay - I'll get your key into the testbots then. If you could send me your preferred key (or if you want all 3 of your d.o keys that's OK too)

rfay’s picture

Status: Needs review » Reviewed & tested by the community

I didn't realize you'd already rerolled this. We should probably go ahead and get it in. I'd like to try it out, but since you've already worked with it extensively and think the risks are minimal, I'd say go ahead and commit.

jthorson’s picture

Not quite ready ... new version coming today.

jthorson’s picture

Status: Reviewed & tested by the community » Active
jthorson’s picture

This one fixes the file/patch simpletest tests (relative to the patch in #5).

jthorson’s picture

Committed to 6.x-2.x (1ceedf6) so that we may include in scratchtestbot testing.

jthorson’s picture

Status: Active » Fixed
rfay’s picture

Status: Fixed » Needs review
FileSize
996 bytes
None View

First issue - some missing defines. Did something get committed that wasn't the same as what was being tested? These defines were "off".

rfay’s picture

Status: Needs review » Needs work

Then, with that in place, I get this set of #fails when doing a local test with
7.x, role_change_notify, 7.x-1.x

    Notice: Undefined index: pass in pifr_client_db_interface_mysql->get_information() (line 21 of /home/rfay/workspace/testbot/sites/all/modules/project_issue_file_review/client/review/db/mysql.inc).
    User warning: Unknown column 'headers' in 'field list' query: SELECT data, created, headers, expire, serialized FROM cache WHERE cid = 'variables' in _db_query() (line 135 of /home/rfay/workspace/testbot/includes/database.mysql.inc).
    User warning: Unknown column 'headers' in 'field list' query: UPDATE cache SET data = 'a:32:{s:11:\"admin_theme\";s:5:\"seven\";s:9:\"clean_url\";s:1:\"0\";s:12:\"comment_page\";i:0;s:8:\"cron_key\";s:43:\"HHosomx3aD3fo0NxUwQFMaHS0LNjIthR6imBtjfBi_w\";s:9:\"cron_last\";i:1311544740;s:19:\"css_js_query_string\";s:6:\"louyec\";s:21:\"date_default_timezone\";s:14:\"America/Denver\";s:18:\"drupal_private_key\";s:43:\"-Q0uSe9ZEcaKWKuWsu4D1uxXKs-UO8Oq52kpnwpJnRo\";s:22:\"filter_fallback_format\";s:10:\"plain_text\";s:15:\"install_profile\";s:8:\"standard\";s:12:\"install_task\";s:4:\"done\";s:12:\"install_time\";i:1311544740;s:13:\"menu_expanded\";a:0:{}s:10:\"menu_masks\";a:26:{i:0;i:501;i:1;i:250;i:2;i:125;i:3;i:123;i:4;i:121;i:5;i:63;i:6;i:62;i:7;i:61;i:8;i:60;i:9;i:44;i:10;i:31;i:11;i:30;i:12;i:29;i:13;i:28;i:14;i:24;i:15;i:21;i:16;i:15;i:17;i:14;i:18;i:13;i:19;i:11;i:20;i:7;i:21;i:6;i:22;i:5;i:23;i:3;i:24;i:2;i:25;i:1;}s:19:\"menu_rebuild_needed\";b:1;s:16:\"node_admin_theme\";s:1:\"1\";s:17:\"node_options_page\";a:1:{i:0;s:6:\"status\";}s:19:\"node_submitted_page\";b:0;s:20:\"path_alias_whitelist\";a:0:{}s:21:\"pifr_client_operation\";s:6:\"review\";s:24:\"simpletest_clear_results\";s:1:\"0\";s:18:\"simpletest_verbose\";s:1:\"0\";s:20:\"site_default_country\";s:0:\"\";s:9:\"site_mail\";s:17:\"admin@example.com\";s:9:\"site_name\";s:8:\"checkout\";s:13:\"theme_default\";s:6:\"bartik\";s:15:\"user_admin_role\";s:1:\"3\";s:13:\"user_pictures\";s:1:\"1\";s:23:\"user_picture_dimensions\";s:9:\"1024x1024\";s:22:\"user_picture_file_size\";s:3:\"800\";s:18:\"user_picture_style\";s:9:\"thumbnail\";s:13:\"user_register\";i:2;}', created = 1311544744, expire = 0, headers = '', serialized = 1 WHERE cid = 'variables' in _db_query() (line 135 of /home/rfay/workspace/testbot/includes/database.mysql.inc).
    User warning: Unknown column 'headers' in 'field list' query: SELECT data, created, headers, expire, serialized FROM cache WHERE cid = 'variables' in _db_query() (line 135 of /home/rfay/workspace/testbot/includes/database.mysql.inc).
    User warning: Unknown column 'headers' in 'field list' query: UPDATE cache SET data = 'a:32:{s:11:\"admin_theme\";s:5:\"seven\";s:9:\"clean_url\";s:1:\"0\";s:12:\"comment_page\";i:0;s:8:\"cron_key\";s:43:\"HHosomx3aD3fo0NxUwQFMaHS0LNjIthR6imBtjfBi_w\";s:9:\"cron_last\";i:1311544740;s:19:\"css_js_query_string\";s:6:\"louyec\";s:21:\"date_default_timezone\";s:14:\"America/Denver\";s:18:\"drupal_private_key\";s:43:\"-Q0uSe9ZEcaKWKuWsu4D1uxXKs-UO8Oq52kpnwpJnRo\";s:19:\"file_directory_temp\";s:4:\"/tmp\";s:22:\"filter_fallback_format\";s:10:\"plain_text\";s:15:\"install_profile\";s:8:\"standard\";s:12:\"install_task\";s:4:\"done\";s:12:\"install_time\";i:1311544740;s:13:\"menu_expanded\";a:0:{}s:10:\"menu_masks\";a:34:{i:0;i:501;i:1;i:493;i:2;i:250;i:3;i:247;i:4;i:246;i:5;i:245;i:6;i:125;i:7;i:123;i:8;i:122;i:9;i:121;i:10;i:117;i:11;i:63;i:12;i:62;i:13;i:61;i:14;i:60;i:15;i:59;i:16;i:58;i:17;i:44;i:18;i:31;i:19;i:30;i:20;i:29;i:21;i:28;i:22;i:24;i:23;i:21;i:24;i:15;i:25;i:14;i:26;i:13;i:27;i:11;i:28;i:7;i:29;i:6;i:30;i:5;i:31;i:3;i:32;i:2;i:33;i:1;}s:16:\"node_admin_theme\";s:1:\"1\";s:17:\"node_options_page\";a:1:{i:0;s:6:\"status\";}s:19:\"node_submitted_page\";b:0;s:20:\"path_alias_whitelist\";a:0:{}s:21:\"pifr_client_operation\";s:6:\"review\";s:24:\"simpletest_clear_results\";s:1:\"0\";s:18:\"simpletest_verbose\";s:1:\"0\";s:20:\"site_default_country\";s:0:\"\";s:9:\"site_mail\";s:17:\"admin@example.com\";s:9:\"site_name\";s:8:\"checkout\";s:13:\"theme_default\";s:6:\"bartik\";s:15:\"user_admin_role\";s:1:\"3\";s:13:\"user_pictures\";s:1:\"1\";s:23:\"user_picture_dimensions\";s:9:\"1024x1024\";s:22:\"user_picture_file_size\";s:3:\"800\";s:18:\"user_picture_style\";s:9:\"thumbnail\";s:13:\"user_register\";i:2;}', created = 1311544745, expire = 0, headers = '', serialized = 1 WHERE cid = 'variables' in _db_query() (line 135 of /home/rfay/workspace/testbot/includes/database.mysql.inc).
    User warning: Unknown column 'headers' in 'field list' query: UPDATE cache_form SET data = 'a:20:{s:8:\"testtype\";a:6:{s:5:\"#type\";s:8:\"fieldset\";s:6:\"#title\";s:9:\"Test Type\";s:4:\"test\";a:5:{s:5:\"#type\";s:6:\"select\";s:6:\"#title\";s:18:\"Select test plugin\";s:8:\"#options\";a:2:{s:10:\"simpletest\";s:10:\"SimpleTest\";s:5:\"coder\";s:11:\"Code Review\";}s:14:\"#default_value\";s:15:\"pifr_simpletest\";s:12:\"#description\";s:65:\"Represents the review plugin which will be invoked for this test.\";}s:6:\"target\";a:5:{s:5:\"#type\";s:6:\"radios\";s:6:\"#title\";s:9:\"Test Type\";s:8:\"#options\";a:4:{s:4:\"core\";s:4:\"Core\";s:6:\"branch\";s:14:\"Project Branch\";s:4:\"file\";s:4:\"File\";s:5:\"patch\";s:5:\"Patch\";}s:12:\"#description\";s:111:\"Represents the object type which this test will target. (For Simpletest tests, File and Patch are equivalent.)\";s:14:\"#default_value\";s:6:\"branch\";}s:9:\"interrupt\";a:2:{s:5:\"#type\";s:8:\"checkbox\";s:6:\"#title\";s:40:\"Interrupt any existing tests in progress\";}s:10:\"selecttype\";a:2:{s:5:\"#type\";s:6:\"submit\";s:6:\"#value\";s:7:\"Next >>\";}}s:11:\"#parameters\";a:2:{i:0;s:23:\"pifr_client_review_form\";i:1;a:7:{s:7:\"storage\";a:1:{s:6:\"target\";s:6:\"branch\";}s:9:\"submitted\";b:1;s:6:\"values\";a:7:{s:7:\"version\";s:2:\"d7\";s:10:\"repository\";s:51:\"git://git.drupal.org/project/role_change_notify.git\";s:6:\"branch\";s:7:\"7.x-1.x\";s:2:\"op\";s:8:\"Run Test\";s:13:\"form_build_id\";s:37:\"form-7e286ffbe61f74fa1260d84d4cb62ba4\";s:10:\"form_token\";s:32:\"552da4898c594a986ab89539abd1b80f\";s:7:\"form_id\";s:23:\"pifr_client_review_form\";}s:14:\"clicked_button\";a:18:{s:5:\"#type\";s:6:\"submit\";s:6:\"#value\";s:8:\"Run Test\";s:5:\"#post\";a:7:{s:7:\"version\";s:2:\"d7\";s:10:\"repository\";s:51:\"git://git.drupal.org/project/role_change_notify.git\";s:6:\"branch\";s:7:\"7.x-1.x\";s:2:\"op\";s:8:\"Run Test\";s:13:\"form_build_id\";s:37:\"form-7e286ffbe61f74fa1260d84d4cb62ba4\";s:10:\"form_token\";s:32:\"552da4898c594a986ab89539abd1b80f\";s:7:\"form_id\";s:23:\"pifr_client_review_form\";}s:11:\"#programmed\";b:0;s:5:\"#tree\";b:0;s:8:\"#parents\";a:1:{i:0;s:2:\"op\";}s:14:\"#array_parents\";a:1:{i:0;s:2:\"op\";}s:7:\"#weight\";d:0.00200000000000000004163336342344337026588618755340576171875;s:10:\"#processed\";b:0;s:12:\"#description\";N;s:11:\"#attributes\";a:0:{}s:9:\"#required\";b:0;s:6:\"#input\";b:1;s:5:\"#name\";s:2:\"op\";s:12:\"#button_type\";s:6:\"submit\";s:25:\"#executes_submit_callback\";b:1;s:8:\"#process\";a:1:{i:0;s:16:\"form_expand_ahah\";}s:3:\"#id\";s:7:\"edit-op\";}s:13:\"process_input\";b:1;s:8:\"redirect\";N;s:7:\"rebuild\";b:1;}}s:9:\"#build_id\";s:37:\"form-59e4480503b169a11136d58a6e4b696f\";s:5:\"#type\";s:4:\"form\";s:11:\"#programmed\";b:0;s:13:\"form_build_id\";a:4:{s:5:\"#type\";s:6:\"hidden\";s:6:\"#value\";s:37:\"form-59e4480503b169a11136d58a6e4b696f\";s:3:\"#id\";s:37:\"form-59e4480503b169a11136d58a6e4b696f\";s:5:\"#name\";s:13:\"form_build_id\";}s:6:\"#token\";s:23:\"pifr_client_review_form\";s:10:\"form_token\";a:3:{s:3:\"#id\";s:39:\"edit-pifr-client-review-form-form-token\";s:5:\"#type\";s:5:\"token\";s:14:\"#default_value\";s:32:\"7c9254b737ddc367fe87b7014ebcf4fa\";}s:7:\"form_id\";a:3:{s:5:\"#type\";s:6:\"hidden\";s:6:\"#value\";s:23:\"pifr_client_review_form\";s:3:\"#id\";s:28:\"edit-pifr-client-review-form\";}s:3:\"#id\";s:23:\"pifr-client-review-form\";s:12:\"#description\";N;s:11:\"#attributes\";a:0:{}s:9:\"#required\";b:0;s:5:\"#tree\";b:0;s:8:\"#parents\";a:0:{}s:7:\"#method\";s:4:\"post\";s:7:\"#action\";s:20:\"/admin/pifr/run-test\";s:9:\"#validate\";a:1:{i:0;s:32:\"pifr_client_review_form_validate\";}s:7:\"#submit\";a:1:{i:0;s:30:\"pifr_client_review_form_submit\";}s:12:\"#cache_token\";s:32:\"74d7efd5d6539f6d58138d04e3ae3b9e\";}', created = 1311544745, expire = 1311566345, headers = '', serialized = 1 WHERE cid = 'form_form-59e4480503b169a11136d58a6e4b696f' in _db_query() (line 135 of /home/rfay/workspace/testbot/includes/database.mysql.inc).
    User warning: Unknown column 'headers' in 'field list' query: UPDATE cache_form SET data = 'a:1:{s:6:\"target\";s:6:\"branch\";}', created = 1311544745, expire = 1311566345, headers = '', serialized = 1 WHERE cid = 'storage_form-59e4480503b169a11136d58a6e4b696f' in _db_query() (line 135 of /home/rfay/workspace/testbot/includes/database.mysql.inc).
    User warning: Table 'checkout.blocks' doesn't exist query: SELECT DISTINCT b.* FROM blocks b LEFT JOIN blocks_roles r ON b.module = r.module AND b.delta = r.delta WHERE b.theme = 'garland' AND b.status = 1 AND (r.rid IN (2) OR r.rid IS NULL) ORDER BY b.region, b.weight, b.module in _db_query() (line 135 of /home/rfay/workspace/testbot/includes/database.mysql.inc).
    User warning: Unknown column 'headers' in 'field list' query: SELECT data, created, headers, expire, serialized FROM cache_menu WHERE cid = 'links:navigation:page-cid:admin/pifr/run-test:1' in _db_query() (line 135 of /home/rfay/workspace/testbot/includes/database.mysql.inc).
    User warning: Unknown column 'headers' in 'field list' query: SELECT data, created, headers, expire, serialized FROM cache_menu WHERE cid = 'links:navigation:tree-data:f7c6cebf1ec32068d5664252c6aff6c4' in _db_query() (line 135 of /home/rfay/workspace/testbot/includes/database.mysql.inc).
    User warning: Unknown column 'headers' in 'field list' query: UPDATE cache_menu SET data = 'a:2:{s:4:\"tree\";a:8:{i:3;a:2:{s:4:\"link\";a:37:{s:14:\"load_functions\";s:12:\"a:1:{i:1;N;}\";s:16:\"to_arg_functions\";s:0:\"\";s:15:\"access_callback\";s:11:\"user_access\";s:16:\"access_arguments\";s:33:\"a:1:{i:0;s:15:\"access comments\";}\";s:13:\"page_callback\";s:17:\"comment_permalink\";s:14:\"page_arguments\";s:14:\"a:1:{i:0;i:1;}\";s:5:\"title\";s:17:\"Comment permalink\";s:14:\"title_callback\";s:1:\"t\";s:15:\"title_arguments\";s:0:\"\";s:4:\"type\";s:1:\"6\";s:11:\"description\";s:0:\"\";s:9:\"menu_name\";s:10:\"navigation\";s:4:\"mlid\";s:1:\"3\";s:4:\"plid\";s:1:\"0\";s:9:\"link_path\";s:9:\"comment/%\";s:11:\"router_path\";s:9:\"comment/%\";s:10:\"link_title\";s:17:\"Comment permalink\";s:7:\"options\";s:6:\"a:0:{}\";s:6:\"module\";s:6:\"system\";s:6:\"hidden\";s:1:\"0\";s:8:\"external\";s:1:\"0\";s:12:\"has_children\";s:1:\"1\";s:8:\"expanded\";s:1:\"0\";s:6:\"weight\";s:1:\"0\";s:5:\"depth\";s:1:\"1\";s:10:\"customized\";s:1:\"0\";s:2:\"p1\";s:1:\"3\";s:2:\"p2\";s:1:\"0\";s:2:\"p3\";s:1:\"0\";s:2:\"p4\";s:1:\"0\";s:2:\"p5\";s:1:\"0\";s:2:\"p6\";s:1:\"0\";s:2:\"p7\";s:1:\"0\";s:2:\"p8\";s:1:\"0\";s:2:\"p9\";s:1:\"0\";s:7:\"updated\";s:1:\"0\";s:15:\"in_active_trail\";b:0;}s:5:\"below\";b:0;}i:4;a:2:{s:4:\"link\";a:37:{s:14:\"load_functions\";s:0:\"\";s:16:\"to_arg_functions\";s:0:\"\";s:15:\"access_callback\";s:1:\"1\";s:16:\"access_arguments\";s:6:\"a:0:{}\";s:13:\"page_callback\";s:16:\"filter_tips_long\";s:14:\"page_arguments\";s:6:\"a:0:{}\";s:5:\"title\";s:12:\"Compose tips\";s:14:\"title_callback\";s:1:\"t\";s:15:\"title_arguments\";s:0:\"\";s:4:\"type\";s:2:\"20\";s:11:\"description\";s:0:\"\";s:9:\"menu_name\";s:10:\"navigation\";s:4:\"mlid\";s:1:\"4\";s:4:\"plid\";s:1:\"0\";s:9:\"link_path\";s:11:\"filter/tips\";s:11:\"router_path\";s:11:\"filter/tips\";s:10:\"link_title\";s:12:\"Compose tips\";s:7:\"options\";s:6:\"a:0:{}\";s:6:\"module\";s:6:\"system\";s:6:\"hidden\";s:1:\"1\";s:8:\"external\";s:1:\"0\";s:12:\"has_children\";s:1:\"0\";s:8:\"expanded\";s:1:\"0\";s:6:\"weight\";s:1:\"0\";s:5:\"depth\";s:1:\"1\";s:10:\"customized\";s:1:\"0\";s:2:\"p1\";s:1:\"4\";s:2:\"p2\";s:1:\"0\";s:2:\"p3\";s:1:\"0\";s:2:\"p4\";s:1:\"0\";s:2:\"p5\";s:1:\"0\";s:2:\"p6\";s:1:\"0\";s:2:\"p7\";s:1:\"0\";s:2:\"p8\";s:1:\"0\";s:2:\"p9\";s:1:\"0\";s:7:\"updated\";s:1:\"0\";s:15:\"in_active_trail\";b:0;}s:5:\"below\";b:0;}i:5;a:2:{s:4:\"link\";a:37:{s:14:\"load_functions\";s:26:\"a:1:{i:1;s:9:\"node_load\";}\";s:16:\"to_arg_functions\";s:0:\"\";s:15:\"access_callback\";s:11:\"node_access\";s:16:\"access_arguments\";s:29:\"a:2:{i:0;s:4:\"view\";i:1;i:1;}\";s:13:\"page_callback\";s:14:\"node_page_view\";s:14:\"page_arguments\";s:14:\"a:1:{i:0;i:1;}\";s:5:\"title\";s:0:\"\";s:14:\"title_callback\";s:15:\"node_page_title\";s:15:\"title_arguments\";s:14:\"a:1:{i:0;i:1;}\";s:4:\"type\";s:1:\"6\";s:11:\"description\";s:0:\"\";s:9:\"menu_name\";s:10:\"navigation\";s:4:\"mlid\";s:1:\"5\";s:4:\"plid\";s:1:\"0\";s:9:\"link_path\";s:6:\"node/%\";s:11:\"router_path\";s:6:\"node/%\";s:10:\"link_title\";s:0:\"\";s:7:\"options\";s:6:\"a:0:{}\";s:6:\"module\";s:6:\"system\";s:6:\"hidden\";s:1:\"0\";s:8:\"external\";s:1:\"0\";s:12:\"has_children\";s:1:\"0\";s:8:\"expanded\";s:1:\"0\";s:6:\"weight\";s:1:\"0\";s:5:\"depth\";s:1:\"1\";s:10:\"customized\";s:1:\"0\";s:2:\"p1\";s:1:\"5\";s:2:\"p2\";s:1:\"0\";s:2:\"p3\";s:1:\"0\";s:2:\"p4\";s:1:\"0\";s:2:\"p5\";s:1:\"0\";s:2:\"p6\";s:1:\"0\";s:2:\"p7\";s:1:\"0\";s:2:\"p8\";s:1:\"0\";s:2:\"p9\";s:1:\"0\";s:7:\"updated\";s:1:\"0\";s:15:\"in_active_trail\";b:0;}s:5:\"below\";b:0;}i:6;a:2:{s:4:\"link\";a:37:{s:14:\"load_functions\";s:0:\"\";s:16:\"to_arg_functions\";s:0:\"\";s:15:\"access_callback\";s:16:\"_node_add_access\";s:16:\"access_arguments\";s:6:\"a:0:{}\";s:13:\"page_callback\";s:13:\"node_add_page\";s:14:\"page_arguments\";s:6:\"a:0:{}\";s:5:\"title\";s:11:\"Add content\";s:14:\"title_callback\";s:1:\"t\";s:15:\"title_arguments\";s:0:\"\";s:4:\"type\";s:1:\"6\";s:11:\"description\";s:0:\"\";s:9:\"menu_name\";s:10:\"navigation\";s:4:\"mlid\";s:1:\"6\";s:4:\"plid\";s:1:\"0\";s:9:\"link_path\";s:8:\"node/add\";s:11:\"router_path\";s:8:\"node/add\";s:10:\"link_title\";s:11:\"Add content\";s:7:\"options\";s:6:\"a:0:{}\";s:6:\"module\";s:6:\"system\";s:6:\"hidden\";s:1:\"0\";s:8:\"external\";s:1:\"0\";s:12:\"has_children\";s:1:\"1\";s:8:\"expanded\";s:1:\"0\";s:6:\"weight\";s:1:\"0\";s:5:\"depth\";s:1:\"1\";s:10:\"customized\";s:1:\"0\";s:2:\"p1\";s:1:\"6\";s:2:\"p2\";s:1:\"0\";s:2:\"p3\";s:1:\"0\";s:2:\"p4\";s:1:\"0\";s:2:\"p5\";s:1:\"0\";s:2:\"p6\";s:1:\"0\";s:2:\"p7\";s:1:\"0\";s:2:\"p8\";s:1:\"0\";s:2:\"p9\";s:1:\"0\";s:7:\"updated\";s:1:\"0\";s:15:\"in_active_trail\";b:0;}s:5:\"below\";b:0;}i:17;a:2:{s:4:\"link\";a:37:{s:14:\"load_functions\";s:26:\"a:1:{i:1;s:9:\"user_load\";}\";s:16:\"to_arg_functions\";s:0:\"\";s:15:\"access_callback\";s:16:\"user_view_access\";s:16:\"access_arguments\";s:14:\"a:1:{i:0;i:1;}\";s:13:\"page_callback\";s:14:\"user_view_page\";s:14:\"page_arguments\";s:14:\"a:1:{i:0;i:1;}\";s:5:\"title\";s:10:\"My account\";s:14:\"title_callback\";s:15:\"user_page_title\";s:15:\"title_arguments\";s:14:\"a:1:{i:0;i:1;}\";s:4:\"type\";s:1:\"6\";s:11:\"description\";s:0:\"\";s:9:\"menu_name\";s:10:\"navigation\";s:4:\"mlid\";s:2:\"17\";s:4:\"plid\";s:1:\"0\";s:9:\"link_path\";s:6:\"user/%\";s:11:\"router_path\";s:6:\"user/%\";s:10:\"link_title\";s:10:\"My account\";s:7:\"options\";s:6:\"a:0:{}\";s:6:\"module\";s:6:\"system\";s:6:\"hidden\";s:1:\"0\";s:8:\"external\";s:1:\"0\";s:12:\"has_children\";s:1:\"1\";s:8:\"expanded\";s:1:\"0\";s:6:\"weight\";s:1:\"0\";s:5:\"depth\";s:1:\"1\";s:10:\"customized\";s:1:\"0\";s:2:\"p1\";s:2:\"17\";s:2:\"p2\";s:1:\"0\";s:2:\"p3\";s:1:\"0\";s:2:\"p4\";s:1:\"0\";s:2:\"p5\";s:1:\"0\";s:2:\"p6\";s:1:\"0\";s:2:\"p7\";s:1:\"0\";s:2:\"p8\";s:1:\"0\";s:2:\"p9\";s:1:\"0\";s:7:\"updated\";s:1:\"0\";s:15:\"in_active_trail\";b:0;}s:5:\"below\";b:0;}i:23;a:2:{s:4:\"link\";a:37:{s:14:\"load_functions\";s:26:\"a:1:{i:2;s:9:\"node_load\";}\";s:16:\"to_arg_functions\";s:0:\"\";s:15:\"access_callback\";s:11:\"node_access\";s:16:\"access_arguments\";s:29:\"a:2:{i:0;s:4:\"view\";i:1;i:2;}\";s:13:\"page_callback\";s:13:\"comment_reply\";s:14:\"page_arguments\";s:14:\"a:1:{i:0;i:2;}\";s:5:\"title\";s:15:\"Add new comment\";s:14:\"title_callback\";s:1:\"t\";s:15:\"title_arguments\";s:0:\"\";s:4:\"type\";s:1:\"6\";s:11:\"description\";s:0:\"\";s:9:\"menu_name\";s:10:\"navigation\";s:4:\"mlid\";s:2:\"23\";s:4:\"plid\";s:1:\"0\";s:9:\"link_path\";s:15:\"comment/reply/%\";s:11:\"router_path\";s:15:\"comment/reply/%\";s:10:\"link_title\";s:15:\"Add new comment\";s:7:\"options\";s:6:\"a:0:{}\";s:6:\"module\";s:6:\"system\";s:6:\"hidden\";s:1:\"0\";s:8:\"external\";s:1:\"0\";s:12:\"has_children\";s:1:\"0\";s:8:\"expanded\";s:1:\"0\";s:6:\"weight\";s:1:\"0\";s:5:\"depth\";s:1:\"1\";s:10:\"customized\";s:1:\"0\";s:2:\"p1\";s:2:\"23\";s:2:\"p2\";s:1:\"0\";s:2:\"p3\";s:1:\"0\";s:2:\"p4\";s:1:\"0\";s:2:\"p5\";s:1:\"0\";s:2:\"p6\";s:1:\"0\";s:2:\"p7\";s:1:\"0\";s:2:\"p8\";s:1:\"0\";s:2:\"p9\";s:1:\"0\";s:7:\"updated\";s:1:\"0\";s:15:\"in_active_trail\";b:0;}s:5:\"below\";b:0;}i:27;a:2:{s:4:\"link\";a:37:{s:14:\"load_functions\";s:36:\"a:1:{i:2;s:18:\"taxonomy_term_load\";}\";s:16:\"to_arg_functions\";s:0:\"\";s:15:\"access_callback\";s:11:\"user_access\";s:16:\"access_arguments\";s:32:\"a:1:{i:0;s:14:\"access content\";}\";s:13:\"page_callback\";s:18:\"taxonomy_term_page\";s:14:\"page_arguments\";s:14:\"a:1:{i:0;i:2;}\";s:5:\"title\";s:13:\"Taxonomy term\";s:14:\"title_callback\";s:19:\"taxonomy_term_title\";s:15:\"title_arguments\";s:14:\"a:1:{i:0;i:2;}\";s:4:\"type\";s:1:\"6\";s:11:\"description\";s:0:\"\";s:9:\"menu_name\";s:10:\"navigation\";s:4:\"mlid\";s:2:\"27\";s:4:\"plid\";s:1:\"0\";s:9:\"link_path\";s:15:\"taxonomy/term/%\";s:11:\"router_path\";s:15:\"taxonomy/term/%\";s:10:\"link_title\";s:13:\"Taxonomy term\";s:7:\"options\";s:6:\"a:0:{}\";s:6:\"module\";s:6:\"system\";s:6:\"hidden\";s:1:\"0\";s:8:\"external\";s:1:\"0\";s:12:\"has_children\";s:1:\"0\";s:8:\"expanded\";s:1:\"0\";s:6:\"weight\";s:1:\"0\";s:5:\"depth\";s:1:\"1\";s:10:\"customized\";s:1:\"0\";s:2:\"p1\";s:2:\"27\";s:2:\"p2\";s:1:\"0\";s:2:\"p3\";s:1:\"0\";s:2:\"p4\";s:1:\"0\";s:2:\"p5\";s:1:\"0\";s:2:\"p6\";s:1:\"0\";s:2:\"p7\";s:1:\"0\";s:2:\"p8\";s:1:\"0\";s:2:\"p9\";s:1:\"0\";s:7:\"updated\";s:1:\"0\";s:15:\"in_active_trail\";b:0;}s:5:\"below\";b:0;}i:196;a:2:{s:4:\"link\";a:37:{s:14:\"load_functions\";s:0:\"\";s:16:\"to_arg_functions\";s:0:\"\";s:15:\"access_callback\";s:16:\"search_is_active\";s:16:\"access_arguments\";s:6:\"a:0:{}\";s:13:\"page_callback\";s:11:\"search_view\";s:14:\"page_arguments\";s:6:\"a:0:{}\";s:5:\"title\";s:6:\"Search\";s:14:\"title_callback\";s:1:\"t\";s:15:\"title_arguments\";s:0:\"\";s:4:\"type\";s:2:\"20\";s:11:\"description\";s:0:\"\";s:9:\"menu_name\";s:10:\"navigation\";s:4:\"mlid\";s:3:\"196\";s:4:\"plid\";s:1:\"0\";s:9:\"link_path\";s:6:\"search\";s:11:\"router_path\";s:6:\"search\";s:10:\"link_title\";s:6:\"Search\";s:7:\"options\";s:6:\"a:0:{}\";s:6:\"module\";s:6:\"system\";s:6:\"hidden\";s:1:\"1\";s:8:\"external\";s:1:\"0\";s:12:\"has_children\";s:1:\"0\";s:8:\"expanded\";s:1:\"0\";s:6:\"weight\";s:1:\"0\";s:5:\"depth\";s:1:\"1\";s:10:\"customized\";s:1:\"0\";s:2:\"p1\";s:3:\"196\";s:2:\"p2\";s:1:\"0\";s:2:\"p3\";s:1:\"0\";s:2:\"p4\";s:1:\"0\";s:2:\"p5\";s:1:\"0\";s:2:\"p6\";s:1:\"0\";s:2:\"p7\";s:1:\"0\";s:2:\"p8\";s:1:\"0\";s:2:\"p9\";s:1:\"0\";s:7:\"updated\";s:1:\"0\";s:15:\"in_active_trail\";b:0;}s:5:\"below\";b:0;}}s:10:\"node_links\";a:0:{}}', created = 1311544745, expire = 0, headers = '', serialized = 1 WHERE cid = 'links:navigation:tree-data:f7c6cebf1ec32068d5664252c6aff6c4' in _db_query() (line 135 of /home/rfay/workspace/testbot/includes/database.mysql.inc).
    User warning: Unknown column 'headers' in 'field list' query: UPDATE cache_menu SET data = 'links:navigation:tree-data:f7c6cebf1ec32068d5664252c6aff6c4', created = 1311544745, expire = 0, headers = '', serialized = 0 WHERE cid = 'links:navigation:page-cid:admin/pifr/run-test:1' in _db_query() (line 135 of /home/rfay/workspace/testbot/includes/database.mysql.inc).
    Warning: call_user_func_array() expects parameter 1 to be a valid callback, function 'search_is_active' not found or invalid function name in _menu_check_access() (line 451 of /home/rfay/workspace/testbot/includes/menu.inc).
jthorson’s picture

Doh ... last change I made was the name of those defines ... tested patch on testbot, copied to local machine, applied *previous* broken patch, and committed. :( Then went to test on scratchtestbot, realized I didn't have write/pull permissions, and got distracted with that.

As for the mysql issues ... the manual tests changes didn't touch anything that would cause these. Could possibly be related to #1207076: Improve pifr_client_db_interface 'query' handling (though I don't see how); but haven't seen anything like this in a week of running the manual tests. I'll re-run your tests on my local, and see if I can reproduce.

rfay’s picture

@jthorson, if you want to be able to commit from a remote environment, use ssh -a to get into it.

Thanks for all your work on this.

jthorson’s picture

Committed issue in #17 (9f3328e), with a slight tweak (changed the definition instead of the reference). Believe 6.x-2.x should be functional again.

jthorson’s picture

Status: Needs work » Needs review
rfay’s picture

Status: Needs review » Fixed

I don't see this any more.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.