Missing '$' on a variable reference ... results in
Notice: Use of undefined constant check_only - assumed 'check_only' in pifr_client_vcs_git->apply() (line 122 of /var/lib/drupaltestbot/sites/all/modules/project_issue_file_review/client/review/vcs/git.inc)
when running tests locally on a testbot.

CommentFileSizeAuthor
#4 pifr.fix_check_only_1206984_04.patch602 bytesrfay
#3 pifr-Fix_git.inc_check_only_reference_v2-1206984-3.patch525 bytesjthorson
#1 pifr-Fix_git.inc_check_only_reference-1206984-1.patch526 bytesjthorson

Comments

jthorson’s picture

jthorson commented
StatusFileSize
new pifr-Fix_git.inc_check_only_reference-1206984-1.patch526 bytes

And the patch ...

jthorson’s picture

jthorson commented
Status: Active » Needs review
jthorson’s picture

jthorson commented
StatusFileSize
new pifr-Fix_git.inc_check_only_reference_v2-1206984-3.patch525 bytes

And a new patch, now that I've actually looked at the logic. (Too quick to assume that if there was a ! there, it was supposed to be there ... it was a typo on the $, not a missing one!)

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
StatusFileSize
new pifr.fix_check_only_1206984_04.patch602 bytes

Thanks for this. Amazing that php can be that forgiving.

While we're here, seems like the logic on the inner line can be improved.

jthorson’s picture

jthorson commented
Status: Needs review » Reviewed & tested by the community

Can't actually test while I'm away from home ... but your update is so trivial that I'm going to go out on a limb and say it's RTBC. (Is that allowed? You approve my tweak, and I approve yours?)

Aw heck ... Even if I'm wrong, it can't actually be any worse than it is right now, can it? :)

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Reviewed & tested by the community » Fixed

Committed: 21c8d7a

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.