When running the 'quick' test locally on my testbot, the resulting run-tests.sh command still contained the --all argument ... and thus, a full suite of tests was performed instead of a quick test.

CommentFileSizeAuthor
#8 review.test_135319.fail_.patch.1310498127.log_.txt50.62 KBrfay
#8 review.test_135319.pass_.patch.1310500322.log_.txt50.14 KBrfay
#1 pifr-fix_local_quick_test_runs_full_suite-1214818-1.patch546 bytesjthorson

Comments

jthorson’s picture

jthorson commented
Status: Active » Needs review
StatusFileSize
new pifr-fix_local_quick_test_runs_full_suite-1214818-1.patch546 bytes

Looks like the following patch should address it ... changes the argument name from ['tests'] to ['simpletest.tests'] in pifr_client_review_pre_built_test($type).

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

Oh I dearly hope this is a duplicate of #1120228: In reconfirmation, testbots do a full test for the "fail" test, and sometimes do a "fail" response as a result. I'm betting it is! Yay!

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

And welcome back!

jthorson’s picture

jthorson commented

Thanks ... once I have all the php warnings dealt with, local tests working properly, and manual local testing built ... I'll turn some attention to the communication between pifr_server and pifr_client.

Have you got a log for a failed reconfirmation test as per #1120228? If so, it should be pretty easy to see if this is the same issue (i.e. if $test['simpletest.tests'] is empty).

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

OK. Unfortunately when one fails I generally retest it right away to keep it in service :-) But I'll take a look. Thanks so much!

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

Here's a test right now that demonstrates #1120228: In reconfirmation, testbots do a full test for the "fail" test, and sometimes do a "fail" response as a result: http://qa.drupal.org/pifr/test/135319

jthorson’s picture

jthorson commented

Hmmm ... you've got debug turned off ... can't see the $test array. :(

Can you retrieve the test review.log file? It should have the $test array structure; which should confirm/deny pretty quick whether this is the same issue. (I'd look locally, but I'm not at home right now.)

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
StatusFileSize
new review.test_135319.pass_.patch.1310500322.log_.txt50.14 KB
new review.test_135319.fail_.patch.1310498127.log_.txt50.62 KB

Here are the logs from the fail and the pass patch.

Are you making any progress getting access to supercell?

jthorson’s picture

jthorson commented

Hmmm ... I guess the $test array only gets written to the review log if debug is turned on? I'm sure that my testbot is including the $test input in the log for every local test execution regardless of the debug setting - but this is probably hard-coded into the function which executes the canned tests (and not in the one which handles the xml-rpc).

Haven't chased supercell yet after getting back ... spent hours banging my head against run-tests.sh instead. :)

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

jthorson++

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs review » Fixed

OK - Committed #1: 02f7a4b

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.