Problem/Motivation
PHP trips an E_STRICT warning ("Only variables should be passed by reference") when running reviews. This is caused by the insertion of a function call into array_splice on line 155 of client.inc:
$this->operations = array_splice($plugin->operation_get_all(), 0, -2);
Proposed resolution
Attached patch gets rid of the warning by moving the operation_get_all() command out of the array_splice function:
$operations = $plugin->operation_get_all();
$this->operations = array_splice($operations, 0, -2);
Remaining tasks
Trivial change ... needs review and commit
Comments
Comment #1
jthorson commentedOh crap ... $operations is a protected variable ... renaming to avoid confusion.
Comment #2
jthorson commentedComment #3
rfayCommitted: a3901c2
Thanks!