This discussion is spread across many separated issues (as it should) but I wanted to have a parent issue to discuss handling this problem once and for all.
We should really had RTL support in D7 long time ago, we had it in D6, and we don't have it anymore, this is a major regression, especially considering the fact that RTL support was one of the requirements for new core theme.
All these 7.0 and 8.0 rtl patches need to be committed once and for all, even if only 99% perfect, they are all interdependent and every time one of them gets outdated because another css patch got committed, all or many of them go back to needs work.
RTL support in D7 is becoming a real PITA to achieve.
Someone in the Israeli community already suggested maintaining a distro with rtl patches already applied, this seems weird but we are really this close to having RTL supported and yet, the current fresh install of D7 look really bad for RTL users.
this was started as a comment on #1040262: locale-rtl.css
Comments
Comment #1
aspilicious CreditAttribution: aspilicious commentedSub, trying to help you guys even if I don't need it :)
Comment #2
tsi CreditAttribution: tsi commented@aspilicious - thanks, you sure do, actually I was sure you were "one of us" :)
Comment #3
mightyiam CreditAttribution: mightyiam commentedsubscribe
Comment #4
aspilicious CreditAttribution: aspilicious commentedI started working on the last remaining css rtl issues. I think we have to do better in the future. And make sure NO css gets committed if there is no rtl patch available! :)
Comment #5
catchIs there any way to automate testing for missing RTL css?
Comment #6
catchComment #7
aspilicious CreditAttribution: aspilicious commentedcatch no but there are test sites set up :)
Comment #8
catch#766458: Seven theme lacks rtl styling is still open, I'm not sure we need this meta issue since we have both the tag and individual bug reports in patches, so I'm marking this duplicate. If parts of core are completely missing RTL storing compared to D6 (either old features where it was lost, or completely new stuff where it was never included), those should probably be major bugs by themselves given it's a regression in both cases.
Comment #9
tsi CreditAttribution: tsi commentedThe idea behind creating this issue was to discuss how can we make sure the D7 rtl situation will not repeat itself.
just to make myself clear, when I'm saying "D7 rtl situation" I'm talking about the situation where out of the main 3 UX improvements in drupal 7 (Bartik, Seven & overlay) we have RTL support for *only* one - Bartik and that is mainly because of the "new core theme contest" that took place in the pre-release period that required each of the candidates to be in top shape before it was committed.
Now we are more then six months after D7 official release, 4 versions releases after, and still, nothing, truly nothing, out of all the work we were doing in #766458: Seven theme lacks rtl styling and in #766170: Overlay lacks rtl styling *nothing* was committed - that means we are still having the same display bugs we had during Beta even though the patches to fix them were available already then, really - these issues have working patches since april 2010 !
So why weren't they committed ? first and furthermost because of IE7 support, which was always ok but never perfect, still, those patches are a huge improvement for FF, chrome, IE 8-9, Safari, Opera, Konqueror (etc.) users, and frankly, if we are talking about admin tools (seven & overlay) - who the hell is using IE7 to administer drupal today ??
People are still (!) afraid of going into D7, and these kind of bugs with no visible improvement are exactly why.
I'm reopening this not because there is work to do here but to see if anyone has comments or ideas on the matter.
Comment #10
Bojhan CreditAttribution: Bojhan commentedWe cannot have an [meta] issue with no actual tasks be major.
Comment #11
Jeff Burnz CreditAttribution: Jeff Burnz commentedI think if you want to drop support for IE7 in RTL then you will get my vote of support. If you can get consensus on it I'm all for it.
Comment #12
star-szrHope I'm not hijacking this issue too much.
Can we make RTL support a core gate or have some other way of ensuring RTL support when reviewing and testing patches containing new or changed CSS?
RTL styles seems to be slipping through the cracks a bit too often. I've never used RTL in Drupal personally, but recently I've worked on a couple issues for updating RTL stylesheets:
#1799124: locale-rtl.css is out of sync with locale.admin.css, is never included due to incorrect filename
#1324058: forum-rtl.css does not overide #forum div.indent from margin-left to margin-right
RTL is mentioned in both the new CSS formatting guidelines and the older CSS standards draft which is great, but I don't think that's enough.
Comment #13
echoz CreditAttribution: echoz commentedRelated, another RTL wtf bug #1997630: RTL stylesheets not recognized for vertical tabs
Comment #14
LewisNyman CreditAttribution: LewisNyman commentedThis might be relevant to your interests #2313783: Contribute a csslint rule to detect LTR properties
Comment #15
LewisNyman CreditAttribution: LewisNyman commentedSee: #2387765: Automate CSS RTL generation
Comment #24
catch