When admin approval is required for new users, each new user registration sends an email to the site owner. There is no way to turn this off, even if you track these users by some other means. This simple patch adds a new variable named in the tradition of other notify flip-switches to support this. The patch is very simple and I'm not 100% sure we need a UI for this, the default is sensible, but it might as well make sense to add a UI as well.

CommentFileSizeAuthor
#17 make_it_possible_to-1116704-17.patch1.32 KBalansaviolobo
#13 interdiff-1116704-9-13.txt1.53 KBinternetdevels
#13 drupal_user_mail-1116704-13.patch1.2 KBinternetdevels
#9 user_mail-1116704-9.patch1.05 KBtarekdj
#7 user_mail-1116704-7.patch816 bytestarekdj
user_mail_register_pending_approval_admin_notify.diff845 bytesgábor hojtsy

Comments

Status: Needs review » Needs work

The last submitted patch, user_mail_register_pending_approval_admin_notify.diff, failed testing.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Needs review

user_mail_register_pending_approval_admin_notify.diff queued for re-testing.

valthebald’s picture

valthebald
Location Sofia
commented

user_mail_register_pending_approval_admin_notify.diff queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, user_mail_register_pending_approval_admin_notify.diff, failed testing.

pwolanin’s picture

pwolanin commented
Issue summary: View changes
Issue tags: +Needs reroll
sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

Mentioned patch simply does this,

-    if ($op == 'register_pending_approval') {
+    if ($op == 'register_pending_approval' && variable_get('user_mail_register_pending_approval_admin_notify', TRUE)) {

I'm not sure if this would be potentially useful without UI. Besides this is a feature request, is this okay for 8.x at this time?

tarekdj’s picture

tarekdj commented
Status: Needs work » Needs review
StatusFileSize
new user_mail-1116704-7.patch816 bytes

Done!

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Status: Needs review » Needs work

Call to variable_get() to be replaced with config().

tarekdj’s picture

tarekdj commented
Status: Needs work » Needs review
StatusFileSize
new user_mail-1116704-9.patch1.05 KB

Here is the new patch using config.

Status: Needs review » Needs work

The last submitted patch, 9: user_mail-1116704-9.patch, failed testing.

tarekdj’s picture

tarekdj commented
Status: Needs work » Needs review

9: user_mail-1116704-9.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 9: user_mail-1116704-9.patch, failed testing.

internetdevels’s picture

internetdevels commented
StatusFileSize
new drupal_user_mail-1116704-13.patch1.2 KB
new interdiff-1116704-9-13.txt1.53 KB
internetdevels’s picture

internetdevels commented
Status: Needs work » Needs review
tarekdj’s picture

tarekdj commented

Thanks InternetDevels. Looks RTBC for me.

sweetchuck’s picture

sweetchuck
Primary language Hungarian
Location Budapest
commented
Issue tags: -Needs reroll

The patch #13 is applicable to the latest 8.x branch.

alansaviolobo’s picture

alansaviolobo commented
StatusFileSize
new make_it_possible_to-1116704-17.patch1.32 KB

reroll

Status: Needs review » Needs work

The last submitted patch, 17: make_it_possible_to-1116704-17.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs work » Postponed (maintainer needs more info)
Issue tags: +stale-issue-cleanup

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

smustgrave’s picture

smustgrave commented

wanted to bump 1 more time.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.