I have Admin module (7.x-2.0-beta3) installed and it has been functioning normally. Today I wanted to update JQuery from 1.4 to 1.5 and installed the JQuery Update module to do so. After the install the Administration menu in Admin no longer works. Disabling the Jquery Update module returned the menu listings.

I will be providing a screenshot of what is happening as well as posting an errors that show up the debugger.

CommentFileSizeAuthor
#15 jquery.drilldown.js_.diff1.3 KBpraestigiare
#7 jquery.drilldown.js_.diff1.44 KBdat.pham
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mfer’s picture

mfer CreditAttribution: mfer commented
Project: jQuery Update » Admin
Version: 7.x-2.1 » 7.x-2.0-beta3
Component: User interface » Code

@fregan The issue is in the admin module. The JavaScript syntax it is using is not compatible with jQuery 1.5.1.

Admin module maintainers, can you please update your jQuery syntax to work with both jQuery 1.4 and 1.5?

The error I get in firebug is:

uncaught exception: Syntax error, unrecognized expression: [href=/admin/modules]

The path in the href is always the current path.

fregan’s picture

fregan CreditAttribution: fregan commented

Thanks mfer. I posted over there also, just wanted to post here as well.

OnkelTem’s picture

OnkelTem CreditAttribution: OnkelTem commented

Subscribing

drupalicious’s picture

drupalicious CreditAttribution: drupalicious commented

subscribing

lightstring’s picture

lightstring CreditAttribution: lightstring commented

Subscribing

dat.pham’s picture

dat.pham CreditAttribution: dat.pham commented

Hi

You can manual fix with flowing step by step:

1) Open file: /includes/jquery.drilldown.js
2) Change line 125
Form

if (settings.activePath && $('ul.menu a[href='+settings.activePath+']', menu).size() > 0) {

TO

if (settings.activePath && $('ul.menu a[href="'+settings.activePath+'"]', menu).size() > 0) {

=> Add " before & after settings.activePath

3) Repeat step 2 with line 127, 148.

Dat
Regards

dat.pham’s picture

dat.pham CreditAttribution: dat.pham commented
FileSize
jquery.drilldown.js_.diff1.44 KB

Here is patch.

mfer’s picture

mfer CreditAttribution: mfer commented

This is definitely a bug. The quotes are mandatory according to the jQuery documentation. Previously, I don't think this was enforced.

mail@victorquinn.com’s picture

mail@victorquinn.com CreditAttribution: mail@victorquinn.com commented

Subscribing

pifantastic’s picture

pifantastic CreditAttribution: pifantastic commented

I want to confirm that @dat.pham's patch works for me in 6.x-2.0

And @mfer is right, attribute selectors must be either a CSS identifier (http://www.w3.org/TR/CSS21/syndata.html#value-def-identifier) or a CSS string. In our case we're matching on a URL that is not a valid CSS identifier, so we need the quotes.

skwashd’s picture

skwashd CreditAttribution: skwashd commented
Assigned: Unassigned » skwashd
Status: Active » Fixed

Thanks for the patch.

Committed to both the 7.x-2.x and 6.x-2.x branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

just_one_fix’s picture

just_one_fix CreditAttribution: just_one_fix commented

i dont have this file /includes/jquery.drilldown.js. - drupal 7.2

atlea’s picture

atlea CreditAttribution: atlea commented

I see there is a lot of commits going into 7.x-2 since beta3. Perhaps you could add a dev tag to 7.x-2.x? :)

praestigiare’s picture

praestigiare CreditAttribution: praestigiare commented
FileSize
jquery.drilldown.js_.diff1.3 KB

Just re-rolled the patch to make it compatible with drush make.

aidanlis’s picture

aidanlis CreditAttribution: aidanlis commented
Version: 7.x-2.0-beta3 » 6.x-2.x-dev
Status: Closed (fixed) » Patch (to be ported)

Can we get this in 6.x-2.x as well?

aidanlis’s picture

aidanlis CreditAttribution: aidanlis commented
Version: 6.x-2.x-dev » 7.x-2.0-beta3
Status: Patch (to be ported) » Closed (fixed)

Ah, patch has already been applied in 6.x-2.x branch.

mrP’s picture

mrP CreditAttribution: mrP commented
Version: 7.x-2.0-beta3 » 7.x-2.x-dev

Fixed in 7.x-2.x-dev, not in 7.x-2.0-beta3. See #1378082: Fails to list menus for administration but shows when disabling jQuery Update 7.x-2.2

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

Just posting a possibly related issue - #1360288: Panels 7.x-3.x-dev not compatible with jQuery Update 7.x-2.2 (jQuery 1.5.2 and jQuery UI 1.8.11)

I had the issue with the Admin Menu and other basic parts of Drupal's interface. Autocomplete, Module Filter, accordions were also giving me trouble with 7.x-2.2 enabled.

Only error I could see was:

TypeError: 'undefined' is not an object (evaluating 'settings.facetapi.facets')

myselfhimself’s picture

myselfhimself CreditAttribution: myselfhimself commented
Version: 7.x-2.x-dev » 7.x-2.0-beta3
Status: Closed (fixed) » Needs work

Hello,
it seems that current 7.x-2.0-beta3 tar.gz release does not have that href="'+settings.activePath+'" quotes fixed. 7.x-2.x-dev has it. Is it not possible to port the double quotes patch to 7.x-2.0-beta3 ?
Thanks in advance !

skwashd’s picture

skwashd CreditAttribution: skwashd commented
Version: 7.x-2.0-beta3 » 7.x-2.x-dev
Status: Needs work » Fixed

This fix will be included in the next 7.x-2.x release of admin.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

shaneforsythe’s picture

shaneforsythe CreditAttribution: shaneforsythe commented

Is there any update to this?

The last release of the -dev version was almost 1 year ago. The proposed solution/patch have been available since Nov, 2011 ... is there some blocking issue that is preventing this one patch to being applied and a new -dev version being released?

shark’s picture

shark CreditAttribution: shark commented

Just reporting that the patch (#7/#15) works on Drupal 6.

Note that as of September 2012, there has not been a new stable release of Admin 6.x-2.x so other users with this problem will need to use the dev version or apply the patch to their stable module (which presumably is fine as the next stable release should include the corrected code).