a la #866340: Remove support for date and time types, the lastimported column of type datetime is unsupported, which breaks migrate install with the following:
PDOException: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'DEFAULT NULL COMMENT 'Date and time of last completed import', `highwater` VARC' at line 4: CREATE TABLE {migrate_status} ( `machine_name` VARCHAR(255) NOT NULL COMMENT 'Unique machine name for migration', `status` TINYINT unsigned NOT NULL DEFAULT 0 COMMENT 'Current status of migration', `lastimported` DEFAULT NULL COMMENT 'Date and time of last completed import', `highwater` VARCHAR(255) NOT NULL DEFAULT '' COMMENT 'Highwater mark for detecting updated content', `lastthroughput` INT DEFAULT NULL COMMENT 'Rate of success during most recent completed import (# per minute)', PRIMARY KEY (`machine_name`) ) ENGINE = InnoDB DEFAULT CHARACTER SET utf8 COMMENT 'Status information for migrations'; Array ( ) in db_create_table() (line 2561 of /d7/includes/database/database.inc).
Moshe you're on the comment thread so I'm sure you're aware of this, and it looks like there's discussion of rolling that patch back anyway. So whatever it's worth.
Comment | File | Size | Author |
---|---|---|---|
#2 | mysql_type.patch | 584 bytes | lefnire |
Comments
Comment #1
moshe weitzman CreditAttribution: moshe weitzman commentedoh right. that issue pisses me off ... the easiest fix here is to start using integer timestamp like rest of drupal. dad, but true.
Comment #2
lefnire CreditAttribution: lefnire commentedtemp fix
Comment #3
moshe weitzman CreditAttribution: moshe weitzman commentedHmmm. Karen speculates that an undefined datetime could cause problems. I don't know if thats true or not. Also, would be safer to declare migrate_datetime so we don't conflict with another module.
Comment #4
lefnire CreditAttribution: lefnire commentedwell a la #1 we should just use int timestamps instead, right? I'll get around to that patch soon as i can
Comment #5
mikeryanThis finally bit me building a new D7 site, I'll fix it today (make the field an integer timestamp).
Comment #6
mikeryanI've committed this - I didn't have an active D7 site to test against, so the update functions for migrate and migrate_example are untested. If someone with an active D7 Migrate 2 installation could try updating and report here, I'd appreciate it.
Thanks.
Comment #7
mikeryanI've committed the change to the D6 branch as well, let's keep them consistent.
Comment #8
mikeryanThe only question was the D7 update functions, and at this point I would hope someone would've yelled if they didn't work...