I believe Simple Vote creates a problem with the printed output created by print.module.

When print module creates a page that has the Simple Vote widget on it, body text after the (plain text) Simple Vote block is all underlined. When I disable Simple Vote, the problem goes away.

Looking at the html source from the browser, here is what Simple Vote creates on a "normal" page ... stars:

<div class="content"><div class="simplevote_widget">Rating<a href="/production/vote/node/5991/20?destination=node%2F20060715-first-person-real-time" class="vote-on"></a> ... four more times w/ different scores ... </div>

but on the 'plain' html page that print.module creates, it creates numbers and spurious <u> tags:

<div class="simplevote_widget">Rating<u></a><a href="/production/vote/node/5991/40?destination=node%2F5991%2Fprint" class="vote-on"></u> [0]<u></a><a href="/production/vote/node/5991/80?destination=node%2F5991%2Fprint" class="vote-off"></u> [0]<u></a></div>

Note the open u tag right before the end ... it's creating the problem. Not that I know enough to fix it, but I skimmed through the code and couldn't see where the plain (non-star) output was generated.

Hope this makes some kind of sense ...

Comments

eaton’s picture

Project: Simple Vote » Printer, email and PDF versions

This appears to be a bug with print.module's formatting of content, not fivestar.module.

jcnventura’s picture

Status: Active » Postponed (maintainer needs more info)

Can you try it with the latest 5.x dev release, and tell me if it is fixed?

Thanks,

Joao Ventura

jcnventura’s picture

Status: Postponed (maintainer needs more info) » Closed (fixed)

Only now I have seen that the Simple Vote widget is not supported in 5.x. I have tested with the fivestar widget and, by unsetting node->content["fivestar_widget"], I have disabled it's output.

However the general solution would be for the Voting API or the voting widgets to recognize the node->printing flag and disable their output in case that flag is true.

jcnventura’s picture

Project: Printer, email and PDF versions » Fivestar
Version: 4.7.x-1.x-dev » 5.x-1.7
Status: Closed (fixed) » Postponed (maintainer needs more info)
quicksketch’s picture

Status: Postponed (maintainer needs more info) » Closed (won't fix)

Expecting all modules to recognize and support a different output for $node->printing is not a viable request. If output breaks while using a feature of print.module, it is a problem that it needs to deal with.