Drupal 7 port of GMap

Pretty much only the prep work has been done so far. (branching, some coding standards changes that have been applied retroactively to the other branches, etc..)

Current divergence:

HEAD vs DRUPAL-6--1:

 gmap.info       |    5 ++++-                                                             
 gmap.module     |    6 +++---                                                            
 2 files changed, 7 insertions(+), 4 deletions(-)

HEAD vs DRUPAL-5:

 THEMING.txt                  |    8 +-                                     
 TODO.txt                     |    9 +-                                     
 gmap-view-gmap.tpl.php       |   16 +                                      
 gmap.info                    |    4 +                                      
 gmap.module                  |  140 ++++--                                 
 gmap.views.inc               |   36 ++                                     
 gmap_location.compat.inc     |   48 --                                     
 gmap_location.info           |    4 +-                                     
 gmap_location.module         |  452 ++++++------------                     
 gmap_macro_builder.info      |    3 +-                                     
 gmap_macro_builder.install   |    6 +-                                     
 gmap_macro_builder.module    |   28 +-                                     
 gmap_plugin_style_gmap.inc   |  250 ++++++++++                             
 gmap_polyutil.inc            |  215 +++++++--                              
 gmap_settings_ui.inc         |   25 +-                                     
 gmap_taxonomy.info           |    4 +-                                     
 gmap_taxonomy.install        |  110 +++--                                  
 gmap_taxonomy.module         |   81 ++--                                   
 gmap_taxonomy.views.inc      |   35 ++                                     
 gmap_views.info              |    5 -                                      
 gmap_views.module            |  255 ----------                             
 help/array.html              |   46 ++-
 js/gmap.js                   |   53 ++-
 js/gmap_shapes.js            |   23 +
 po/es.po                     |  428 ----------------
 po/fr.po                     |  358 --------------
 po/gmap-module.pot           |  891 ---------------------------------
 po/it.po                     |  845 --------------------------------
 tests/gmap.test              |   88 ++++
 translations/es.po           |  428 ++++++++++++++++
 translations/fr.po           | 1109 ++++++++++++++++++++++++++++++++++++++++++
 translations/gmap-module.pot |  891 +++++++++++++++++++++++++++++++++
 translations/it.po           |  845 ++++++++++++++++++++++++++++++++
 translations/ja.po           |  981 +++++++++++++++++++++++++++++++++++++
 34 files changed, 5349 insertions(+), 3371 deletions(-)

+1

I have created a D7 module http://drupal.org/project/googleapilibs which should provide a stable standard way to add the google libraries in D7, it may help (a little) with the porting of this module.

+1 to this in conjunction with Location. much needed and looked forward to.

Seeing as this is a roadmap type issue it would be good to keep track of this issue - #818638: Update to use Google maps API V3

So potentially gmap-6.x-1.x and gmap-7.x-1.x would be google maps api v2 and then we can have
gmap-6.x-2.x and gmap-7.x-2.x for google maps api v3?

changing title for clarity in dashboard

I'm very new and I don't know if this should be commented but just in case: I could install gmap 7.x-1.x-dev on PHP 5.2, but when using PHP 5.3 I got this message and it does not work:

Warning: Parameter 1 to gmap_admin_settings() expected to be a reference, value given in drupal_retrieve_form() (line 766 of /Library/WebServer/Documents/santvi8/includes/form.inc).

I wish I know more to help, but I hope to learn and be more helpful in the future.

subscribing

Subscribing

Subscribing

subscribing

Subscribe

http://drupal.org/node/33591/release?api_version[]=103 - get latest
Subscribe

Subscribe

Subscribing.

Subscribing

Subscribe

Subscribed

Subscribe

Subscribe

I made a few changes to the GMap codebase to do what I needed in D7. By no means did I complete the port, but I did change the queries to match the D7 Database API.

I have no plans to do any further work on this module. Attached is a patch of my changes, as a small contribution towards the porting effort. I look forward to it being stable :)

Cheers
Ken

subscribing

Subscribe

subscribing...

Patch from #21 committed, thanks!
http://drupal.org/cvs?commit=480040

@rooby in re: google maps api v3 -- I'm really not sure how to go about v3 stuff. There is some functionality that was removed, and the whole macro system and arrays and stuff were following the v2 api pretty closely. I suppose compatibility could be done by translating arrays and so forth, but all of the javascript code would need to be rewritten from scratch. And that includes addon code.

Yeah, I would say the best would be just to post to D7 as is and do a rewrite for v3 in a separate branch.

As you said, v3 is still lacking some functionality that v2 has so a lot of people might not want to or can't switch at this point anyway.

Hopefully the guys in #818638: Update to use Google maps API V3 have time to work on a separate v3 version :)

subscribe

subscribe

subscribe

subscribe

Subscribing.

subscribing

subscribing

susbscribing

susbscribing

subbing

Subscribing

Subscribing

Can somebody send me the archive with gmap already patched? I can't patch gmap :(
thx,

+1

ported already - http://drupal.org/node/680140 - March, 31, 2011

I have the same error "Javascript is required to view this map." :(...i need a gmap module with have this error rezolved plz.

thx

@uMarian:
If you are seeing errors using gmap 7.x-1.x-dev can you please post an issue in the issue queue (if one doesn't already exist for your problem).
This issue is for the task of porting to D7.
Any errors that then appear in the D7 version need their own issues.
That way it is easier to keep track of bugs and easier for people to find the issue that deals with a bug they might be seeing.

Also,

I have the same error "Javascript is required to view this map." :(...i need a gmap module with have this error rezolved plz.

is not sufficient for a bug report.

More information is needed, at very least, what are you trying to do/what page are you viewing when you see this error.

Since I am successfully using 7.x-1.x-dev without seeing that error I wouldn't know where to start looking to help with yours.

I have this problem too. I get error "Javascript is required to view this map"
Modules: ctools, views, flag
GMap, GMap Macro Builder - only enabled.
All js-files of gmap (and Googls maps api) are included.
What should I check first to solve this or help you?

@yultyyev:
See post #43.
First make sure you are using the latest version of the module.
Then check the issue queue for similar issues, if there are none, create a new one, giving as much detail as possible, with the bare minimum being, what is the problem, what page are you on/what are you doing when the problem occurs.
If possible you could even try using the module on a brand new drupal site to see if the same problem occurs (if it doesn't then the problem somehow relates to your individual drupal setup, maybe an incompatibility with another module).

After some hours of experiments, I just found that I was using my own text format in node with map, that formater strips div tags which makes maps working, this code

$o = '<div style="' . implode('; ', $style) . ';" id="' . $element['#id'] . '"' . drupal_attributes($element['#attributes']) . '>' . t('Javascript is required to view this map.') . '</div>';

Provide only "Javascript is required to view this map" string, not entire div.

So, when I change text format to Full HTML maps start show.

I can confirm this. Adding the

subscribe

Really interested in this module port. Please keep us informed !

subscribing

sub

subscribing, hope that module port will be finished soon. Thanks for updating!
Greetings, Martijn

subscribing

+1

Sub

released first alpha release
possibly issue #1831410: Single Markers disappeared after upgrade to version 2.6
please - help with test and bug fix