on node prepare, nid is not yet set. -> b0rk. [#347518]

Fooo ;)

Comment	File	Size	Author
	print-fix-node-prepare-undefinedness.patch	2.75 KB	eMPee584

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jcnventura CreditAttribution: jcnventura commented 16 December 2008 at 11:26

Status:

Needs review

» Fixed

Hi,

Thanks for bringing it up to my attention. I created a modified version of your patch (bypassing the SQL SELECT when nid is not set) and committed it to CVS just now.

João

PS: Changing the paths from printmail and printpdf may result in the mail and PDF icons showing up in the output, if you ever decide to use the content corner links option.

Comment #2

eMPee584 CreditAttribution: eMPee584 commented 16 December 2008 at 16:23

PS: Changing the paths from printmail and printpdf may result in the mail and PDF icons showing up in the output, if you ever decide to use the content corner links option.

well i do and haven't noticed till now but thx just in case ;)

Comment #3

eMPee584 CreditAttribution: eMPee584 commented 24 December 2008 at 01:03

Another comment on your committed fix: it's pretty ugly, and this is not the only part of the code. While the functionality of the module is quite solid by now, a number of small things are done in an unelegant way. That's also the reason why i can not provide a patch for views support even though i hoped to integrate it easily.