Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#4 geocoder.4.x-dev.rector.patch2.42 KBproject update bot
#4 interdiff-last-bot.6942336.txt1.47 KBproject update bot
#2 geocoder.4.x-dev.rector.patch394 bytesproject update bot

Issue fork geocoder-3451105

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new geocoder.4.x-dev.rector.patch394 bytes

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-185727

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.3.1
  2. mglaman/phpstan-drupal: 1.2.11
  3. palantirnet/drupal-rector: 0.20.1

Project Update Bot opened merge request !53

project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6942336.txt1.47 KB
new geocoder.4.x-dev.rector.patch2.42 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-188815

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.3.2
  2. mglaman/phpstan-drupal: 1.2.11
  3. palantirnet/drupal-rector: 0.20.2
baluertl’s picture

baluertl
he/him
Primary language Hungarian
Location Budapest 🇪🇺
commented
Issue summary: View changes
Status: Needs review » Postponed

Quoting from the output of the failing pipeline:

$ composer --version
Composer version 2.7.6 2024-05-04 23:03:15
PHP version 8.3.7 (/usr/local/bin/php)

Apparently the CI tries to install the module on an environment of PHP 8.3 while the issue of #3357840: PHP 8.2 compatibility is still open. Probably we may want merge that first, then this.

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Priority: Normal » Major

@Balu may we proceed with implementing the changes outlined in #3357840: PHP 8.2 compatibility and commence with the work?

Rajeshreeputra opened merge request !54

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Status: Postponed » Needs review

This is blocking D11 upgrade for other contrib modules hence, created MR with required changes, requesting review.

Rajeshreeputra changed the visibility of the branch project-update-bot-only to hidden.

ankitv18 made their first commit to this issue’s fork.

ankitv18’s picture

ankitv18 commented

Dropped D9 as composer.json requires php-http/guzzle7-adapter
And php-http/guzzle7-adapter require guzzlehttp/guzzle ^7.0 Whereas drupal/core-recommended 9.5.11 requires guzzlehttp/guzzle ~6.5.8
Supporting D10.2 and as configFormBase introduce typedDataManger as argument in the constructor in D10.2.x and SettingsForm.php is trying to override the same property with same definition.
So to avoid code redundancy I only pushed 10.2 and 11 version of drupal for next release of this module.

deepakkm’s picture

deepakkm commented
Status: Needs review » Reviewed & tested by the community

Verified changes locally and pipeline is green.

japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Needs work

Looking at the changes, IMHO the minimum should be 9.5.11 and not 10.2. There is no reason to artificially squeeze the compatibility window.

ankitv18’s picture

ankitv18 commented
Status: Needs work » Needs review

Finally pipeline passed ~~ included 9.5 || 10 || 11 and also fixed the cspell job.

itamair’s picture

itamair commented

Ok. QAing and Reviewing this now ...

itamair’s picture

itamair commented

@ankitv18 I would be ok with this MR !54 (and merge it)
BUT I don't get why dependency injection was removed from the src/Form/SettingsForm.php
with all those changes:

https://git.drupalcode.org/project/geocoder/-/merge_requests/54/diffs#20...
https://git.drupalcode.org/project/geocoder/-/merge_requests/54/diffs#20...

that now would rely on:

$typedConfigManager = \Drupal::service('config.typed');

I don't think this is required by Drupal 11, and I don't see any benefit of this refactoring (that rather looks against Drupal Coding Standards)
Thus I would revert all that, unless I am provide with clear motivation for that.

ankitv18’s picture

ankitv18 commented

@itamair typedConfigManager passed as an argument from D10.2 in configFormBase class and settingsForm.php consists of config.factory and typed.config which is already passed as an argument in https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Form%21Co...

So as parent class already having those argument so I don't see any objective of overriding the parent properties and creating the instance with the same properties.

vipin.mittal18’s picture

vipin.mittal18
He/Him
Primary language English
Location Greater Noida, India
commented
Status: Needs review » Reviewed & tested by the community

MR !54 is Drupal 11 compatible and working perfectly with Drupal 11 beta version.

ankitv18’s picture

ankitv18 commented
Issue tags: -ProjectUpdateBotD11

itamair’s picture

itamair commented
Status: Reviewed & tested by the community » Fixed

Thanks @ankitv18, makes sense (I wasn't aware of that 10.2 update).
MR !54 merged ... deploying new 8.x-4.24 with all this

ankitv18’s picture

ankitv18 commented

@itamair I haven't got a credit for this issue.

itamair’s picture

itamair commented

@ankitv18 you are listed as first in the "by list" in the Commit message that merged the MR !54:
https://git.drupalcode.org/project/geocoder/-/commit/c2f2d17d9a9ddc598cc...

as I checked your name (before the others) along merging it (with Pravin Gaikwad as author of the MR).

That's the only way I know to provide Issue Credits and that is instructed in the Drupal documentation:
https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett...

On my side there is nothing more to do on this.

Regards

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.