Problem/Motivation

Mercury Editor hides admin toolbar on its edit form/preview. This works well for classic toolbar/admin_toolbar modules, but doeasn't currently support the new Navigation module that will be available in Drupal 10.3 https://www.drupal.org/node/3443691.

When using the Navigation module admin navigation/toolbar is dispalyed two times on Mercury Editor views.

double admin navigation displayed on Mercury Editor view

Steps to reproduce

  • install Drupal 10.3-beta1 or newer
  • enable Navigation module
  • install Mercury Editor
  • enable Mercury Editor for content type
  • open content edit/add form for content type with Mercury Editor enabled

Proposed resolution

Prevent displaying the new admin navigation toolbar on routes with `_hide_admin_toolbar` option set, simillary as it is done for classic admin toolbars.

CommentFileSizeAuthor
#3 mercury-editor-with-navigation-after-fix.jpg196.15 KBwotnak
mercury-editor-double-navigation.jpg259.03 KBwotnak

Issue fork mercury_editor-3449328

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

wotnak created an issue. See original summary.

wotnak opened merge request !51

wotnak’s picture

wotnak
he/him
commented
Status: Active » Needs review
StatusFileSize
new mercury-editor-with-navigation-after-fix.jpg196.15 KB

Created merge request that adds support for removing the new admin navigation for the routes with the _hide_admin_toolbar option set to true, simillary to how other toolbars are removed.

With this change Mercury Editor page renders corectly without admin navigation toolbars:
Mercury Editor page after applying fix from !51 no longer shows admin navigation

justin2pin made their first commit to this issue’s fork.

  • justin2pin committed 9426c8a8 on 2.1.x authored by wotnak 
    Issue #3449328: Hide new drupal admin navigation on mercury editor...
justin2pin’s picture

justin2pin commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.