Problem/Motivation

Hello, there is a bug that loads the same file twice. To be able to test simply disable Add JavaScript Files
The test was carried out with:

- Drupal 10.2.3
- PHP 8.1
- MySQL 5.44
- Server Nginx

The path where the file is repeated are these:

https://example.com/core/assets/vendor/jquery.ui/ui/widget-min.js?v=10.2.3

https://example.com/modules/contrib/jquery_ui/assets/vendor/jquery.ui/ui...

CommentFileSizeAuthor
#11 jquery_ui-3420890-MR17--20240703-9.diff13.64 KBrecrit
#8 jquery_ui-3420890-MR17--20240702-8.diff2.07 KBrecrit
#7 jquery_ui-3420890-MR17--20240702-7.diff2.06 KBrecrit
#6 jquery_ui-3420890-MR17--20240604-6.diff2.05 KBrecrit
#5 jquery_ui-3420890-MR17--20240603-4.diff1.95 KBrecrit
#4 jquery_ui-3420890-MR17--20240603-3.diff1.85 KBrecrit

Issue fork jquery_ui-3420890

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Nelo_Drup created an issue. See original summary.

recrit’s picture

recrit commented
Title: Remove duplicate modules in JavaScript bundles » Remove duplicate jQuery UI JavaScript and CSS files

I am having this same issue with multiple duplicate JS and CSS files loaded on the page.
This issue may be a duplicate of #3371462: Module defines jQuery UI files independently from Core. Can cause CSS priority issues in AJAX calls, however that ticket focused on CSS and there is no changes in the open MR as of 2024-06-03.

Duplicate JS and CSS files cause performance issues since it bloats the aggregated files and can cause other issues as noted in #3371462: Module defines jQuery UI files independently from Core. Can cause CSS priority issues in AJAX calls.

For example, I am seeing the following duplicate JS files:

modules/contrib/jquery_ui/assets/vendor/jquery.ui/ui/widgets/autocomplete-min.js?v=1.13.2
core/assets/vendor/jquery.ui/ui/widgets/autocomplete-min.js?v=10.2.6

core/assets/vendor/jquery.ui/ui/keycode-min.js?v=10.2.6
modules/contrib/jquery_ui/assets/vendor/jquery.ui/ui/keycode-min.js?v=1.13.2

core/assets/vendor/jquery.ui/ui/widgets/menu-min.js?v=10.2.6
modules/contrib/jquery_ui/assets/vendor/jquery.ui/ui/widgets/menu-min.js?v=1.13.2

modules/contrib/jquery_ui/assets/vendor/jquery.ui/ui/safe-active-element-min.js?v=1.13.2
core/assets/vendor/jquery.ui/ui/safe-active-element-min.js?v=10.2.6

modules/contrib/jquery_ui/assets/vendor/jquery.ui/ui/unique-id-min.js?v=1.13.2
core/assets/vendor/jquery.ui/ui/unique-id-min.js?v=10.2.6

modules/contrib/jquery_ui/assets/vendor/jquery.ui/ui/version-min.js?v=1.13.2
core/assets/vendor/jquery.ui/ui/version-min.js?v=10.2.6

modules/contrib/jquery_ui/assets/vendor/jquery.ui/ui/widget-min.js?v=1.13.2
core/assets/vendor/jquery.ui/ui/widget-min.js?v=10.2.6

For example, I am seeing the following duplicate CSS files:

modules/contrib/jquery_ui/assets/vendor/jquery.ui/themes/base/autocomplete.css
core/assets/vendor/jquery.ui/themes /base/autocomplete.css

modules/contrib/jquery_ui/assets/vendor/jquery.ui/themes/base/core.css
core/assets/vendor/jquery.ui/themes/base/core.css

modules/contrib/jquery_ui/assets/vendor/jquery.ui/themes/base/menu.css
core/assets/vendor/jquery.ui/themes/base/menu.css

modules/contrib/jquery_ui/assets/vendor/jquery.ui/themes/base/theme.css
core/assets/vendor/jquery.ui/themes/base/theme.css

recrit opened merge request !17

recrit’s picture

recrit commented
Status: Active » Needs review
StatusFileSize
new jquery_ui-3420890-MR17--20240603-3.diff1.85 KB

I created an MR with code in the library alter to replace the actual files in the core libraries.
I attached a static patch to be used for builds only. Please use the issue branch for any updates to the patch.

recrit’s picture

recrit commented
StatusFileSize
new jquery_ui-3420890-MR17--20240603-4.diff1.95 KB

updated static patch with latest changes.

recrit’s picture

recrit commented
StatusFileSize
new jquery_ui-3420890-MR17--20240604-6.diff2.05 KB

updated static patch with latest changes.

recrit’s picture

recrit commented
StatusFileSize
new jquery_ui-3420890-MR17--20240702-7.diff2.06 KB

updated static patch with latest changes.

recrit’s picture

recrit commented
StatusFileSize
new jquery_ui-3420890-MR17--20240702-8.diff2.07 KB

updated the static patch with latest changes.

recrit’s picture

recrit commented
Status: Needs review » Needs work
recrit’s picture

recrit commented

Moved to needs work since there is an issue with the latest patch when using core's asset aggregation.

recrit’s picture

recrit commented
Status: Needs work » Needs review
StatusFileSize
new jquery_ui-3420890-MR17--20240703-9.diff13.64 KB

updated the static patch with latest changes to fix issue with JS/CSS aggregation. This sets library file weights to the same as core so that files can be replaced with the jquery_ui contrib module files.

nelo_drup’s picture

nelo_drup commented

#11 @recrit When I use the last interdiff, although the error is solved, other modules such as faq field start giving errors

recrit’s picture

recrit commented

@nelo_drup The faqfield module does have the correct dependency for jquery_ui_accordion/accordion. The change in this ticket should not affect that dependency.

What are the errors that you are seeing?

What version of faqfield are you using?

nelo_drup’s picture

nelo_drup commented

#13 @recrit When I use the patch the jquery accordion stops working my drupal version is 10.4.3

recrit’s picture

recrit commented

@nelo_drup This patch does not affect jQuery UI libraries, for example jquery_ui_accordion/accordion. It only replaces JavaScript files in the Drupal Core libraries with the equivalent files in the jQuery UI module's assets directory.
For that reason, it would not be causing the issues that you are seeing with jquery_ui_accordion/accordion.

I would suggest doing some debugging:

  • Are there any JavaScript errors on the page in the developer console? Use the browser's developer tools to inspect the page.
  • Check the Drupal watchdog logs for any errors
  • Verify that "jquery_ui_accordion" is installed
  • Do you have any custom code - JavaScript or Drupal - that could be interfering with it
  • If you have access to Drush on the site, then post the output of the following commands in order to see the library definitions:
    • drush ev "echo print_r(\Drupal::service('library.discovery')->getLibraryByName('jquery_ui_accordion', 'accordion'), TRUE);"
    • drush ev "echo print_r(\Drupal::service('library.discovery')->getLibraryByName('faqfield', 'faqfield.accordion'), TRUE);"
recrit’s picture

recrit commented
Related issues: +#3483054: Update to jQuery UI 1.14.1

recrit changed the visibility of the branch 3420890-remove-duplicates--after-3483054-jqueryui-1.14.1 to hidden.

recrit’s picture

recrit commented

For Drupal 10.4.x+ support along with jQuery UI updated to 1.14.1 in the jquery_ui module, test the MR 20 on #3483054: Update to jQuery UI 1.14.1, see comment #15 for details. The MR 20 #3483054: Update to jQuery UI 1.14.1 includes the changes from #3483054: Update to jQuery UI 1.14.1 and this issue #3420890: Remove duplicate jQuery UI JavaScript and CSS files .

rajeshreeputra made their first commit to this issue’s fork.