Problem/Motivation

GitlabCi has been released to all projects and will eventually replace DrupalCi.

GitlabCi offers more advanced features including code coverage reporting which can help improve releases going forward.

Steps to reproduce

N/A

Proposed resolution

Create a GitlabCi file and make integration.

Remaining tasks

Create and test a .gitlab-ci.yml file for the project.

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#5 gitlabci.png38.71 KBankondrat4

Issue fork redirect-3413875

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Nikolay Shapovalov created an issue. See original summary.

Nikolay Shapovalov opened merge request !74

nikolay shapovalov’s picture

nikolay shapovalov commented
Status: Active » Needs review
Related issues: +#2582295: Confirmation cancel links are incorrect if installed in a subdirectory

Tests failed, because cancel link leads to wrong location.

1) Drupal\Tests\redirect\FunctionalJavascript\RedirectJavascriptTest::testRedirectUI
Error: Call to a member function press() on null
/builds/issue/redirect-3413875/tests/src/FunctionalJavascript/RedirectJavascriptTest.php:262
/builds/issue/redirect-3413875/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

Cancel link url: /web/web/admin/config/search/redirect
Correct link url: /web/admin/config/search/redirect

I find issue related to it #2582295: Confirmation cancel links are incorrect if installed in a subdirectory.

I was not able to replicate this on localhost, because I am not using prefix.
I suggest to remove clicking cancel link, and use drupalGet to get back on the page.

Another option is implementing workaround #2899166: WORKAROUND: Issue #2582295: Confirmation cancel links are incorrect if installed in a subdirectory.

nikolay shapovalov’s picture

nikolay shapovalov commented
Title: Adopt GitlabCi » Adopt GitlabCi, fix tests
ankondrat4’s picture

ankondrat4 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new gitlabci.png38.71 KB

Hello.

+1 RTBC

https://git.drupalcode.org/issue/redirect-3413875/-/pipelines/75272

Rajeshreeputra made their first commit to this issue’s fork.

Berdir made their first commit to this issue’s fork.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.