Problem/Motivation

I have a simple question. What's the reason behind supporting ~9.5.0 || ~10.1.0?

This knocks 10.0.0 out of the question completely, and there are several modules that don't have 10.1.* compatible releases including the likes of advagg. My ignorance says that if it worked on 9.5.* it should work on 10.0.* as that was pretty much a culling release right?

Furthermore, you are going to have to update the dependencies to be able to allow for 10.2.* when it comes out as you are limiting people with this module to 10.1.* with ~10.1.0

Thoughts?

Proposed resolution

  • Switch to "^9 || ^10" to allow for a smoother upgrade process

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ➖ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Documentation
  • ✅ Code review by maintainers
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Release notes snippet
  • ✅ Release entity_browser_enhanced-8.x-1.4, entity_browser_enhanced-2.0.0

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3393982 by generalredneck: Loosened the restrictions for Entity Browser Enhance(d|r) to ^9 || ^10 to allow for a smoother upgrade process

Issue fork entity_browser_enhanced-3393982

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

generalredneck created an issue. See original summary.

generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
commented
Title: Support for 10.0.0 » Support for 10.0.0 and 10.2.*
generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
commented
Category: Support request » Bug report

So looking into it... The change was made between 1.2 and 1.3 here: https://git.drupalcode.org/project/entity_browser_enhanced/-/commit/6258...

I think someone got confused between what the tilde ~ and the carat ^

For one... based on that change up until that point, the dependency criteria was TECHINCALLY different but functioned the same because of the way it was written. composer.json contained"drupal/core": "~8.0 || ~9.0 || ~10.0", and entity_browser_enhanced.info.yml contained core_version_requirement: ^8 || ^9 || ^10

I think this lead someone to believe that ^ and ~ were the same. Let me see if I can explain.

~ is the magic operator here. If you write ~10.0 that means >=10.0 <11.0.0. If you write ~10.0.0 that means >=10.0.0 <10.1.0. Another way of looking at it is that using ~ specifies a minimum version, but allows the last digit specified to go up.

^ on the other hand sticks to non-breaking changes by allowing all versions to upgrade except major versions... So in that example ^10.0.0 and ^10.0 are equivalent. This is the case for all versions greater than 1.0.0. Check out https://getcomposer.org/doc/articles/versions.md#next-significant-releas...

So I'm going to make a MR with the changes.

generalredneck opened merge request !5

rajab natshah’s picture

rajab natshah
he/him
commented
Title: Support for 10.0.0 and 10.2.* » Loosen the restrictions for Entity Browser Enhance(d|r) to ^9 || ^10 to allow for a smoother upgrade process

Agrees, with you Allan.
Changing it to "^9 || ^10"
Only trying to push teams to use ~10.1.0 and later.
Maybe not everyone is ready for:

Drupal 9 support will end in November 2023

November 1, 2023 (UTC) Drupal 9 reaches end-of-life due to its dependency on Symfony 4.
Reference: Symfony 4.4 release checker.
What to do about Drupal 9's end of life in November 2023

Drush 11 support will end in November 2023

Also Drupal ~10.0.0 went out of support
Not even listed in the Drupal core release cycle

It feels that, not everyone is ready to jump to ~10.1.0
with all of that:

  • Loosen the restrictions a bit
  • Smoother upgrade process

Switching to ^9 || ^10

generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
commented

On the contrary, it is mentioned in the 10.2.0 development cycle:
https://www.drupal.org/about/core/policies/core-release-cycles/schedule#...

Week of December 11, 2023 (UTC)

Drupal 10.2.0 released.
End of security support for 10.0.x.

Again, you say

~10.1.0 and later.

I think you mean ^10.1.0 in that statement. because ~10.1.0 is == 10.1.* and would not support later versions of drupal.

rajab natshah’s picture

rajab natshah
he/him
commented

Yes, Allan
I treated this module as part of the Varbase Media ecosystem and development team rules.
That was wrong.

You are right, public used contrib modules should allow for more flexibility.
looking at the best.
https://www.drupal.org/project/webform
https://www.drupal.org/project/ctools

Switching to "^9 || ^10"

generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
commented

Rajab,

I hope I didn't offend, I was trying to help understanding, not beat an admission of guilt out of you. I hope that I'm just reading too much into your words, but If there are any hard feelings, lets talk, and feel free to slack with me on ways I can improve the way I communicate.

You are not "wrong" and I can see where you come from. Thanks for working with me on this.

rajab natshah’s picture

rajab natshah
he/him
commented

Not at all, Allan

I enjoy the subject of packaging and having the best option at the time.

Thanks for reporting, and following up with the MR.

We will be open to change that in 1 month or 1 year to drop support for Drupal 9. or may not, we do not know, we may keep the ^9 and add the ^11 and start playing with D11 :)

Better not to have any development branches @dev required packages/libraries, better with @stable versions( ~1.0, ~2.0, ~3.0 , ~4.0, ext... ). not to bring any alphas, betas, RCs on a production site.

Tilde Version Range (~)

It is a way between drupal/core and drupal/core-recommended

By the way I'm with the Drupal Core Recommended way.
With Tilde Version Range (~) and all 3 parts of the version.

I'm pushing to move everything to that. Some time it dose not work.

I'm passing not with the recommended way for this module, and having the most general way. Only to allow for a smoother upgrade process.

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
Status: Active » Needs review
Issue tags: +entity_browser_enhanced-8.x-1.4, +entity_browser_enhanced-2.0.0

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

✅ Released entity_browser_enhanced-8.x-1.4

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
Status: Needs review » Fixed

✅ Released entity_browser_enhanced-2.0.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.