Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new2.05 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
project update bot’s picture

igoragatti’s picture

Issue summary: View changes
StatusFileSize
new2.46 KB

I've updated the patch so that the info.yml file shows the compatibility with Drupal 10.

protitude’s picture

I have tested the #4 patch on both my Drupal 9 and a fresh Drupal 10 site, and I did not encounter any issues. The patch seemed to work seamlessly on both sites.

kthull’s picture

#4 applies, but I get the following warnings via upgrade status:

File Name
responsive_menu/responsive_menu.libraries.yml

Line
0

Error
The 'responsive_menu.superfish' library is depending on a deprecated library. The core/jquery.once asset library is deprecated in Drupal 9.3.0 and will be removed in Drupal 10.0.0. Use the core/once library instead. See https://www.drupal.org/node/3158256

File Name
responsive_menu/tests/themes/responsive_menu_theme_test_nobp/responsive_menu_theme_test_nobp.info.yml

Line
0

Error
Add core_version_requirement: ^8 || ^9 to designate that the extension is compatible with Drupal 9. See https://drupal.org/node/3070687..

stevenlafl’s picture

Here's one with the test theme core_version_requirement as well.

helioha made their first commit to this issue’s fork.

yogeshsevak’s picture

After applying #7, the upgrade status module is still showing the below error.

The 'responsive_menu.superfish' library is depending on a deprecated library. The core/jquery.once asset library is deprecated in Drupal 9.3.0 and will be removed in Drupal 10.0.0. Use the core/once library instead. See https://www.drupal.org/node/3158256

Providing updated patch with fix. All errors and warnings shown by the Upgrade Status module have been fixed in this patch.

Please review.

Status: Needs review » Needs work

The last submitted patch, 9: responsive-menu-d10-compatibility-3297963-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

yogeshsevak’s picture

Providing patches for below versions.
For 4.4.x-dev responsive-menu-d10-compatibility-3297963-9.patch
For 4.4.2 responsive-menu-d10-compatibility-3297963-11.patch

Please review.

yogeshsevak’s picture

Status: Needs work » Needs review
ilfelice’s picture

Howdy,

After applying the patch in #7, I can install the module in Drupal 10, and confirm that it works as expected.

mikemadison’s picture

it would be awesome if we could get this merged. this is the last blocking item on one of my sites to get to d10!

mhespanhol made their first commit to this issue’s fork.

sirclickalot’s picture

I second #14, we are almost there!

maria.y’s picture

Patch #7 works for me too. :)

Thanks in advance to the most awesome maintainers.

tanc’s picture

Tests are failing due to bartik and stable no longer being included. Updated tests and will hopefully pass.

Status: Needs review » Needs work

The last submitted patch, 18: responsive-menu-d10-compatibility-3297963-18.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tanc’s picture

Status: Needs work » Reviewed & tested by the community
Issue tags: -ProjectUpdateBotD10

Drupal.org's tests are very confusing... They pass locally but fail on d.o's infrastructure. I'm tempted to commit this as I've tested locally and then open another issue to fix the tests

  • tanc committed 6e1e01cf on 4.4.x
    Issue #3297963 by yogeshsevak, helioha, tanc, mhespanhol, igoragatti,...
tanc’s picture

Status: Reviewed & tested by the community » Fixed

Thanks everyone for your help. I've committed the patch to 4.4.x branch and created this issue to fix the failing test #3364997: Fix failing test

As soon as that test is fixed we can look at a release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

dbielke1986’s picture

Is there a chance to push the changes to a new release? We need to update our page to D10 and this module is one which is incompatible to D10.

jordan.jamous’s picture

We would appreciate a new release for 4.4.x-dev here as well, thanks for your efforts.