Problem/Motivation

There is a failing test (ResponsiveMenuAdminTest) that needs debugging and fixing.

Steps to reproduce

Run the tests locally or on d.o CI

Proposed resolution

Try to replicate it and then fix it

Issue fork responsive_menu-3364997

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tanc created an issue. See original summary.

aangel made their first commit to this issue’s fork.

aangel opened merge request !16

aangel’s picture

aangel commented

I was able to reproduce the error locally. The test is failing because it is checking for the addition of the polyfills script to the page. The problem is that the latest version of the mmenu library does not include that file.

The file may be missing simply due to a compilation error over at mmenu, which has happened at least twice before that I could find
(mmenu.polyfills.js removed in 8.4.5? and How to include polyfills for IE11? ). The maintainer re-compiled and it came back.

There are two ways forward.

I can ask the maintainer to add the polyfill file back. Or, given that D10 is no longer supporting IE, I've created an MR with the polyfill logic for the config, the form and test removed. I'm not attached to either direction and you will have a better idea if the polyfill needs to stick around longer.

aangel’s picture

aangel commented
Status: Active » Needs review
aangel’s picture

aangel commented

Just spotted this in the README of mmenu:

Browser support
As of version 9, the mmenu.js plugin only supports ECMAScript 6 compliant browsers.
For Internet Explorer 11, you can use the latest of version 8 and use polyfills where needed.

So there doesn't seem to be an intention of allowing the 9.x branch with polyfills.