Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#7 configuration_saved_successfully.png16.24 KBtyler36
#3 rename_admin_paths.2.x-dev.rector.patch5.51 KBProject Update Bot
#3 interdiff-last-bot.6659600.txt793 bytesProject Update Bot
#2 rename_admin_paths.2.x-dev.rector.patch6.23 KBProject Update Bot

Issue fork rename_admin_paths-3297951

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Project Update Bot created an issue. See original summary.

Project Update Bot’s picture

Project Update Bot CreditAttribution: Project Update Bot commented
Status: Active » Needs review
FileSize
rename_admin_paths.2.x-dev.rector.patch6.23 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
Project Update Bot’s picture

Project Update Bot CreditAttribution: Project Update Bot commented
FileSize
interdiff-last-bot.6659600.txt793 bytes
rename_admin_paths.2.x-dev.rector.patch5.51 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #143

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.0
Project Update Bot’s picture

Project Update Bot CreditAttribution: Project Update Bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

tyler36 made their first commit to this issue’s fork.

tyler36 opened merge request !6

tyler36’s picture

tyler36 CreditAttribution: tyler36 at Inter Quest commented
Issue summary: View changes
FileSize
configuration_saved_successfully.png16.24 KB

## Test

1. Start Drupalpod session with on "3297951-automated-drupal-10" branch
2. Login as admin
3. Visit "/admin/config/system/rename-admin-paths"
4. Check "Rename admin path"
5. In "Replace "admin" in admin path by" enter "backend"
6. Save the page; the URL should now include be "/backend ...."

ptmkenny’s picture

ptmkenny CreditAttribution: ptmkenny as a volunteer commented
Status: Needs review » Needs work

When testing merge request 6, Upgrade Status module issues the following warnings:

CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Rename Admin Paths
Scanned on Mon, 01/09/2023 - 22:36.

2 warnings found.

web/modules/contrib/rename_admin_paths/tests/src/Unit/Form/RenameAdminPathsSetti
ngsFormTest.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 95   │ Call to deprecated method prophesize() of class              │
│ manually │      │ Drupal\Tests\rename_admin_paths\Unit\Form\RenameAdminPathsSe │
│          │      │ ttingsFormTest:                                              │
│          │      │ https://github.com/sebastianbergmann/phpunit/issues/4141     │
│          │      │                                                              │
│ Check    │ 105  │ Call to deprecated method prophesize() of class              │
│ manually │      │ Drupal\Tests\rename_admin_paths\Unit\Form\RenameAdminPathsSe │
│          │      │ ttingsFormTest:                                              │
│          │      │ https://github.com/sebastianbergmann/phpunit/issues/4141     │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘
tyler36’s picture

tyler36 CreditAttribution: tyler36 at Inter Quest commented
Status: Needs work » Needs review

Update MR with fix for deprecated prophesize.

ptmkenny’s picture

ptmkenny CreditAttribution: ptmkenny as a volunteer commented
Status: Needs review » Needs work

Thanks for fixing, but it looks like line 95 didn't get fixed, just 105:

CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Rename Admin Paths
Scanned on Tue, 01/10/2023 - 12:45.

1 warning found.

web/modules/contrib/rename_admin_paths/tests/src/Unit/Form/RenameAdminPathsSetti
ngsFormTest.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 95   │ Call to deprecated method prophesize() of class              │
│ manually │      │ Drupal\Tests\rename_admin_paths\Unit\Form\RenameAdminPathsSe │
│          │      │ ttingsFormTest:                                              │
│          │      │ https://github.com/sebastianbergmann/phpunit/issues/4141     │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘
tyler36’s picture

tyler36 CreditAttribution: tyler36 at Inter Quest commented
Status: Needs work » Needs review

Sorry ... I had it fixed locally but I guess I missed it when I staged changes.
Force updated the MR please check again.

loopy1492 made their first commit to this issue’s fork.

loopy1492’s picture

loopy1492 CreditAttribution: loopy1492 commented

Thanks @tyler36. I have applied the patch to our site (Drupal 9.5.1 on PHP 8.1). Upgrade status module reports hooray and I have confirmed editing and using the renamed path works fine. Looking forward to a new release.

tyler36’s picture

tyler36 CreditAttribution: tyler36 at Inter Quest commented

@loop1492

If you have confirmed it working as expect, please change the status to "Reviewed & Tested by the community".
This will move the ticket along to the point it can be merged and released.

squiggy’s picture

squiggy CreditAttribution: squiggy at Kalamuna commented
Status: Needs review » Reviewed & tested by the community

I can confirm the module is working. I checkout out branch 3297951-automated-drupal-10 on the issue fork. I edited the form and changed the path. Exported the changed config. Everything is working. Thanks!

rusylnarito’s picture

rusylnarito CreditAttribution: rusylnarito as a volunteer commented

  • Patch Working Tested
  • Drupal 10
  • 3297951-automated-drupal-10

ptmkenny’s picture

ptmkenny CreditAttribution: ptmkenny as a volunteer commented

I can confirm the issue I mentioned in #10 is now fixed in the MR.

@squiggy Before marking RTBC, please confirm the comments in the issue have been addressed, such as my comment in #10. Even if the patch generally works, all noted issues have to be addressed or it will just get set back to "Needs work" again, delaying the process.

slootjes made their first commit to this issue’s fork.

  • slootjes committed e2a72bec on 8.x-2.x authored by tyler36 
    Issue #3297951 by tyler36, loopy1492, Project Update Bot, ptmkenny,...
slootjes’s picture

slootjes CreditAttribution: slootjes at Media.Monks commented

Thanks all for your contribution.

slootjes’s picture

slootjes CreditAttribution: slootjes at Media.Monks commented
Status: Reviewed & tested by the community » Fixed
pick_d’s picture

pick_d CreditAttribution: pick_d commented

Any chance the regular (not dev) version of the module will be updated with these patches implemented?

rjjakes’s picture

rjjakes CreditAttribution: rjjakes at Investis Digital commented

@slootjes - can a release be created now the patch has been merged?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

endrukk’s picture

endrukk CreditAttribution: endrukk as a volunteer and commented

Sorry, reopening this - @Raphael Apard, @slootjes can we create a new release with the patch please?

endless_wander’s picture

endless_wander CreditAttribution: endless_wander as a volunteer commented

Would like to add my voice for getting a real release of this for Drupal 10 please

raynaldmo’s picture

raynaldmo CreditAttribution: raynaldmo as a volunteer and commented

Echoing @endless_wander
Very useful module
It would be great to have an official (non-dev) release for Drupal 10. Currently, blocking me from updating my site to D10.
Thanks

rcodina’s picture

rcodina CreditAttribution: rcodina at Seidor commented

Please, create a new stable release compatible with Drupal 10.

rjjakes’s picture

rjjakes CreditAttribution: rjjakes at Investis Digital commented

D10 release has been created https://www.drupal.org/project/rename_admin_paths/releases/8.x-2.2-beta1