Automated Drupal 10 compatibility fixes

Reviewd the automated patch but facing deprecations issues so created child issue for same and working on it.

Thanks

Testing Steps:
1. Install the Node view count module (8.x-1.x-dev) version on drupal 9
2. Checked the upgrade status module. (Note: 19 Deprecations issues)
3. Get the patch form the child issue Fix the deprecation issues
4. Apply patch in the drupal 9 in Node view count module and check the upgrade status (Note:- After apply patch 0 issues)
5. Install drupal 10
6. Install the Node view count module module (8.x-1.x-dev) on drupal 10
7. Apply patch in the Node view count module
8. Enable the module and reload the page
9. Now this module is enabled and also install successfully

The module has been successfully installed on Drupal 10, it can now be moved to RTBC. RTBC+1

Thanks!

Checked the automated patch works well. with drupal 9
ran the module through upgrade_status and found depricated code still remaining.
adding a patch to update that as well.

No more depricated code remaining after this.
keeping this in NW to check this patch as well.
after that can be moved to RTBC
RTBC+1

Applied patch #7 and tested in Drupal 9.5.7 and D 10 . The functionality is working as expected , attached screenshot for reference. Got some deprecated errors related to Call to Undefined method etc. Resolved that issue in my patch and tested.
Rest of the issue are ignorable for which attached in screenshot.

I checked the automated patch #2 works well with drupal 9. But, This patch does not update the info.yml file for Drupal 10 compatibility.
I have updated the info.yml after that i install this module and found it is working fine with Drupal 10.

Testing Steps:

PHP Version: 8.1.16
Database: 10.4.28-MariaDB-1:10.4.28+maria~ubu2004-log
Drupal Version: 10.0.7
Module Branch: 8.x-1.x

1. Install Drupal 10
2. Install the Node view count module module (8.x-1.x) on Drupal 10
3. Apply patch in the Node view count module
4. Enable the module and reload the page
5. Now this module is enabled and also install successfully

The module has been successfully installed on Drupal 10, I am moving it to RTBC.

Thanks!

Hello shashank5563. I checked your patch for compatibility with Drupal 10. The module turned on at first glance without problems, but I tried to run the tests, and they all failed. I guess before creating a new release we should fix the tests first and after that check module codebase manually.

@adci_contributor, Some phpunit test is not working on my local. So, I need to first fix the my phpunit test on local after that i will look these issue.

Thanks

The MR has all the changes required to make it 9.5 and 10 compatible + tests are passing now (please enable testing on drupal.org, so we can run them)

@Taran2L https://git.drupalcode.org/project/nodeviewcount/-/merge_requests/2/diff... removes the composer.json file which is needed to directly include the issue fork in a project's root composer.json.

Was there a reason for dropping the composer.json? If not, please bring it back. Thanks.

@Taran2L need to add GitlabCI pipeline file to enable automated testing https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr...

@lelkneralfaro, composer.json is not needed unless module has dependencies, which is not the case for this module, in case you want to use it in D10 project, go with the composer lenient plugin, see https://www.drupal.org/docs/develop/using-composer/using-drupals-lenient...

Also MR is open to anyone to change, like me. So, I (probably) broke your setup :) Lenient plugin + static patch (I mean actual file, not a dynamic MR diff) is the way to go

@AardWolf, let me check

I applied MR !2 this works for Drupal 9.5.10 and Drupal 10.0. and 10.0.1
Screenshots of the compatibility on 9.5 have been attached for reference:

Can be move to RTBC+1

Hello.

After changes in MR from 14.11.2023 by Roman Pask, MR !2 doesn't apply as expected. Only applied from commits:
https://git.drupalcode.org/issue/nodeviewcount-3297739/-/commit/42ca8c7e...
https://git.drupalcode.org/issue/nodeviewcount-3297739/-/commit/f38210a6...

From this commit https://git.drupalcode.org/issue/nodeviewcount-3297739/-/commit/b5f5b43c... we have failed MR2 patch

Patch might not apply for the alpha version, have you tried dev version?

Also, the last patch has renames, patches with renames do not work on Mac usually, see https://github.com/cweagans/composer-patches/issues/172#issuecomment-470...

Patch was failed with DEV version too. I have tested on Ubuntu, not on Mac.

Somehow, it works for me (and it applies as MR shows)

Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
  - Installing drupal/nodeviewcount (dev-1.x 2583489): Cloning 2583489107 from cache
  - Applying patches for drupal/nodeviewcount
    https://git.drupalcode.org/project/nodeviewcount/-/merge_requests/2.diff (D10 - MR)

Maybe you are running old(er) patch utility?

Please don't remove composer.json
I do not want extra plugin and commands when I can just add composer.json, which is not causing any harm

Hello.
I could apply MR2 as patch only to DEV version of module.
+1RTBC

Gathering patches for dependencies. This might take a minute.
  - Installing drupal/nodeviewcount (dev-1.x 2583489): Cloning 2583489107 from cache
  - Applying patches for drupal/nodeviewcount
    https://git.drupalcode.org/project/nodeviewcount/-/merge_requests/2.diff (Automated Drupal 10 compatibility fixes)

Generating optimized autoload files

This patch business is a bit baffling.

I'm running a Lando "drupal9" recipe on Ubuntu. The patch generated from the MR wouldn't apply to either the alpha2 or dev releases. No particular error or indication of what caused the issue, just "could not apply patch".

Assuming the composer patches use the underlying OS patch functionality, I am running the latest version of GNU patch 2.7.6. I've never had an issue such as this before.

Also note, the alpha2 and dev releases reference the same commit so I'd expect them to behave the same. If they do behave differently (for me they both failed) perhaps this is indicative of something going on with the Drupal.org packaging. Perhaps if adds a composer.json etc. to tagged releases and not for dev releases? I don't know that to be the case, just spitballing.

Solution

Not sure if there is a way to do this using the MR or some other functionality within the GitLab, but I ended up pulling the repo locally and made a patch from one of the previous commits.

git diff origin/8.x-1.x...42ca8c7e033607336b2cfcb1262815bfb1c06f99 > nodeviewcount-d10_compatibility.patch

Thanks everyone for your help!

The latest update is based on a patch from the Project Update Bot + some fixes have been added for tests, etc. Hope this will be a good place to start.
The Dev version should now support Drupal 10. Tests will work correctly starting from Drupal 9.3+