Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#10 interdiff_3-8.txt3.78 KBfathima.asmat
#8 interdiff_3-8.patch3.78 KBfathima.asmat
#8 3297638-menu_item_extras-drupal-10-compatibility-8.patch6.16 KBfathima.asmat
#8 Screenshot 2022-11-19 at 12.59.25.png25.68 KBfathima.asmat
#8 Screenshot 2022-11-19 at 13.00.34.png106.2 KBfathima.asmat
#8 Screenshot 2022-11-19 at 13.00.23.png49.81 KBfathima.asmat
#5 menu_item_extras.2.x-dev.rector.patch3.71 KBproject update bot
#5 interdiff-last-bot.6659274.txt533 bytesproject update bot
#3 3297638-menu_item_extras-drupal-10-compatibility.patch1.99 KBzarabatana
#2 menu_item_extras.2.x-dev.rector.patch3.22 KBproject update bot

Issue fork menu_item_extras-3297638

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new menu_item_extras.2.x-dev.rector.patch3.22 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
zarabatana’s picture

zarabatana commented
Issue summary: View changes
StatusFileSize
new 3297638-menu_item_extras-drupal-10-compatibility.patch1.99 KB

This patch will add the remaining fixes for full Drupal 10 compatibility.

Status: Needs review » Needs work

The last submitted patch, 3: 3297638-menu_item_extras-drupal-10-compatibility.patch, failed testing. View results

project update bot’s picture

project update bot commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-last-bot.6659274.txt533 bytes
new menu_item_extras.2.x-dev.rector.patch3.71 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.1, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #145

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.1
project update bot’s picture

project update bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

fathima.asmat’s picture

fathima.asmat commented
Assigned: Unassigned » fathima.asmat
Issue summary: View changes
fathima.asmat’s picture

fathima.asmat commented
StatusFileSize
new Screenshot 2022-11-19 at 13.00.23.png49.81 KB
new Screenshot 2022-11-19 at 13.00.34.png106.2 KB
new Screenshot 2022-11-19 at 12.59.25.png25.68 KB
new 3297638-menu_item_extras-drupal-10-compatibility-8.patch6.16 KB
new interdiff_3-8.patch3.78 KB
  • Tested rector patch #5 and couldn't apply due to missing info yml changes.
  • So rerolled patch #3 with #5 and could apply successfully on both D9 and D10.
  • Upgrade status still flagged the deprecated constant issue as below:
Fix later      39   Call to deprecated constant FILE_STATUS_PERMANENT:          
                      Deprecated in drupal:9.3.0 and is removed from              
                      drupal:10.0.0. Use                                          
                      Drupal\file\FileInterface::STATUS_PERMANENT or              
                      \Drupal\file\FileInterface::setPermanent().
  • Added the suggested fix too.
    • Tested the module with the amended patch on both D10 an dD9.
    • Could successfully add an extra field to main menu and rendered it on the menu template as expected.
    • Attached screenshots of test results.
    fathima.asmat’s picture

    fathima.asmat commented

    Removed duplicated comment

    fathima.asmat’s picture

    fathima.asmat commented
    StatusFileSize
    new interdiff_3-8.txt3.78 KB

    .patch removed from interdiff.

    fathima.asmat’s picture

    fathima.asmat commented
    Assigned: fathima.asmat » Unassigned
    fathima.asmat’s picture

    fathima.asmat commented
    Issue tags: +Drupal 10 porting day

    The last submitted patch, 8: 3297638-menu_item_extras-drupal-10-compatibility-8.patch, failed testing. View results
    - codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

    anybody’s picture

    anybody
    Primary language German
    Location Porta Westfalica
    commented
    Priority: Normal » Major

    Drupal 10 is close, did the maintainers already have a look?

    voleger’s picture

    voleger
    he/his
    Primary language Ukrainian
    Location Ukraine, Rivne
    commented
    Status: Needs review » Needs work

    Yes, please, create a MR, I'll take a look

    XLD made their first commit to this issue’s fork.

    XLD opened merge request !23

    anybody’s picture

    anybody
    Primary language German
    Location Porta Westfalica
    commented

    Thanks @XLD - is this still WIP?

    Before it can be reviewed, the core version compatibility in the .info file also has to be adjusted.

    Edit: I did that now.

    xld’s picture

    xld commented

    Sorry @anybody, I did not see that in time. I'll try to see what's wrong with the tests for D10, if you have some time, please assist.

    grevil’s picture

    grevil commented
    Assigned: Unassigned » grevil

    There are still quite a few deprecation problems, I'll try to fix them.

    EDIT: Sorry, not a few, only 1 deprecation error inside the twig file:

    Using an "if" condition on "for" tag in
    "modules/custom/menu_item_extras-3297638/templates/menu-leve
    ls.html.twig" at line 13 is deprecated since Twig 2.10.0

    grevil’s picture

    grevil commented

    Further PHPUnit deprecation errors:

    The "PHPUnit\Framework\TestCase::__construct()" method is considered internal This method is not covered by the backward compatibility promise for PHPUnit

    This is called in 4 seperate Test-Classes which have no value for the tests, as the tests are not extending from these classes! I'll remove them in this issue, if the maintainer feels like this is out of this issue's scope, we can revert that change once again.

    grevil’s picture

    grevil commented

    I can confirm, that the Module is installable on Drupal 10.0.0 and that the tests are passing locally, let's see if they pass remotely. If not there might be a race condition inside the tests.

    grevil’s picture

    grevil commented
    Assigned: grevil » Unassigned
    Status: Needs work » Reviewed & tested by the community
    Issue tags: -Drupal 10 porting day

    All tests pass! Setting this to RTBC!

    anybody’s picture

    anybody
    Primary language German
    Location Porta Westfalica
    commented

    Great work, @Grevil! Confirming RTBC! Nice cleanup.

    @Maintainers: Please review and create a new release. 3.x semVer release seems to make sense here?

    anybody’s picture

    anybody
    Primary language German
    Location Porta Westfalica
    commented

    @voleger ready? :)

    anybody’s picture

    anybody
    Primary language German
    Location Porta Westfalica
    commented

    vladimiraus’s picture

    vladimiraus
    Primary language English
    Location Brisbane 🇦🇺
    commented
    Status: Reviewed & tested by the community » Fixed

    Thank you.

    VladimirAus closed merge request !23

    Status: Fixed » Closed (fixed)

    Automatically closed - issue fixed for 2 weeks with no activity.