Drupal 10 compatibility fixes

Tested the patch. Couldn't install the module to Drupal 10.
Currently, Drupal 10 has dependency on psr/log package ver 3 and rollbar/rollbar package should be updated to use the same version: Once the issue is fixed (https://github.com/rollbar/rollbar-php/issues/570) the module will be compatible with Drupal 10

Sounds like this is postponed based on #3 but we don't want to mark postponed in case the bot has more patches. I guess leaving as Needs review is okay but it shouldn't be tested again. Just need to continue to check the status of the issue. It's currently still open.

This shouldn't be postponed based on #3. It should be committed asap and set to Active or Fixed as per maintainer desire.

The release of a D10 compatible version of this module could be postponed as it can't be installed due to version constraints on par/log.

No idea how realistic these constraints are, only drush (consolidation/log) and core seem to insist on ^3.

docker@d10a5:/var/www$ composer depends psr/log
chi-teck/drupal-code-generator  2.5.3        requires psr/log (^1.1 || ^2.0 || ^3.0)
consolidation/annotated-command 4.5.6        requires psr/log (^1|^2|^3)
consolidation/log               2.x-dev      requires psr/log (^3)
drupal/core                     10.0.0-beta1 requires psr/log (^3.0)
grasmash/expander               2.0.3        requires psr/log (^1 | ^2 | ^3)
symfony/error-handler           v6.1.3       requires psr/log (^1|^2|^3)
symfony/http-kernel             v6.1.4       requires psr/log (^1|^2|^3)
docker@d10a5:/var/www$

Turns out core is the problem. For installation to succeed you need an inline alias for psr/log:

docker@d10a5:/var/www$ composer require drupal/rollbar
Using version ^2.0 for drupal/rollbar
./composer.json has been updated
Running composer update drupal/rollbar
Loading composer repositories with package information
Updating dependencies
Lock file operations: 3 installs, 0 updates, 0 removals
  - Locking drupal/rollbar (2.0.1)
  - Locking monolog/monolog (2.8.0)
  - Locking rollbar/rollbar (v3.1.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 3 installs, 0 updates, 0 removals
  - Downloading monolog/monolog (2.8.0)
  - Downloading rollbar/rollbar (v3.1.3)
  - Downloading drupal/rollbar (2.0.1)
  - Installing monolog/monolog (2.8.0): Extracting archive
  - Installing rollbar/rollbar (v3.1.3): Extracting archive
  - Installing drupal/rollbar (2.0.1): Extracting archive
10 package suggestions were added by new dependencies, use `composer suggest` to see details.
Package webmozart/path-util is abandoned, you should avoid using it. Use symfony/filesystem instead.
Generating autoload files
41 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
Found 1 security vulnerability advisory affecting 1 package.
Run composer audit for a full list of advisories.
docker@d10a5:/var/www$

Since it couldn’t be tested before, then I wouldn’t suggest committing the changes based on that. But, it looks like you figured out a way to install so it can be tested. Thanks!

I have tested the MR and confirmed that it is working perfectly in Drupal 10.
I also checked the code deprecation. So there is no deprecation.
We can go with it.
Thank you.

Thanks Elaman, great job. Tested on our website, works well.

Thank you so much @intrafusion for such quick action! Would you be so kind to create a new release for the version supporting Drupal 10 please?

The change to the function signature in this issue actually breaks backwards compatibility as per #3379795: Rollbar is not compatible with Drupal 10 again

@intrafusion I created issue #3379795 with the intention of not committing it. If you apply my fix the module won't be compatible with D10. This is why I mentioned it is something hard to fix, you can't be compatible with the 2 PSR3 signatures at the same time.

New release 2.1.0 which is for Drupal 10 only