Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Currently the "plain" URL Formatter trims off the query string and named anchors. This patch corrects the URLs to include all the information.
Comment | File | Size | Author |
---|---|---|---|
#16 | 0001-Don-t-separate-query-string.patch | 849 bytes | ohthehugemanatee |
#10 | link_field_settings.png | 105.17 KB | das-peter |
link_plain_formatter_url.patch | 714 bytes | quicksketch | |
Comments
Comment #1
quicksketchLooks like the Drupal 5 version doesn't suffer from this problem. I've committed to the Drupal 6 version.
Comment #2
Anonymous (not verified) CreditAttribution: Anonymous commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #3
Summit CreditAttribution: Summit commentedHi, setting to active again on D7 if thats ok.
Could this issue be still there for the D7 version?
I have tried several Link fields, and the query strings seem to get lost..
See for example issue: http://drupal.org/node/1397700#comment-5443574
Greetings, Martijn
Comment #4
Summit CreditAttribution: Summit commentedHi, Sorry I see this issue for D7, setting this to duplicate if thats ok: http://drupal.org/node/1321482
greetings, Martijn
Comment #5
Summit CreditAttribution: Summit commentedHi, Setting this to active on D6 again.
I use shorturl module on D6, but on D6 still Link breaks of the query string and named anchors when using together with custom formatters. The patch on http://drupal.org/node/1309658 didn't help on D6.
Sorry if wrong set to active again.
Greetings, Martijn
Comment #6
dqdBut it doesn't break the site completely nor is it a security risk, please use "critical" carefully.
Thanks for understanding.
And thanks for the report, much appreciated.
Comment #7
Summit CreditAttribution: Summit commentedHi, Set this to critical not on purpose, wanted to set it to active only, sorry!
Greetings, Martijn
Comment #8
dqdNot sure if it sticks together but this issue #1321482: Query string and fragment are removed has been fixed, committed and pushed to HEAD. Can you please recheck if the errors persist in D7 latest --dev? If not we can assume that we can solve this the same way on D6 maybe
Comment #9
dqdI think we need some reviews and tests on the latest --dev versions of the link module, since there were some commits in the last nights ...
I still can't reproduce it ...
Comment #10
das-peter CreditAttribution: das-peter commentedI've just tested this with these url's:
Test-Setup:
Field-Settings: See attached image
Output by Views: Used fields, output formatter
URL, as plain text
Modules: About ~67 other modules are enabled in this installation. But no
workbench_moderation
.Unfortunately I can't reproduce the issue. The URL is displayed as expected.
Comment #11
das-peter CreditAttribution: das-peter commented*grml* cross post :)
Comment #12
virtualdrupal CreditAttribution: virtualdrupal commentedI've got one for you, saves into the database fine but when displayed in views or display suite (using any url format method), parts of the query are stripped out.
http://www.example.more.example.com/something/display_details.aspx?fun=Y...
Ends up displaying as:
http://www.example.more.example.com/something/display_details.aspx?num=1...
Removing the following from link.module resolves it
Comment #13
dqd@virtualroberts: please use the given 'code' tags to post code in issue comments, I would like to ask you to edit your comment.
thanks for understanding, and thanks for the report but please be careful with providing info of removing code since some code interrelates to url validation, which is important for security like f.e. to prevent some server mailware with obfuscated code urls to procreate its damage.
Comment #14
virtualdrupal CreditAttribution: virtualdrupal commented@Digidog: done. Any thoughts on a better way of getting those urls to operate properly?
Comment #15
naeluh CreditAttribution: naeluh commentedHi I am having this issue also. In d7. Is there a duplicate thread for d7.
Comment #16
ohthehugemanatee CreditAttribution: ohthehugemanatee as a volunteer commentedI can't believe this issue still exists... but it got me on a D7 site today. Submitting the patch suggested here 7 years ago to see what breaks. At this point, there may be code out there that depends on $wrapper->url returning the display URL... let's see how the tests go.
Comment #17
DamienMcKennaThank you all for your efforts, but I'm sorry to say that the D6 version is no longer supported.