Problem/Motivation
Here's the Plan issue #1261120: Deprecate Tracker module in D10 and move to contrib in D11 which confirmed its removal from Drupal core
Steps to reproduce
Try to remove the tracker and see what happens.
Proposed resolution
Remaining tasks
Release notes snippet
Tracker has been deprecated from core in 9.5.0 and will be removed in 10.0.0. You should add a dependency on the contributed Activity Tracker module if you want to keep using this functionality.
| Comment | File | Size | Author |
|---|---|---|---|
| #50 | 3261452-nr-bot.txt | 90 bytes | needs-review-queue-bot |
Issue fork drupal-3261452
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
naveenvalechaComment #4
naveenvalechaTrying to remove the tracker module
Comment #7
naveenvalechaThe post-update hooks tests are failing because the DB dump used in those tests contains the references of the tracker module in the core.extension config & key-value store. Either those drupal 8 and drupal 9 post-update hooks and their corresponding tests should be removed from the Drupal 10 branch so that they do not run on the CI. Please advice.
Comment #8
andypostI think we need to fix the tests in separate issue ti unblock this one
Comment #9
andypostthe related may affect this tests
Comment #10
naveenvalechaPostponing this issue
Comment #11
larowlanI think the intention was that these would go to a handbook page with instructions for users, rather than a change notice
Comment #12
larowlanShould we split this into two issues - one for the deprecation in D9 (which can happen fairly fast) and one for the removal in D10 (which may take longer).
Don't want to postpone the deprecation if we can avoid it
Comment #13
larowlanOpened https://www.drupal.org/docs/core-modules-and-themes/deprecated-modules-a... for the lifecycle links
Comment #14
naveenvalecha#12,
Opened a new issue for deprecation of the module which is against 9.4.x https://www.drupal.org/project/drupal/issues/3261679
#13,
Added the details about the tracker module.
Edit: While preparing the patch, I found there's already a page for deprecated and obsolete modules https://www.drupal.org/about/core/policies/core-change-policies/deprecat... so going to use the existing one. Please confirm is the right one?
Comment #15
catchOn #7, the fix here will conflict with #3261486: Remove core updates added prior to 9.3.0 and adjust test coverage.
The way to resolve it (I think), will be to load the fixture database dumps into whichever Drupal version they were created with (i.e. if it's after that issue lands, then 9.3.0), uninstall tracker, then dump the fixtures back again.
Agreed with @larowlan it would be good to split this into separate deprecation and removal issues so the deprecation can land in 9.4.x asap - that can happen as soon as there's a release of the contrib module.
Comment #16
naveenvalechaAdded #3263793: Move tracker help topics to tracker module to remove the help topics of the tracker module from 9.4.x
Comment #17
catch#3204511: Deprecate tracker migration is an existing bug with the tracker migration, but I don't think needs to block this, could be resolved in the contrib module.
I just committed #3263793: Move tracker help topics to tracker module and backported to 9.4.x, opened an issue against the contrib module here: #3263793: Move tracker help topics to tracker module.
I think that means this is unpostponed, but tests still failing here.
Comment #18
quietone commentedComment #19
quietone commentedProgress. The last failure is Drupal\Tests\system\Functional\UpdateSystem\UpdatePathTestBaseFilledTest
Comment #20
quietone commentedWrong issue.
Comment #21
quietone commentedComment #23
spokjeComment #24
spokjeComment #25
spokjeComment #26
daffie commentedThe whole Tracker module gets removed from core.
A number (migrate) get changed, because the Tracker module is not there anymore.
All changes look good to me.
For me it is RTBC.
Comment #27
spokjeAdded release note snippet and updated CR.
Comment #28
spokjePostponing on #3291265: \Drupal\Tests\forum\Functional\ForumNodeAccessTest doesn't use tracker module
Weirdly that test enables the tracker module (unneeded), so I would expect the TestBot run to show that test complaining about the tracker module not being there.
That didn't happen. _shrug_
Comment #29
spokjeComment #30
spokjeTurns out (I must remember to read the meta-issue first before diving into these issues...) this is postponed on:
#3271124: Move all non migration Tracker tests to the module in preparation of removal
#3291265: \Drupal\Tests\forum\Functional\ForumNodeAccessTest doesn't use tracker module
Comment #31
spokjeBlocker #3291265: \Drupal\Tests\forum\Functional\ForumNodeAccessTest doesn't use tracker module landed.
Comment #32
spokjeRemaining blocker #3271124: Move all non migration Tracker tests to the module in preparation of removal landed.
Comment #33
spokjePostponed on #3291599: Ensure that tracker does not get special core treatment per Slack discussion here: https://drupal.slack.com/archives/C014CT1CN1M/p1655750184381089
Also needs manual testing when that blocker lands (see also Slack discussion)
Comment #34
spokjeComment #35
spokjeComment #37
xjmRemoving tag until this is ready. Thanks!
Comment #38
catchI think this is at the point where it can land once the 11.0.x branch is actually open.
Comment #39
quietone commentedChanging the parent to the removal meta.
Comment #40
gábor hojtsyUpdating title, tags and version number based on recent announcement at https://www.drupal.org/about/core/blog/new-drupal-core-branching-scheme-...
Comment #41
ressaThanks for cleaning up, and keeping Drupal lean. I found this issue while looking for a solution to a Tracker-related error during a Drupal 7 to Drupal 10 migration of Views:
The solution was to delete the Contextual filters "User posted or commented" field from the Tracker view (it could not be deleted).
Comment #48
andypostold MR needs rebase, I opened new to check other aproach instead of clean-up of dumps
Comment #49
andypostGot tests green with fixtures clean-up https://git.drupalcode.org/project/drupal/-/merge_requests/7358 (split into 3 commits)
Not possible to use obsolete stub here as there's configuration
tracker.settingsin the filled dump, so probably it should wait for fixtures updateComment #50
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #51
andypostReady to go
Comment #52
catchOverall looks good, but a couple of questions on the MR.
Comment #54
smustgrave commentedTook a look at the two comments but they appear to already be in getMissingPaths() seems correct based on d6 migration tests.
Rests looks good.
Comment #56
catchAhh thanks for checking properly, just the @todo was wrong then.
Committed/pushed to 11.x, thanks!
Comment #58
quietone commentedComment #60
quietone commentedUpdate version to the branch this applies to.