Problem/Motivation

Here's the Plan issue #1261120: Deprecate Tracker module in D10 and move to contrib in D11 which confirmed its removal from Drupal core

Steps to reproduce

Try to remove the tracker and see what happens.

Proposed resolution

Remaining tasks

Release notes snippet

Tracker has been deprecated from core in 9.5.0 and will be removed in 10.0.0. You should add a dependency on the contributed Activity Tracker module if you want to keep using this functionality.

Issue fork drupal-3261452

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

naveenvalecha created an issue. See original summary.

naveenvalecha’s picture

Status: Active » Needs review
StatusFileSize
new376 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 3261452-9.4.x-deprecate-tracker.patch, failed testing. View results

naveenvalecha’s picture

Version: 9.4.x-dev » 10.0.x-dev
Status: Needs work » Needs review
StatusFileSize
new93.59 KB

Trying to remove the tracker module

Status: Needs review » Needs work

The last submitted patch, 4: 3261452-10.0x-remove-tracker.patch, failed testing. View results

naveenvalecha’s picture

The post-update hooks tests are failing because the DB dump used in those tests contains the references of the tracker module in the core.extension config & key-value store. Either those drupal 8 and drupal 9 post-update hooks and their corresponding tests should be removed from the Drupal 10 branch so that they do not run on the CI. Please advice.

andypost’s picture

I think we need to fix the tests in separate issue ti unblock this one

andypost’s picture

the related may affect this tests

naveenvalecha’s picture

Title: Remove tracker module from core » [PP-?] Remove tracker module from core
Status: Needs work » Postponed

Postponing this issue

larowlan’s picture

+++ b/core/modules/tracker/tracker.info.yml
@@ -6,3 +6,5 @@ dependencies:
+lifecycle_link: 'https://www.drupal.org/node/3261453'

I think the intention was that these would go to a handbook page with instructions for users, rather than a change notice

larowlan’s picture

Should we split this into two issues - one for the deprecation in D9 (which can happen fairly fast) and one for the removal in D10 (which may take longer).

Don't want to postpone the deprecation if we can avoid it

larowlan’s picture

naveenvalecha’s picture

#12,
Opened a new issue for deprecation of the module which is against 9.4.x https://www.drupal.org/project/drupal/issues/3261679

#13,
Added the details about the tracker module.

Edit: While preparing the patch, I found there's already a page for deprecated and obsolete modules https://www.drupal.org/about/core/policies/core-change-policies/deprecat... so going to use the existing one. Please confirm is the right one?

catch’s picture

On #7, the fix here will conflict with #3261486: Remove core updates added prior to 9.3.0 and adjust test coverage.

The way to resolve it (I think), will be to load the fixture database dumps into whichever Drupal version they were created with (i.e. if it's after that issue lands, then 9.3.0), uninstall tracker, then dump the fixtures back again.

Agreed with @larowlan it would be good to split this into separate deprecation and removal issues so the deprecation can land in 9.4.x asap - that can happen as soon as there's a release of the contrib module.

naveenvalecha’s picture

Added #3263793: Move tracker help topics to tracker module to remove the help topics of the tracker module from 9.4.x

catch’s picture

Title: [PP-?] Remove tracker module from core » Remove tracker module from core
Status: Postponed » Needs work

#3204511: Deprecate tracker migration is an existing bug with the tracker migration, but I don't think needs to block this, could be resolved in the contrib module.

I just committed #3263793: Move tracker help topics to tracker module and backported to 9.4.x, opened an issue against the contrib module here: #3263793: Move tracker help topics to tracker module.

I think that means this is unpostponed, but tests still failing here.

quietone’s picture

Issue summary: View changes

Progress. The last failure is Drupal\Tests\system\Functional\UpdateSystem\UpdatePathTestBaseFilledTest

quietone’s picture

Issue summary: View changes

Wrong issue.

quietone’s picture

Issue tags: +Needs release note

Spokje made their first commit to this issue’s fork.

spokje’s picture

Status: Needs work » Needs review
spokje’s picture

Issue tags: -Needs release note
spokje’s picture

Issue tags: +Needs release note
daffie’s picture

Status: Needs review » Reviewed & tested by the community

The whole Tracker module gets removed from core.
A number (migrate) get changed, because the Tracker module is not there anymore.
All changes look good to me.
For me it is RTBC.

spokje’s picture

Issue summary: View changes
Issue tags: -Needs release note +9.5.0 release notes

Added release note snippet and updated CR.

spokje’s picture

Title: Remove tracker module from core » [PP-1] Remove tracker module from core
Related issues: +#3291265: \Drupal\Tests\forum\Functional\ForumNodeAccessTest doesn't use tracker module

Postponing on #3291265: \Drupal\Tests\forum\Functional\ForumNodeAccessTest doesn't use tracker module

Weirdly that test enables the tracker module (unneeded), so I would expect the TestBot run to show that test complaining about the tracker module not being there.

That didn't happen. _shrug_

spokje’s picture

Status: Reviewed & tested by the community » Postponed
spokje’s picture

Title: [PP-1] Remove tracker module from core » [PP-2] Remove tracker module from core
Related issues: +#3271124: Move all non migration Tracker tests to the module in preparation of removal
spokje’s picture

Title: [PP-2] Remove tracker module from core » [PP-1] Remove tracker module from core
spokje’s picture

Title: [PP-1] Remove tracker module from core » Remove tracker module from core
Assigned: Unassigned » spokje
Status: Postponed » Needs work
spokje’s picture

Title: Remove tracker module from core » [PP-1] Remove tracker module from core
Assigned: spokje » Unassigned
Status: Needs work » Postponed

Postponed on #3291599: Ensure that tracker does not get special core treatment per Slack discussion here: https://drupal.slack.com/archives/C014CT1CN1M/p1655750184381089
Also needs manual testing when that blocker lands (see also Slack discussion)

The main thing we need to do before removing them from 10.0.x is ensure that the composer façade naming for them is fixed, and have someone manually test EACH to confirm downloading the contrib module in D9 and installing it works SEAMLESSLY, and that it then does again if the rm -rf core/modules/foo

spokje’s picture

spokje’s picture

xjm’s picture

Issue tags: -10.0.0 release notes

Removing tag until this is ready. Thanks!

catch’s picture

Title: [PP-1] Remove tracker module from core » Remove tracker module from core
Version: 10.0.x-dev » 11.0.x-dev
Status: Postponed » Active

I think this is at the point where it can land once the 11.0.x branch is actually open.

quietone’s picture

gábor hojtsy’s picture

Title: Remove tracker module from core » [11.x] Remove tracker module from core
Version: 11.0.x-dev » 11.x-dev
Issue tags: +Major version only

Updating title, tags and version number based on recent announcement at https://www.drupal.org/about/core/blog/new-drupal-core-branching-scheme-...

ressa’s picture

Thanks for cleaning up, and keeping Drupal lean. I found this issue while looking for a solution to a Tracker-related error during a Drupal 7 to Drupal 10 migration of Views:

Source ID tracker: VIEW: tracker DISPLAY: default - The 'uid_touch' argument Plugin is missing and will be listed as broken.
Source ID tracker: VIEW: tracker DISPLAY: default - The field timestamp does not exist and has been removed from the fields configuration.

The solution was to delete the Contextual filters "User posted or commented" field from the Tracker view (it could not be deleted).

Spokje changed the visibility of the branch 3261452-remove-tracker-module to hidden.

Spokje changed the visibility of the branch drupal-3261452 to hidden.

Spokje changed the visibility of the branch 11.x to hidden.

andypost’s picture

Status: Active » Needs work

old MR needs rebase, I opened new to check other aproach instead of clean-up of dumps

andypost’s picture

Status: Needs work » Needs review

Got tests green with fixtures clean-up https://git.drupalcode.org/project/drupal/-/merge_requests/7358 (split into 3 commits)

Not possible to use obsolete stub here as there's configuration tracker.settings in the filled dump, so probably it should wait for fixtures update

needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new90 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

andypost’s picture

Status: Needs work » Needs review

Ready to go

catch’s picture

Overall looks good, but a couple of questions on the MR.

smustgrave changed the visibility of the branch 3261452-11.x-remove-tracker to hidden.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Took a look at the two comments but they appear to already be in getMissingPaths() seems correct based on d6 migration tests.

Rests looks good.

  • catch committed cae640d3 on 11.x
    Issue #3261452 by Spokje, andypost, naveenvalecha, quietone, smustgrave...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Ahh thanks for checking properly, just the @todo was wrong then.

Committed/pushed to 11.x, thanks!

quietone’s picture

Issue tags: -Needs manual testing

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone’s picture

Version: 11.x-dev » 11.0.x-dev

Update version to the branch this applies to.