Problem/Motivation

Core tests outside of Tracker module install the tracker module. These need to be modified to maintain test coverage and possible move of tests to Color.

$ git grep tracker | grep Test | grep -v core/modules/tracker | grep -v core/modules/migrate
core/modules/forum/tests/src/Functional/ForumNodeAccessTest.php:    'tracker',
core/modules/system/tests/src/Functional/UpdateSystem/UpdatePathTestBaseFilledTest.php:      'tracker',
core/modules/views/tests/src/Functional/Wizard/BasicTest.php:    $this->assertSession()->pageTextNotContains('tracker');

Steps to reproduce

Proposed resolution

Remaining tasks

Patch
Review
Commit

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 3271124-4.patch1.06 KBquietone
#2 3271124-2.patch497 bytesquietone

Comments

quietone created an issue. See original summary.

quietone’s picture

Status: Active » Needs review
StatusFileSize
new497 bytes

The test passes locally without tracker installed. Not sure why it is in the test but then I don't know forum module.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

Issue summary: View changes
StatusFileSize
new1.06 KB

Still to do is core/modules/views/tests/src/Functional/Wizard/BasicTest.php: $this->assertSession()->pageTextNotContains('tracker');.
I am not sure what it is supposed to be testing. Anyone?

spokje’s picture

Status: Needs review » Closed (duplicate)

Ok, a mea culpa here.

I didn't look at the META issue and opened up #3291265: \Drupal\Tests\forum\Functional\ForumNodeAccessTest doesn't use tracker module, which is basically patch #2.

That one reached RTBC, so I'm closing this as a duplicate. Sorry :/

I've opened #3291303: "Wierd" assertion in \Drupal\Tests\views\Functional\Wizard\BasicTest for the assertion on "tracker" in core/modules/views/tests/src/Functional/Wizard/BasicTest.php, which doesn't have anything to do with the tracker module in D9 AFAICT.

Leaves patch #4, where we removed tracker from UpdatePathTestBaseFilledTest.

We do that in the removal issue #3261452: [11.x] Remove tracker module from core, where we remove tracker from the core/modules/system/tests/fixtures/update/drupal-9.3.0.filled.standard.php.gz fixture.

So I think all the points in this issue are covered.
Again sorry for derailing this.

naveenvalecha’s picture