Problem/Motivation
In \Drupal\Tests\views\Functional\Wizard\BasicTest we have the following assertion:
// Make sure the listing page doesn't show disabled default views.
$this->assertSession()->pageTextNotContains('tracker');
AFAICT the tracker View was present in D7, not any more in D9.x.
So that text will never be present.
If I look at the comment, we seem to want to test the absence of disabled view in the overview page of Views.
AFAICT disabled Views _will_ be present on the overview page under the appropriately named head "Disabled".
So basically, in my tiny mind:
- We're looking for the absence of a string that will never be present.
- We're testing something that's not happening (any more).
Steps to reproduce
Proposed resolution
I say we just remove the whole assertion all together.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3291303
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3291303-wierd-assertion-in
changes, plain diff MR !2401
Comments
Comment #3
spokjeComment #4
daffie commentedLooks good to me.
Comment #6
catchCommitted/pushed to 10.1.x and cherry-picked through to 9.4.x, thanks!