Problem/Motivation

In \Drupal\Tests\views\Functional\Wizard\BasicTest we have the following assertion:

    // Make sure the listing page doesn't show disabled default views.
    $this->assertSession()->pageTextNotContains('tracker');

AFAICT the tracker View was present in D7, not any more in D9.x.
So that text will never be present.

If I look at the comment, we seem to want to test the absence of disabled view in the overview page of Views.
AFAICT disabled Views _will_ be present on the overview page under the appropriately named head "Disabled".

So basically, in my tiny mind:
- We're looking for the absence of a string that will never be present.
- We're testing something that's not happening (any more).

Steps to reproduce

Proposed resolution

I say we just remove the whole assertion all together.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3291303

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Spokje created an issue. See original summary.

spokje’s picture

Status: Active » Needs review
daffie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me.

  • catch committed f2639f9 on 10.0.x
    Issue #3291303 by Spokje: "Wierd" assertion in \Drupal\Tests\views\...
  • catch committed 7e58bc5 on 10.1.x
    Issue #3291303 by Spokje: "Wierd" assertion in \Drupal\Tests\views\...
  • catch committed d02c8ac on 9.4.x
    Issue #3291303 by Spokje: "Wierd" assertion in \Drupal\Tests\views\...
  • catch committed ef7c862 on 9.5.x
    Issue #3291303 by Spokje: "Wierd" assertion in \Drupal\Tests\views\...
catch’s picture

Version: 9.5.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x and cherry-picked through to 9.4.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.