When trying to translate simple_sitemap or simple_sitemap_type config entities through the UI, an access denied page is thrown.

CommentFileSizeAuthor
#4 make-new-configuration-entities-translatable-3238405-4.patch7.85 KBwalkingdexter

Comments

gbyte created an issue. See original summary.

  • gbyte committed 0157537 on 4.x 
    Issue #3238405 by gbyte: Make new configuration entities translatable
gbyte’s picture

gbyte
Location Berlin
commented
Assigned: gbyte » walkingdexter

Any chance you could look into this?

walkingdexter’s picture

walkingdexter commented
Status: Active » Needs review
StatusFileSize
new make-new-configuration-entities-translatable-3238405-4.patch7.85 KB

I have fixed some translation issues:

  • New config entities is now translatable. There is no need to use t().
  • Plugin data is already translatable. There is no need to use t().

There is only one point to discuss. In accordance with #2973475: Translations of taxonomy vocabulary not shown on admin overview and #2959852: Add explanation about certain pages showing English in non-English sites config entities are displayed on admin pages in their source language. In our case, this only affects the list of sitemaps and the list of sitemap types. Do we need translations in these lists? Or should the standard behavior be used (node types, taxonomy vocabularies and etc.)?

  • gbyte committed 0fa4b1d on 4.x authored by WalkingDexter 
    Issue #3238405 by WalkingDexter, gbyte: Make new configuration entities...
gbyte’s picture

gbyte
Location Berlin
commented
Status: Needs review » Fixed

@WalkingDexter I feel like the translation of these entity labels is kind of redundant if it doesn't show it in the UI, as they are only displayed in the backend. On the other hand, if core does it this way, maybe so should we. I'll let you decide, feel free to make any changes to this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.