Make new configuration entities translatable [#3238405]

When trying to translate simple_sitemap or simple_sitemap_type config entities through the UI, an access denied page is thrown.

Comment	File	Size	Author
#4	make-new-configuration-entities-translatable-3238405-4.patch	7.85 KB	WalkingDexter
#4	4.x: PHP 8.0 & MySQL 5.7, D9.2.0 28 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

22 September 2021 at 00:25

gbyte created an issue. See original summary.

Comment #2

26 September 2021 at 19:45

gbyte committed 0157537 on 4.x

Issue #3238405 by gbyte: Make new configuration entities translatable

Comment #3

gbyte CreditAttribution: gbyte as a volunteer and at gbyte commented 2 October 2021 at 10:50

Assigned:

gbyte

» WalkingDexter

Any chance you could look into this?

Comment #4

WalkingDexter CreditAttribution: WalkingDexter at Initlab commented 15 October 2021 at 14:43

Status:

Active

» Needs review

File	Size
make-new-configuration-entities-translatable-3238405-4.patch	7.85 KB
4.x: PHP 8.0 & MySQL 5.7, D9.2.0 28 pass

I have fixed some translation issues:

New config entities is now translatable. There is no need to use t().
Plugin data is already translatable. There is no need to use t().

There is only one point to discuss. In accordance with #2973475: Translations of taxonomy vocabulary not shown on admin overview and #2959852: Add explanation about certain pages showing English in non-English sites config entities are displayed on admin pages in their source language. In our case, this only affects the list of sitemaps and the list of sitemap types. Do we need translations in these lists? Or should the standard behavior be used (node types, taxonomy vocabularies and etc.)?

Comment #5

15 October 2021 at 15:38

gbyte committed 0fa4b1d on 4.x authored by WalkingDexter

Issue #3238405 by WalkingDexter, gbyte: Make new configuration entities...

Comment #6

gbyte CreditAttribution: gbyte as a volunteer and at gbyte commented 15 October 2021 at 15:53

Status:

Needs review

» Fixed

@WalkingDexter I feel like the translation of these entity labels is kind of redundant if it doesn't show it in the UI, as they are only displayed in the backend. On the other hand, if core does it this way, maybe so should we. I'll let you decide, feel free to make any changes to this.