Problem/Motivation

In the latest Drupal core update, Drupal\ckeditor\CKEditorPluginBase::getModulePath has method updates which Drupal\token_filter\Plugin\CKEditorPlugin\TokenBrowser must implement.

The following error is received on any attempt to load Ckeditor with the Token Filter.

PHP Fatal error:  Declaration of Drupal\token_filter\Plugin\CKEditorPlugin\TokenBrowser::getModulePath() must be compatible with Drupal\ckeditor\CKEditorPluginBase::getModulePath(string $module_name):

Steps to reproduce

Update Drupal to >= 9.2.6 and enabled Token Filter then attempt to load a page with CkEditor. You will encounter a fatal error.

Proposed resolution

Patch to follow

CommentFileSizeAuthor
#2 token_filter-ckeditor_fatal_error-3236440-2.patch1.37 KBrickyoh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rickyoh created an issue. See original summary.

rickyoh’s picture

rickyoh CreditAttribution: rickyoh at Black Antelope commented
FileSize
token_filter-ckeditor_fatal_error-3236440-2.patch1.37 KB

Patch to resolve compatibility issue with extending CKEditorPluginBase

mohit.bansal623’s picture

mohit.bansal623 CreditAttribution: mohit.bansal623 as a volunteer and at Axelerant commented
Status: Active » Needs review

@rickyoh, Is there anything left in this issue? I can see the patch uploaded.

  • rickyoh authored 4f02bdb on 8.x-1.x 
    Issue #3236440 by rickyoh: Fatal Error with CkEditor in Drupal >= 9.2.6
darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
CreditAttribution: darvanen commented
Assigned: rickyoh » Unassigned
Status: Needs review » Fixed

Very straight-forward, thank you for this.

Reviewed, committed and pushed, release on the way.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

thanks for this fix, noticed it also