Attached patch fixes a few minor bugs in CCK. I would also be happy if a native speaker could review the content.rules.inc file. Some of the sentence makes me headaches and I'm not sure if this is my English or the source strings are simply not the best to understand contextless...

Examples:
Content containing changes.
Content not containing changes.

Wouldn't it sounds better or something else... not sure?
Content does contain any changes.
Content does not contain any changes.

As I'm not a native speaker I'm not sure...

I also like to know what value is inside the

@node<code> variable (see strings in attached patch) as this strings are unbelievable difficult to translate today without the context. Not sure if it's the node number or page/story or maybe the title of the node...

I would also be happy if someone could rewrite <code>Select the machine-name of the field to look at.

or simply extend the sentence to be more self explaining. I'm not sure what we are looking for in the fields...

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yched’s picture

I committed the non-'rules integration' part. I'll let fago decide about those.
Thx.

hass’s picture

Component: General » Rules Integration

Moving to rules for fago

fago’s picture

>@node variable (see strings in attached patch) as this strings are unbelievable difficult to translate today without the context. Not sure if it's the node number or page/story or maybe the title of the node...

It's neither. It's replaced with the name of the variable, which is configured to be passed to the condition or action for this argument. Suppose the user uses the "Populate a field action", configures it to use the "updated content" and the field "field_description", then the label callback will auto-generate the default label:

Populate updated content's field field_rules

-> so @node is replaced by "updated content".

>Content containing changes.
>Wouldn't it sounds better or something else... not sure?
>Content does contain any changes.

Hm, obviously I'm no native speaker either. However "Content does contain any changes." does not fit - as this describes the argument, which should be "Content, which doesn't contain changes" or "Content not containing changes" which should be a valid short form for it?
Look at the attached screenshot of the condition configuration page to see how it's used.
Then as it's just a label for the argument, there should be no point at the end.

@ field %field
It's not possible to use the % replacements, as the labels may not contain html. However yes, it's better readable this way, so I've improved it to field '@field'. (as it's not possible to use " there too.. :/)

@has a value:
I've left it to "has value", as it's about a specific value. I know it's not optimal this way, but I think it fits for conditions / actions. As their labels are no complete sentences, but just some words describing them - which won't always be correct language.

So I've overhauled your improvements and committed them. Thanks for helping getting the language better!

fago’s picture

Status: Needs review » Fixed
hass’s picture

@fago: You also speak German... try to translate this strings... if you don't know if this @node is a number or a title the sentence may sound very strange...

Please translate your strings to German... :-)

hass’s picture

"@node's field %field has been changed."
"@node's field %field has a value."
"Populate @node's field %field."

You may take a look to the DE translation files if this is correctly translated.

fago’s picture

hm, indeed that's really hard as German is more complicated than English. But let me try...

Feld '@field' in @node wurde verändert
Feld '@field' in @nod hat Wert
Setze Feld '@field' in @node

->
Feld 'field_description' in aktualisierter Beitrag wurde verändert

Again, yes it's not correct language, it sounds somehow mechanic, but it's understandable. Rules is not a NLG (natural language generator) and won't be, so it doesn't generate correct sentences. The idea is to generate *better* default labels, so it's clear what the configured action / condition does without having to go to its configuration page. There is still the possibility for users to fix up these labels.

hass’s picture

That's why I please you to build easier translatable strings... it shouldn't be "mechanic". Other languages may have more difficulties and a generic placeholder like @url or @node is not understandable to translators. @node-id or @node-title are better for e.g. Aside I have not yet been able to understand/follow the code - where you set the variables for the @node placeholder. :-)

fago’s picture

>Aside I have not yet been able to understand/follow the code - where you set the variables for the @node placeholder. :-)

Don't try that, you would have to follow most of the module's code ;) Better just install rules and try it, then you'll understand.

>it shouldn't be "mechanic".
It are just labels for conditions and actions. Together with some conjunctions of rules like OR, AND or NOT it's like a programming language, but a bit better readable. But still - don't expect it to be usual natural language. As you see, it won't.

>Other languages may have more difficulties and a generic placeholder like @url or @node is not understandable to translators.
I know it might be even more difficult for other languages. If it's too difficult, there is still the option to leave this part untranslated...

Anyway I do my best to make the label easy to understand and translate and your help is greatly appreciated :)

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.