Problem/Motivation

Supported Versions

Currently Supported Versions

https://www.php.net/supported-versions.php

PHP Currently Supported Versions

Please, list any PHP 8.0 or PHP 8.1 issues in this issue
Test building and installing Varbase 9.0.x-dev and 9.1.0.x under PHP 8.0 / PHP 8.1 and MySQL 8

composer create-project vardot/varbase-project:9.0.x-dev PROJECT_DIR_NAME --stability dev --no-interaction

or 

composer create-project vardot/varbase-project:9.1.x-dev PROJECT_DIR_NAME --stability dev --no-interaction

Proposed resolution

Have support for PHP 8.0 and PHP 8.1
Have support for MySQL 8
Add rule for PHP 8 promotion constructor in PSR-12

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ✅ Automated unit/functional testing coverage
    Varbase 9.1.x CircleCI Build Passing

    Varbase 9.1.x

    Varbase 9.0.x CircleCI Build Passing

    Varbase 9.0.x

  • ✅ Developer Documentation support on feature change/addition
    Changed
    Requirements

    PHP 7.4 or higher. PHP 8.0 is recommended.

    Changed
    Varbase Project Template for Platform.sh

    The runtime the application uses
    type: 'php:8.0'

    Changed
    Varbase Project Template for Lando

    Lando PHP config
    php: '8.0'

  • ➖ User Guide Documentation support on feature change/addition
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Release varbase-9.0.6

Varbase update type:

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3217859: Support PHP8.1 and MySQL 8 for Varbase ~9.0 and all used components with automated testing
CommentFileSizeAuthor
#73 Screenshot 2022-04-26 at 12-07-11 PHP Supported Versions.png117.34 KBrajab natshah
#68 PHP-2022-03-07---Supported-Vrsions----Currently-Supported-Versions.png156.95 KBrajab natshah
#11 PHP_ Supported Versions 8-1.png214.09 KBrajab natshah

Comments

RajabNatshah created an issue. See original summary.

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3218290: Use phpstan to test PHP 8 compatibility of PHP code even on PHP 7
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3213517: Fix PHP 7.4 + warnings = cannot add to entity queues
rajab natshah’s picture

rajab natshah
he/him
commented

At this point of time

On running the following composer command under PHP 8.0

composer create-project vardot/varbase-project:9.0.x-dev PROJECT_DIR_NAME --stability dev --no-interaction

Facing the following problem on Resolving dependencies with PHP 8.0

Resolving dependencies through SAT

Dependency resolution completed in 0.446 seconds
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - abraham/twitteroauth[1.2.0, v1.x-dev] require php ^7.2 || ^7.3 || ^7.4 -> your php version (8.0.7) does not satisfy that requirement.
    - abraham/twitteroauth[1.0.0, 1.0.1] require php ^5.6 || ^7.0 || ^7.1 || ^7.2 -> your php version (8.0.7) does not satisfy that requirement.
    - abraham/twitteroauth 1.1.0 requires php ^7.2 || ^7.3 -> your php version (8.0.7) does not satisfy that requirement.
    - drupal/varbase_auth dev-9.0.x requires drupal/social_auth_twitter 2.x-dev -> satisfiable by drupal/social_auth_twitter[2.x-dev (alias of dev-2.x)].
    - drupal/varbase_auth 9.0.x-dev is an alias of drupal/varbase_auth dev-9.0.x and thus requires it to be installed too.
    - drupal/social_auth_twitter 2.x-dev is an alias of drupal/social_auth_twitter dev-2.x and thus requires it to be installed too.
    - vardot/varbase 9.0.x-dev requires drupal/varbase_auth 9.0.x-dev -> satisfiable by drupal/varbase_auth[9.0.x-dev (alias of dev-9.0.x)].
    - drupal/social_auth_twitter dev-2.x requires abraham/twitteroauth ^1.0 -> satisfiable by abraham/twitteroauth[1.0.0, 1.0.1, 1.1.0, 1.2.0, v1.x-dev].
    - Root composer.json requires vardot/varbase 9.0.x-dev -> satisfiable by vardot/varbase[9.0.x-dev].
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3221179: Compatibility with Drupal 9.2
rajab natshah’s picture

rajab natshah
he/him
commented
Issue tags: +varbase-backlog
rajab natshah’s picture

rajab natshah
he/him
commented
Issue tags: -varbase-backlog
Related issues: +#3222209: Compatibility with PHP 8
mhawwari’s picture

mhawwari commented

PHP 7.4 is now under security support only
https://www.php.net/supported-versions.php

And the library abraham/twitteroauth now support PHP 8.1

rajab natshah’s picture

rajab natshah
he/him
commented

Thanks, Hawwari for following up

A full testing round for building and installing Varbase 9.0.x
composer create-project Vardot/varbase-project:9.0.x-dev PROJECT_DIR_NAME --no-dev --no-interaction
and Varbase 9.1.0.x
composer create-project Vardot/varbase-project:9.1.x-dev PROJECT_DIR_NAME --no-dev --no-interaction

Plus the automated functional testing

Changed that in my fork
https://github.com/Natshah/varbase/blob/9.0.x/.circleci/config.yml

With the automated testing running now .. on the 9.0.x branch
https://app.circleci.com/pipelines/github/Natshah/varbase/208/workflows/...

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
StatusFileSize
new PHP_ Supported Versions 8-1.png214.09 KB
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
mhawwari’s picture

mhawwari commented
Related issues: +#3253991: Update abraham/twitteroauth to use ^3.0 to support PHP8.0 and later
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3253718: Fix PHP 8.1 test fails
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3203843: PHP 8 compatibility, +#3239517: Emails get sent out as raw HTML on PHP 8 on Acquia - Send email as HTML - EmailWebformHandler.php, +#3247344: PHP 8.0 compatibility
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: -#3247344: PHP 8.0 compatibility +#3229774: D9 & PHP 8.0.3 Deprecated: Required parameter $context follows optional parameter $import_uri
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3236789: Drupal\Core\Controller\TitleResolver::getTitle() can result in PHP 8.1 deprecation notices due to NULL being set as placeholder values
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3249372: PHP 8.1: Deprecated function: Return type of Drupal\entity\QueryAccess\ConditionGroup::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used...
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3251429: mb_strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3241265: user_user_view() triggers a deprecation in PHP 8.1
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3249801: head failing, +#3252259: Deprecated function: parse_str(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\redirect\EventSubscriber\RedirectRequestSubscriber->onKernelRequestCheckRedirect
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3253738: PHP 8.1 Deprecations
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3253545: Drupal 9.3 fixes and PHP 8.1
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3254801: Fix "Returning bool from comparison function is deprecated"
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3254225: Deprecated: Required parameter $formatter in PHP 8.0
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3254772: Attachments and message parameters removed by mail alter hook
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3252279: Update dependencies for PHP 8.1 support
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues:
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3101368: Let tests fail on deprecation notices
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3239257: PHP 8 Compatibility
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

Add rule for PHP 8 promotion constructor in PSR-12

rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3230707: 5.x broken on php 8 due to incompatibility with lcobucci/jwt v4 via league/oauth2-server ^8.2
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: -#3254225: Deprecated: Required parameter $formatter in PHP 8.0
rajab natshah’s picture

rajab natshah
he/him
commented
rajab natshah’s picture

rajab natshah
he/him
commented
Title: Support PHP8.0 for Varbase ~9.0 and all used components with automated testing » Support PHP8.0 and MySQL 8 for Varbase ~9.0 and all used components with automated testing
Issue summary: View changes
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: rajab natshah » Unassigned
rajab natshah’s picture

rajab natshah
he/him
commented
Issue tags: +PHP 8.0, +PHP 8.1, +MySQL 8
oliver huynh’s picture

oliver huynh commented
Assigned: Unassigned » oliver huynh
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: oliver huynh » Unassigned
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3261492: In php 8.1 the explode function throws a notice when default value is null

#3261492: In php 8.1 the explode function throws a notice when default value is null

rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3261487: In php 8.1 the explode function throws a notice when default value is null

#3261487: In php 8.1 the explode function throws a notice when default value is null

rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3253220: Deprecated function: Return type of Drupal\crop\Entity\CropType::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3261472: In php 8.1 the explode in menu_admin_per_menu_form_node_form_alter throws a notice when default value is null, +#3262521: Deprecated function: strpos():...line 20...WebformShareHelper.php, +#3261505: In php 8.1 the explode function throws a notice when default value is null
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3263413: Warning: Undefined array key "library" in Drupal\charts\Element\BaseSettings::processSettings()...line 125...\BaseSettings.php
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3262975: foreach() argument must be of type array|object, null given in Drupal\search_api\Plugin\search_api\processor\IgnoreCharacters
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3217493: PHP 8 incompatibility on call_user_func_array()
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3262401: Deprecated function : Return type of Drupal\linkit\Suggestion\SimpleSuggestion::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize()
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3261999: InlineEntityFormSimple can throw a warning (PHP8) that fails any FunctionalTest with an empty inline entity form.
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3259764: [PHP8.1] Deprecation notice when running outdated config: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues:
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3256142: Deprecated function: Implicit conversion from float-string
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3264919: Fatal error from 6.1.2 to 6.1.3 with PHP 8.0-php-fpm, +#3258427: TypeError: preg_match_all(): Argument #2 ($subject) must be of type string, array given in preg_match_all() , +#3157531: Undefined offset: 0 in hook_hide_publish_on_field()
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3263406: stristr(): Passing null to parameter #1 ($haystack) of type string is deprecated in Drupal\amp\Service\AMPService::isDevPage(), +#3091319: Notice: Undefined index: #type in _ds_field_ui_table_layouts()
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3259596: token does not works any more...
rajab natshah’s picture

rajab natshah
he/him
commented

TEMP fix for #3253991: Update abraham/twitteroauth to use ^3.0 to support PHP8.0 and later
Add the following in the root composer.json for projects:
"abraham/twitteroauth": "3.3.0 as 1.2.0",

To test building Varbase 9.0.x under PHP 8.0 or PHP 8.1

git clone https://github.com/Vardot/varbase-project.git myproject
cd myproject
sudo rm -rf .git/
composer require "abraham/twitteroauth:3.3.0 as 1.2.0" --ignore-platform-reqs --no-install --no-update --ignore-platform-reqs
composer install
rajab natshah’s picture

rajab natshah
he/him
commented

Social Aauth Twitter 8.x-2.0-alpha4 was released 22 Feb 2022 by: Abdullah Yassin

rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3265826: Update Social Aauth Twitter module from 2.x-dev to ~2.0 and remove committed patches

#3265826: Update Social Aauth Twitter module from 2.x-dev to ~2.0 and remove committed patches

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
rajab natshah’s picture

rajab natshah
he/him
commented

Now remove "abraham/twitteroauth": "3.3.0 as 1.2.0", from the root composer.json in projects under PHP 8.0
Then update Varbase Auth to 9.0.2

rajab natshah’s picture

rajab natshah
he/him
commented
Title: Support PHP8.0 and MySQL 8 for Varbase ~9.0 and all used components with automated testing » Support PHP8.1 and MySQL 8 for Varbase ~9.0 and all used components with automated testing

  • Rajab Natshah committed e00b7d2 on 9.1.x 
    Issue #3217859: Support PHP8.1 and MySQL 8 for Varbase ~9.0 and all used...

  • Rajab Natshah committed 12ae133 on 9.0.x 
    Issue #3217859: Support PHP8.1 and MySQL 8 for Varbase ~9.0 and all used...
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: Unassigned » mohammed j. razem
Issue summary: View changes
Status: Active » Needs review
Issue tags: +varbase-9.0.6

✅ Automated unit/functional testing coverage

Varbase 9.1.x CircleCI Build Passing

Varbase 9.1.x

Varbase 9.0.x CircleCI Build Passing

Varbase 9.0.x

A small number of warnings, after a full round of testing under PHP 8.0 and PHP 8.1
The Functional Automated Acceptance Testing is passing with Green builds.
Having one more round of testing, and fixes to ensure no warnings, notices, or fatal errors.

rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3266406: PHP 8.1 error with Views integration: Argument #1 ($first_row_tokens) must be of type array, null given

#3266406: PHP 8.1 error with Views integration: Argument #1 ($first_row_tokens) must be of type array, null given

rajab natshah’s picture

rajab natshah
he/him
commented
Related issues:

Inline Entity Form 8.x-1.0-rc10 was released 3 Mar 2022 by geek-merlin
https://www.drupal.org/project/inline_entity_form/releases/8.x-1.0-rc10
#3217493: PHP 8 incompatibility on call_user_func_array()

rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3265909: Warning with PHP 8.1: Deprecated function: trim()

Blazy 8.x-2.8 was released 6 Mar 2022 by: gausarts
https://www.drupal.org/project/blazy/releases/8.x-2.8

#3265909: Warning with PHP 8.1: Deprecated function: trim()

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
Related issues: +#3268094: PHP 8.1 deprecated functions + General fix
StatusFileSize
new PHP-2022-03-07---Supported-Vrsions----Currently-Supported-Versions.png156.95 KB

#3268094: PHP 8.1 deprecated functions + General fix

rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3265567: PHP8 undefined array key "description"

Committed, but not released yet.
#3265567: PHP8 undefined array key "description"

rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3266417: PHP 8.1 error with Metatag Trimming Options: Argument #3 ($offset) must be contained in argument #1 ($haystack) in strpos()

#3266417: PHP 8.1 error with Metatag Trimming Options: Argument #3 ($offset) must be contained in argument #1 ($haystack) in strpos()

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
Status: Needs review » Fixed

Closing this issue
Farther PHP 8.0 or PHP 8.1 issues could be reported to be fixed on used cases.

✅ Automated unit/functional testing coverage

Varbase 9.1.x CircleCI Build Passing

Varbase 9.1.x

Varbase 9.0.x CircleCI Build Passing

Varbase 9.0.x

A small number of warnings, after a full round of testing under PHP 8.0 and PHP 8.1
The Functional Automated Acceptance Testing is passing with Green builds.
Having one more round of testing, and fixes to ensure no warnings, notices, or fatal errors.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
StatusFileSize
new Screenshot 2022-04-26 at 12-07-11 PHP Supported Versions.png117.34 KB
rajab natshah’s picture

rajab natshah
he/him
commented

✅ Released varbase-9.0.6

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

✅ Developer Documentation support on feature change/addition

Changed
Requirements

PHP 7.4 or higher. PHP 8.0 is recommended.

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
rajab natshah’s picture

rajab natshah
he/him
commented

✅ Developer Documentation support on feature change/addition

Changed
Requirements

PHP 7.4 or higher. PHP 8.0 is recommended.

Changed
Varbase Project Template for Platform.sh

The runtime the application uses
type: 'php:8.0'

Changed
Varbase Project Template for Lando

Lando PHP config
php: '8.0'

paskainos’s picture

paskainos commented
Related issues: +#3258816: Fix [PHP 8.1] Deprecated function: strpos(): Passing null to parameter #1

Fresh install of Varbase 9.0.6 on PHP 8.1.5 with Varbase Style guide selected to be installed throws Deprecated function: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in Drupal\styleguide\Theme\StyleguideThemeNegotiator->applies() (line 60 of ... ~/modules/contrib/styleguide/src/Theme/StyleguideThemeNegotiator.php) on 'welcome' (home) page, which is addressed in #3258816: Fix [PHP 8.1] Deprecated function: strpos(): Passing null to parameter #1.

rajab natshah’s picture

rajab natshah
he/him
commented

Thank you Chris Hinkley (paskainos) for reporting :)

Fixed in #3277617: Fix Style Guide issue on [PHP 8.1] Deprecated function: strpos(): Passing null to parameter
Released Varbase Style Guide 9.0.4
https://www.drupal.org/project/varbase_styleguide/releases/9.0.3

rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3272720: hash(): Passing null to parameter #2 ($data) of type string is deprecated in generateFieldTableName

#3272720: hash(): Passing null to parameter #2 ($data) of type string is deprecated in generateFieldTableName