The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Let's add a drupalci.yml that fails the build if deprecated code is used. That way we can guarantee that Entity API is D9 ready.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 3101368-8-use-default-drupalci-yml.patch | 813 bytes | tr |
| #3 | 3101368-3-fail-on-deprecation.patch | 2.14 KB | bojanz |
| #2 | 3101368-2-fail-on-deprecation.patch | 1.76 KB | bojanz |
Comments
Comment #2
bojanz commentedLet's try this.
Comment #3
bojanz commentedSo close.
Comment #5
bojanz commentedCommitted. I'll remove DeleteMultipleFormTest in a followup commit (it's not testing anything).
Comment #7
tr commentedPlease re-think this decision. Because Drupal is now introducing new API methods in minor point releases and NOT backporting these to other currently-supported versions of core, there will always be deprecated methods that can't be fixed without breaking in some supported versions of core. That means that the Entity API tests will ALWAYS be failing.
See https://www.drupal.org/node/626176/qa - the 8.x-1.x branch tests have been failing for years because of this. That means contributed patches fail (actually, the tests don't even get triggered because of the branch fails) and that means that we don't see NEW fails because they are hidden by all the OLD deprecation failures. This defeats the whole purpose of having DrupalCI and having testing.
I suggest removing the drupalci.yml and letting DrupalCI run with the default configuration.
Comment #8
tr commentedComment #10
tr commentedThe test bot didn't actually pick up on the deleted drupalci.yml - it used the one currently in the Entity API repository instead. I have to commit this change to make the test bot test with the default drupalci.yml.
Because we can't do much without passing tests, and because I've had no feedback on this and related issues for more than a month, I'm just going to go ahead and commit the patch in #8. If it breaks things I can always revert it.
Comment #12
tr commentedThat fixed the 8.x-1.x tests, as you can see at https://www.drupal.org/node/626176/qa
I will be leaving this commit in.
Now we can address the PHP 8.1 failures.