Problem/Motivation

assertFileNotExists() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertFileDoesNotExist() instead.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#11 interdiff_10-11.txt52.13 KBSpokje
#11 3217706-11.patch58.51 KBSpokje
#10 3217706-10.patch58.41 KBSpokje
#10 reroll_diff_6-10.txt1.87 KBSpokje
#6 3217706-6.patch58.69 KBguilhermevp
#2 3217706.patch58.78 KBlongwave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mondrake created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Active » Needs review
FileSize
3217706.patch58.78 KB
mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Needs review » Reviewed & tested by the community

If the PHP 7.3 test turns back green, this is RTBC because it would mean it runs on PHPUnit8. Deprecation silencer removed and all conversions done.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Parent issue: » #3217904: [meta] Support PHPUnit 10 in Drupal 11
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll
guilhermevp’s picture

guilhermevp CreditAttribution: guilhermevp at CI&T commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
3217706-6.patch58.69 KB

re-rolled patch, please review.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Needs work
mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Needs work » Postponed

there’s a race condition, let’s go one issue at the time

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Postponed » Needs work
Issue tags: +Needs reroll

This can go in now.

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
reroll_diff_6-10.txt1.87 KB
3217706-10.patch58.41 KB

Rerolled

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented
FileSize
3217706-11.patch58.51 KB
interdiff_10-11.txt52.13 KB

Well...that's not going to work...

Let's try this one.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Needs review » Reviewed & tested by the community

  • catch committed 116ebd1 on 9.3.x 
    Issue #3217706 by Spokje, longwave, guilhermevp, mondrake: Replace...

  • catch committed 11f9e80 on 9.2.x 
    Issue #3217706 by Spokje, longwave, guilhermevp, mondrake: Replace...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.3.x, also removed the deprecation suppression removal and GenerateThemeTest hunks and committed to 9.2.x too.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.