Problem/Motivation

assertFileNotExists() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertFileDoesNotExist() instead.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#11 interdiff_10-11.txt52.13 KBspokje
#11 3217706-11.patch58.51 KBspokje
#10 3217706-10.patch58.41 KBspokje
#10 reroll_diff_6-10.txt1.87 KBspokje
#6 3217706-6.patch58.69 KBguilhermevp
#2 3217706.patch58.78 KBlongwave

Comments

mondrake created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 3217706.patch58.78 KB
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community

If the PHP 7.3 test turns back green, this is RTBC because it would mean it runs on PHPUnit8. Deprecation silencer removed and all conversions done.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Parent issue: » #3217904: [meta] Support PHPUnit 10 in Drupal 11
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll
guilhermevp’s picture

guilhermevp commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 3217706-6.patch58.69 KB

re-rolled patch, please review.

quietone’s picture

quietone commented
Status: Needs review » Needs work
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Postponed

there’s a race condition, let’s go one issue at the time

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Postponed » Needs work
Issue tags: +Needs reroll

This can go in now.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new reroll_diff_6-10.txt1.87 KB
new 3217706-10.patch58.41 KB

Rerolled

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3217706-11.patch58.51 KB
new interdiff_10-11.txt52.13 KB

Well...that's not going to work...

Let's try this one.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community

  • catch committed 116ebd1 on 9.3.x 
    Issue #3217706 by Spokje, longwave, guilhermevp, mondrake: Replace...

  • catch committed 11f9e80 on 9.2.x 
    Issue #3217706 by Spokje, longwave, guilhermevp, mondrake: Replace...
catch’s picture

catch
he/him
Primary language English
commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.3.x, also removed the deprecation suppression removal and GenerateThemeTest hunks and committed to 9.2.x too.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.