The D7 codebase code could use a little cleanup.

CommentFileSizeAuthor
#12 metatag-n3213283-12.patch161.8 KBDamienMcKenna
#12 metatag-n3213283-12.interdiff.txt9.79 KBDamienMcKenna
#11 metatag-n3213283-11.interdiff.txt599 bytesDamienMcKenna
#11 metatag-n3213283-11.patch155.45 KBDamienMcKenna
#10 metatag-n3213283-10.patch155.45 KBDamienMcKenna
#10 metatag-n3213283-10.interdiff.txt26.02 KBDamienMcKenna
#9 metatag-n3213283-9.interdiff.txt80.02 KBDamienMcKenna
#9 metatag-n3213283-9.patch140.88 KBDamienMcKenna
#8 metatag-n3213283-8.patch61.16 KBDamienMcKenna
#8 metatag-n3213283-8.interdiff.txt14.97 KBDamienMcKenna
#7 metatag-n3213283-7.patch48.21 KBDamienMcKenna
#7 metatag-n3213283-7.interdiff.txt434 bytesDamienMcKenna
#5 metatag-n3213283-5.patch48.21 KBDamienMcKenna
#5 metatag-n3213283-5.interdiff.txt24.51 KBDamienMcKenna
#4 metatag-n3213283-4.patch30.18 KBDamienMcKenna
#4 metatag-n3213283-4.interdiff.txt9.93 KBDamienMcKenna
#3 metatag-n3213283-3.patch22.15 KBDamienMcKenna
#3 metatag-n3213283-3.interdiff.txt12.15 KBDamienMcKenna
#2 metatag-n3213283-2.patch10 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Needs review
FileSize
metatag-n3213283-2.patch10 KB

WIP.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
metatag-n3213283-3.interdiff.txt12.15 KB
metatag-n3213283-3.patch22.15 KB

Further WIP.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
metatag-n3213283-4.interdiff.txt9.93 KB
metatag-n3213283-4.patch30.18 KB

More WIP.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
metatag-n3213283-5.interdiff.txt24.51 KB
metatag-n3213283-5.patch48.21 KB

Further work.

Status: Needs review » Needs work

The last submitted patch, 5: metatag-n3213283-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
metatag-n3213283-7.interdiff.txt434 bytes
metatag-n3213283-7.patch48.21 KB

Whoops.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
metatag-n3213283-8.interdiff.txt14.97 KB
metatag-n3213283-8.patch61.16 KB

Further improvements to the files in the top directory.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
metatag-n3213283-9.patch140.88 KB
metatag-n3213283-9.interdiff.txt80.02 KB

Extensive list of changes by phpcbf, with manual review & improvements.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
metatag-n3213283-10.interdiff.txt26.02 KB
metatag-n3213283-10.patch155.45 KB

Further changes.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
metatag-n3213283-11.patch155.45 KB
metatag-n3213283-11.interdiff.txt599 bytes

Doh.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
metatag-n3213283-12.interdiff.txt9.79 KB
metatag-n3213283-12.patch161.8 KB

I think this will be the last changes.

  • DamienMcKenna committed 886b64f on 7.x-1.x 
    Issue #3213283 by DamienMcKenna: Coding standards improvements.
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.