Add "raw" token option for nodereference titles [#319131]

Comment	File	Size	Author
#6	cck-nodereference-raw-token-V3.patch	1.49 KB	Moonshine
#3	cck-nodereference-raw-token-V2.patch	1.38 KB	Moonshine
	cck-nodereference-raw-token.patch	1.54 KB	Moonshine

Comment #1

Woodside CreditAttribution: Woodside commented 20 October 2008 at 16:48

Works well for me, thanks!

Log in or register to post comments

Comment #2

yched CreditAttribution: yched commented 20 October 2008 at 17:00

Problem with these kind of tokens is that they add a node_load for each token replacement, even if that specific token is not involved...

Log in or register to post comments

Comment #3

Moonshine CreditAttribution: Moonshine commented 20 October 2008 at 18:19

File	Size
cck-nodereference-raw-token-V2.patch	1.38 KB

Ahh! I was assuming the node was already loaded & cached from the building of $item['view']. Instead it looks like another function is used _nodereference_titles() and it has it's own static cache. :)

I think this should do the trick... It's just really helpful for building out nice parented path aliases.

Log in or register to post comments

Comment #4

Moonshine CreditAttribution: Moonshine commented 20 October 2008 at 18:24

Actually should this check isset($item['view']) instead ? Then no query would be run that hasn't already been run for $item['view'] as least. Or perhaps that doesn't matter in the end, as $item['view'] will always be there if there is a nid..

Log in or register to post comments

Comment #5

yched CreditAttribution: yched commented 22 October 2008 at 15:22

Smart. Since we render the node to get its tokens, the query will have happened anyway and we don't repeat it (at least if the noderef formatter uses _nodereference_titles(), which is the case of all default formatters).

Should we then also have :

- $tokens['title'] = isset($item['view']) ? strip_tags($item['view']) : '';
+ $tokens['title'] = is_numeric($item['nid']) ? check_plain( _nodereference_titles($item['nid'])) : '';