Simple queue loses labels, cannot add new ones. Unusable on multi-lingual sites.

I was just about to report this. I have some debugging info which I'll post in a moment.

I'm bumping this to Major because it's a complete showstopper on any multi-lingual site.

I think this might be a Drupal core issue rather than entity queue. It seems to have been around for a while. I confirmed it on 8.7, 8.8 and 8.9.

It is related to the fact that the target type for the items field of entity_subqueue is set per bundle. Also, content translation creates base field overrides. The base field override loses the fact that the target type is set per bundle so it defaults back to entity_subqueue.

Here's some test code for my queue called test.

    $subqueue = EntitySubqueue::load('test');

    /** @var \Drupal\Core\Entity\EntityFieldManagerInterface $efm */
    $efm = \Drupal::service('entity_field.manager');

    /** @var \Drupal\Core\Field\BaseFieldDefinition $items_defs */
    $items_def = $efm->getFieldDefinitions('entity_subqueue', 'test')['items'];
    $settings = $items_def->getSettings();

The override looks like this (pasted from yaml)

uuid: be7b6eaa-1952-40c4-93c2-5b1fb429c867
langcode: en
status: true
dependencies:
  config:
    - entityqueue.entity_queue.test
id: entity_subqueue.test.items
field_name: items
entity_type: entity_subqueue
bundle: test
label: Items
description: ''
required: false
translatable: false
default_value: {  }
default_value_callback: ''
settings:
  handler: default
  handler_settings: {  }
field_type: entity_reference

The override is applied in Drupal\Core\Entity\EntityFieldManager::buildBundleFieldDefinitions It gets the bundle field definition correctly but a few lines down it is overridden by the override.

As I said, this might be a core issue but it's good to get some visibility here. I think the problem really happens when the override is created in Drupal\Core\Field\Entity\BaseFieldOverride. The createFromBaseFieldDefinition method is not capturing all the bundle specific config.

This looks like it might be due to #2935978: Create a bundle_field_override configuration entity to override a bundle field with configuration not being implemented yet.

See also discussion on #2346347: Finalize API for creating, overriding, and altering code-defined bundle fields.

Here's a patch that I think is a solution for most people.

I looked at the Comment module because it has essentially the same problem with its entity_id field. It avoids the problem simple by making the field non-translatable. I think we can do the same here.

Is there a good reason for the items field to be translatable? That is probably a matter for discussion. Would you ever want different translations of a queue item pointing to a different entity? I think you'd instead want to point to different translations of the same entity but I'm not sure about that so perhaps this patch is not for everyone.

I'm facing the exact same issue.
In my case, I don't want the items field to be translatable, so the patch works perfectly for me.

Thank you.

I foolishly left a couple of unnecessary use statements.

I should put this back to review. Also fixing a spelling typo in title.

Patch #10 works for me. Thank you!

The patch #10 works for me 2.
This is great ! I did freak out on the issue and was about to reinstall entityqueue . Thanks @tetranz

The patch #10 works for, thank you very much!

It's unfortunate that we can't have translatable items per subqueue, but, as far as I see, there's no way around it. Any site that could have tried to use this functionality wouldn't have been able to do it because of the core bug (#2935978: Create a bundle_field_override configuration entity to override a bundle field with configuration).

Committed to 8.x-1.x, thanks a lot everyone!