Prepare Video Embed Field for Drupal 9

Use filesystem service instead, of interface.

$files = \Drupal\Core\File\FileSystemInterface::scanDirectory($icon_folder, '/.*\.(svg|png|jpg|jpeg|gif)$/');

Patch looks fine and applied cleanly. However, tests are failing and seems tests are failing because of colorbox related.

The file specified by the given app root, relative path and file name (/var/www/html//colorbox.info.yml) do not exist. in /var/www/html/core/lib/Drupal/Core/Extension/Extension.php:67

@saurabh.tripathi.cs can u pls check if these failures are specific to patch (which to me looks not) by running tests with and without patch?

@saurabh.tripathi.cs - OK! Then test failing looks not related to the patch.

Please create a new issue for failing tests.

Please add "core_version_requirement" in info.yml and composer.json file.

@saurabh.tripathi.cs earlier, there were only 5 tests failing but with latest patch, its 7 now. So something is not correct. Pls check.

Also,

+++ b/modules/video_embed_media/video_embed_media.install
@@ -18,7 +18,7 @@ function video_embed_media_install() {
+  $files = $file_system->scanDirectory($icon_folder, '/.*\.(svg|png|jpg|jpeg|gif)$/');

This is available only in 8.8 version and thus this module won't be usable for other drupal8 version.

Please do something like

if (method_exists()) {
  // then use new code
}
else {
  // use old one.
}

1. +++ b/composer.json
   @@ -3,5 +3,8 @@
   +    "drupal/core": "^8.7|^9.0"
   

   this should be double pipe not single. See https://www.drupal.org/node/3070687

2. +++ b/video_embed_field.info.yml
   @@ -3,6 +3,7 @@ type: module
   +core_version_requirement: ^8 || ^9
   

   this should be
   ^8.7 || ^9

Test failing looks not related to this.
Also, this patch can not be merged as the only required change regarding file system is in D-8.8 and thus this can only be merged and required only for D-8.8 version.

#20 looks good to me.

Not quite...there are still a couple of calls to entity_get_form_display() in a test. This patch removes them.

Merged #3117181: Declare Drupal 9 compatibility into this one, so it will only take one commit to get this module D9 ready.

Made a couple of small changes which I hope will help fix most, if not all, of the failures.

This should hopefully do better.

I just realized that my approach to the Colorbox info file is potentially destructive if Colorbox is actually installed. Seeing as how it is already explicitly declared as a test dependency, I don't think we need to "fake-enable" Colorbox in the kernel tests; let's enable it for real.

How 'bout this...

Nice, thanks.