Drupal 9 readiness [#3091696]

php drupal-check.phar modules/contrib/simple_pass_reset/
 5/5 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------------------------------------------- 
  Line   src/AccessChecks/ResetPassAccessCheck.php                                               
 ------ ---------------------------------------------------------------------------------------- 
  36     Call to deprecated function drupal_set_message().                                       
  38     Call to deprecated method getUsername() of class Drupal\Core\Session\AccountInterface.  
  39     Call to deprecated method getUsername() of class Drupal\Core\Session\AccountInterface.  
  40     Call to deprecated method url() of class Drupal.                                        
  50     Call to deprecated function drupal_set_message().                                       
  50     Call to deprecated method url() of class Drupal.                                        
 ------ ---------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------ 
  Line   src/Controller/User.php                                     
 ------ ------------------------------------------------------------ 
  32     Call to deprecated method entityManager() of class Drupal.  
 ------ ------------------------------------------------------------ 

                                                                                                                        
 [ERROR] Found 7 errors

Comment	File	Size	Author
#7	interdiff_2-7.txt	294 bytes	raunak.singh
#7	3091696-7.patch	3.88 KB	raunak.singh
#2	deprecated-3091696-2.patch	3.52 KB	sergiu stici

Comments

Comment #1

1 November 2019 at 07:38

Sergiu Stici created an issue. See original summary.

Status	File	Size
new	deprecated-3091696-2.patch	3.52 KB

Comment #3

chris matthews commented 18 November 2019 at 21:58

Parent issue:

» #3095220: Plan for Simple Password Reset 8.x-1.1

Comment #4

jcnventura

English

commented 29 June 2020 at 15:03

Title:

Deprecated Code Report

» Drupal 9 readiness

Just needs the following:

diff --git a/simple_pass_reset.info.yml b/simple_pass_reset.info.yml
index 44484c1..8716f5d 100644
--- a/simple_pass_reset.info.yml
+++ b/simple_pass_reset.info.yml
@@ -3,3 +3,4 @@ type: module
 description: 'When resetting a password, skip the unnecessary and confusing one-time login form.'
 package: User Management
 core: 8.x
+core_version_requirement: ^8 || ^9

That @rahul.nahar001 added 9 days ago in #3141683: Automated Drupal 9 compatibility fixes, and that @Mistrae added 25 days ago in #3145690: Drupal 9 readiness. Also, people, please search the issue queue before adding new issues.