Date CSS not added for all Form API elements

I can confirm this issue with the current 7.x-2.x-dev version. It breaks the node edit display (being used in our front-end theme) compared to the current release version, because the date_api/date.css file is no longer included.

I decided to simply append the date.css in our theme's stylesheet for the time being, so haven't tested the patch yet. Just wanted to chip in that more people are experiencing this issue and that this bug can break CSS for existing sites.

Please note that the issue applies to other element types as well. We've noticed this with the Scheduler module which uses a date_popup element.

Thanks for working on this.

I wonder if we should list date.css as a library using hook_library() and then list it as a dependency in date_popup_library(), and just use e.g. drupal_add_library('date_api', 'date'); when needed?

Do you mean something like this? Testing in a view where I had a exposed date filter using date_popup. With this it load date.css

Yes, that sort of thing, though it needs the long array syntax so it can be compatible with PHP 5.3. Yeah, I know ;-)

Sorry, I missed your feedback on this issue. Here is a "good" old PHP 5.3.x complaint patch. Did not realise date needed to support that that old versions but it sort of make sense.

Tests you say. I could try, but I have to bother you for some more information if you find the time. Where and what do you suggest we should write tests for? Example, test that the library is defined by date_api ?

public function testLibrary() {
  $date_api_path = drupal_get_path('module', 'date_api');
  $date_api_library = drupal_get_library('date_api', 'date_api');

 $this->assertEqual($date_api_library['title'], 'Date module main library', 'Date library found');
 $this->assertEqual($date_api_library["css"][0], $date_api_path . '/date.css', 'Date API CSS found');

Or/and try to test if the date.css is loaded and included edit/creation of node:

$this->drupalGet('node/add/story');
$this->assertResponse(200);
$this->assertRaw('date/date.css');

No export in writing tests for old D7...

I like that idea of adding it as a library dependency.

But this patch only applies to date_popup field types though. What's the best way to capture this method for the other field types such as date_select?

Let's expand this to cover all scenarios where date.css is loaded.

And for the test coverage, the second method to check the output for date/date.css would be fine.

I am writing some testcases . Please review my MR. Thanks

Just curious if anyone was successful in applying the date.css to select fields? I have applied the patch as it stands but my select date select fields (month, day, year) still stack on top of each other rather than float as the CSS styles them.